-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Resources] Add expressionEvaluationOptions property to swagger #11174
[Resources] Add expressionEvaluationOptions property to swagger #11174
Conversation
[Staging] Swagger Validation Report
️✔️ |
Azure Pipelines successfully started running 1 pipeline(s). |
Azure CLI Extension Generation - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-sdk-for-java - Release
|
azure-sdk-for-go - Release
|
azure-sdk-for-net - Release
|
azure-sdk-for-js - Release
|
azure-resource-manager-schemas - Release
|
azure-sdk-for-python - Release
|
azure-sdk-for-python-track2 - Release
|
Trenton Generation - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
/azp run unifiedPipeline |
No pipelines are associated with this pull request. |
@filizt , is this change already implemented in service side? |
@Tiano2017 , can you please review this PR? |
Yes, it's implemented. It's active for at least 6 months now, we're getting the swagger up to date. About the pipeline failures, I don't expect failures to be related to the change. could you kick off SDK JavaScript and SDK Python tasks please? |
Is @Tiano2017 listed as a reviewer? I don't think he reviews swagger PRs anymore. @anthony-c-martin would that be you who would review the PRs? |
There are multiple reviews needed on each PR:
@Tiano2017 is showing up because of (3), meaning you'll still need sign-off from (1) & (2). Not totally sure on the best way to handle CODEOWNERS because the directory is shared among multiple teams with no simple way to break it up. @raych1 any suggestions? |
Yes, @Tiano2017 @rajshah11 @vivsriaus are displayed as code owner of |
@filizt , can you please ask one of code owner to review the PR and sign off? |
/azp run unifiedPipeline |
Commenter does not have sufficient privileges for PR 11174 in repo Azure/azure-rest-api-specs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Co-authored-by: Filiz Topatan <[email protected]>
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.
Please follow the link to find more details on PR review process.