Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AKS] Swagger Bugfix: upgradeNodeImageVersion should be an agent pools operation #10879

Merged
merged 1 commit into from
Sep 24, 2020

Conversation

gtxistxgao
Copy link
Contributor

@gtxistxgao gtxistxgao commented Sep 22, 2020

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

"Upgrade Node Image Version" API is under "Managed Clusters" tab, which is wrong as it is an agent pool only operation. So it should be in "Agent Pools" tag. The python SDK also put it under "ManagedClustersOperations".

I made a mistake in the swagger PR that put a "ManagedClusters" before it. #10294

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

  • Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.

    • Adding new API(s)
    • Adding a new API version
    • Adding a new service
  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in stable version
  • Removing properties in stable version
  • Removing API version(s) in stable version
  • Updating API in stable version with Breaking Change Validation errors
  • Updating API(s) in preview over 1 year

Please follow the link to find more details on PR review process.

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Sep 22, 2020

[Staging] Swagger Validation Report

BreakingChange: 2 Errors, 0 Warnings [Detail] [Expand]
Rule Message
1008 - ModifiedOperationId The operation id has been changed from 'ManagedClusters_UpgradeNodeImageVersion' to 'AgentPools_UpgradeNodeImageVersion'. This will impact generated code.
New: Microsoft.ContainerService/stable/2020-07-01/managedClusters.json#L1231:7
Old: Microsoft.ContainerService/stable/2020-07-01/managedClusters.json#L1231:7
1008 - ModifiedOperationId The operation id has been changed from 'ManagedClusters_UpgradeNodeImageVersion' to 'AgentPools_UpgradeNodeImageVersion'. This will impact generated code.
New: Microsoft.ContainerService/stable/2020-09-01/managedClusters.json#L1322:7
Old: Microsoft.ContainerService/stable/2020-09-01/managedClusters.json#L1322:7
️✔️LintDiff [Detail]
 Validation passes for LintDiff. 
️✔️Avocado [Detail]
 Validation passes for Avocado. 
️✔️ModelValidation [Detail]
 Validation passes for ModelValidation. 
️✔️SemanticValidation [Detail]
 Validation passes for SemanticValidation. 
Posted by Swagger Pipeline | How to fix these errors?

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Sep 22, 2020

azure-sdk-for-js - Release

️✔️ succeeded [Logs] [Expand Details]
  • ️✔️ Generate from b035666 with merge commit 30832c2. SDK Automation 13.0.17.20200918.2
  • ️✔️@azure/arm-containerservice [View full logs]  [Release SDK Changes]
    Only show 100 items here, please refer to log for details.
    [npmPack] npm WARN deprecated [email protected]: This package has been deprecated and is no longer maintained. Please use @rollup/plugin-node-resolve.
    [npmPack] npm WARN deprecated [email protected]: https://github.com/lydell/resolve-url#deprecated
    [npmPack] npm WARN deprecated [email protected]: Please see https://github.com/lydell/urix#deprecated
    [npmPack] npm notice created a lockfile as package-lock.json. You should commit this file.
    [npmPack] loaded rollup.config.js with warnings
    [npmPack] (!) Unused external imports
    [npmPack] default imported from external module 'rollup' but never used
    [npmPack] 
    [npmPack] ./esm/containerServiceClient.js → ./dist/arm-containerservice.js...
    [npmPack] created ./dist/arm-containerservice.js in 541ms
    [npmPack] npm notice 
    [npmPack] npm notice package: @azure/[email protected]
    [npmPack] npm notice === Tarball Contents === 
    [npmPack] npm notice 13.3kB  esm/operations/agentPools.js                          
    [npmPack] npm notice 2.3kB   esm/models/agentPoolsMappers.js                       
    [npmPack] npm notice 224.1kB dist/arm-containerservice.js                          
    [npmPack] npm notice 80.3kB  dist/arm-containerservice.min.js                      
    [npmPack] npm notice 2.2kB   esm/containerServiceClient.js                         
    [npmPack] npm notice 2.6kB   esm/containerServiceClientContext.js                  
    [npmPack] npm notice 11.8kB  esm/operations/containerServices.js                   
    [npmPack] npm notice 2.2kB   esm/models/containerServicesMappers.js                
    [npmPack] npm notice 345B    esm/models/index.js                                   
    [npmPack] npm notice 660B    esm/operations/index.js                               
    [npmPack] npm notice 28.2kB  esm/operations/managedClusters.js                     
    [npmPack] npm notice 2.3kB   esm/models/managedClustersMappers.js                  
    [npmPack] npm notice 88.0kB  esm/models/mappers.js                                 
    [npmPack] npm notice 12.6kB  esm/operations/openShiftManagedClusters.js            
    [npmPack] npm notice 2.1kB   esm/models/openShiftManagedClustersMappers.js         
    [npmPack] npm notice 1.6kB   esm/operations/operations.js                          
    [npmPack] npm notice 458B    esm/models/operationsMappers.js                       
    [npmPack] npm notice 4.4kB   esm/models/parameters.js                              
    [npmPack] npm notice 7.2kB   esm/operations/privateEndpointConnections.js          
    [npmPack] npm notice 2.1kB   esm/models/privateEndpointConnectionsMappers.js       
    [npmPack] npm notice 2.0kB   esm/operations/privateLinkResources.js                
    [npmPack] npm notice 484B    esm/models/privateLinkResourcesMappers.js             
    [npmPack] npm notice 2.3kB   esm/operations/resolvePrivateLinkServiceId.js         
    [npmPack] npm notice 459B    esm/models/resolvePrivateLinkServiceIdMappers.js      
    [npmPack] npm notice 1.0kB   rollup.config.js                                      
    [npmPack] npm notice 1.7kB   package.json                                          
    [npmPack] npm notice 457B    tsconfig.json                                         
    [npmPack] npm notice 3.7kB   esm/operations/agentPools.d.ts.map                    
    [npmPack] npm notice 6.3kB   esm/operations/agentPools.js.map                      
    [npmPack] npm notice 929B    esm/models/agentPoolsMappers.d.ts.map                 
    [npmPack] npm notice 942B    esm/models/agentPoolsMappers.js.map                   
    [npmPack] npm notice 430.5kB dist/arm-containerservice.js.map                      
    [npmPack] npm notice 58.7kB  dist/arm-containerservice.min.js.map                  
    [npmPack] npm notice 891B    esm/containerServiceClient.d.ts.map                   
    [npmPack] npm notice 1.2kB   esm/containerServiceClient.js.map                     
    [npmPack] npm notice 480B    esm/containerServiceClientContext.d.ts.map            
    [npmPack] npm notice 1.3kB   esm/containerServiceClientContext.js.map              
    [npmPack] npm notice 3.4kB   esm/operations/containerServices.d.ts.map             
    [npmPack] npm notice 5.6kB   esm/operations/containerServices.js.map               
    [npmPack] npm notice 930B    esm/models/containerServicesMappers.d.ts.map          
    [npmPack] npm notice 943B    esm/models/containerServicesMappers.js.map            
    [npmPack] npm notice 30.4kB  esm/models/index.d.ts.map                             
    [npmPack] npm notice 296B    esm/operations/index.d.ts.map                         
    [npmPack] npm notice 126B    esm/models/index.js.map                               
    [npmPack] npm notice 311B    esm/operations/index.js.map                           
    [npmPack] npm notice 7.1kB   esm/operations/managedClusters.d.ts.map               
    [npmPack] npm notice 13.2kB  esm/operations/managedClusters.js.map                 
    [npmPack] npm notice 962B    esm/models/managedClustersMappers.d.ts.map            
    [npmPack] npm notice 975B    esm/models/managedClustersMappers.js.map              
    [npmPack] npm notice 3.9kB   esm/models/mappers.d.ts.map                           
    [npmPack] npm notice 46.9kB  esm/models/mappers.js.map                             
    [npmPack] npm notice 3.3kB   esm/operations/openShiftManagedClusters.d.ts.map      
    [npmPack] npm notice 5.9kB   esm/operations/openShiftManagedClusters.js.map        
    [npmPack] npm notice 915B    esm/models/openShiftManagedClustersMappers.d.ts.map   
    [npmPack] npm notice 928B    esm/models/openShiftManagedClustersMappers.js.map     
    [npmPack] npm notice 663B    esm/operations/operations.d.ts.map                    
    [npmPack] npm notice 908B    esm/operations/operations.js.map                      
    [npmPack] npm notice 212B    esm/models/operationsMappers.d.ts.map                 
    [npmPack] npm notice 225B    esm/models/operationsMappers.js.map                   
    [npmPack] npm notice 968B    esm/models/parameters.d.ts.map                        
    [npmPack] npm notice 3.3kB   esm/models/parameters.js.map                          
    [npmPack] npm notice 2.3kB   esm/operations/privateEndpointConnections.d.ts.map    
    [npmPack] npm notice 3.4kB   esm/operations/privateEndpointConnections.js.map      
    [npmPack] npm notice 909B    esm/models/privateEndpointConnectionsMappers.d.ts.map 
    [npmPack] npm notice 922B    esm/models/privateEndpointConnectionsMappers.js.map   
    [npmPack] npm notice 819B    esm/operations/privateLinkResources.d.ts.map          
    [npmPack] npm notice 1.1kB   esm/operations/privateLinkResources.js.map            
    [npmPack] npm notice 235B    esm/models/privateLinkResourcesMappers.d.ts.map       
    [npmPack] npm notice 248B    esm/models/privateLinkResourcesMappers.js.map         
    [npmPack] npm notice 934B    esm/operations/resolvePrivateLinkServiceId.d.ts.map   
    [npmPack] npm notice 1.2kB   esm/operations/resolvePrivateLinkServiceId.js.map     
    [npmPack] npm notice 236B    esm/models/resolvePrivateLinkServiceIdMappers.d.ts.map
    [npmPack] npm notice 249B    esm/models/resolvePrivateLinkServiceIdMappers.js.map  
    [npmPack] npm notice 3.3kB   README.md                                             
    [npmPack] npm notice 11.2kB  esm/operations/agentPools.d.ts                        
    [npmPack] npm notice 20.4kB  src/operations/agentPools.ts                          
    [npmPack] npm notice 1.9kB   esm/models/agentPoolsMappers.d.ts                     
    [npmPack] npm notice 2.3kB   src/models/agentPoolsMappers.ts                       
    [npmPack] npm notice 1.5kB   esm/containerServiceClient.d.ts                       
    [npmPack] npm notice 2.5kB   src/containerServiceClient.ts                         
    [npmPack] npm notice 898B    esm/containerServiceClientContext.d.ts                
    [npmPack] npm notice 2.4kB   src/containerServiceClientContext.ts                  
    [npmPack] npm notice 12.9kB  esm/operations/containerServices.d.ts                 
    [npmPack] npm notice 21.3kB  src/operations/containerServices.ts                   
    [npmPack] npm notice 1.9kB   esm/models/containerServicesMappers.d.ts              
    [npmPack] npm notice 2.3kB   src/models/containerServicesMappers.ts                
    [npmPack] npm notice 105.1kB esm/models/index.d.ts                                 

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Sep 22, 2020

azure-sdk-for-java - Release

️✔️ succeeded [Logs] [Expand Details]
  • ️✔️ Generate from b035666 with merge commit 30832c2. SDK Automation 13.0.17.20200918.2
  • ️✔️sdk/containerservice/mgmt-v2019_06_01 [View full logs]  [Release SDK Changes]
    Unable to get details about the head commit. This is probably because the head commit is in a fork that we don't have permission to read from. HttpError: Not Found {"name":"HttpError","status":404,"headers":{"access-control-allow-origin":"*","access-control-expose-headers":"ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Used, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type, Deprecation, Sunset","connection":"close","content-encoding":"gzip","content-security-policy":"default-src 'none'","content-type":"application/json; charset=utf-8","date":"Thu, 24 Sep 2020 09:35:28 GMT","referrer-policy":"origin-when-cross-origin, strict-origin-when-cross-origin","server":"GitHub.com","status":"404 Not Found","strict-transport-security":"max-age=31536000; includeSubdomains; preload","transfer-encoding":"chunked","vary":"Accept-Encoding, Accept, X-Requested-With","x-content-type-options":"nosniff","x-frame-options":"deny","x-github-media-type":"github.v3; param=machine-man-preview; format=json","x-github-request-id":"0402:0776:79190E6:90FC27B:5F6C6860","x-xss-protection":"1; mode=block"},"request":{"method":"POST","url":"https://api.github.com/app/installations//access_tokens","headers":{"accept":"application/vnd.github.machine-man-preview+json","user-agent":"octokit.js/16.43.1 Node.js/13.14.0 (Linux 5.4; x64)","authorization":"bearer [REDACTED]","content-type":"application/json; charset=utf-8"},"body":"{}","request":{"validate":{"commit_sha":{"alias":"ref","deprecated":true,"type":"string"},"owner":{"required":true,"type":"string"},"ref":{"required":true,"type":"string"},"repo":{"required":true,"type":"string"},"sha":{"alias":"ref","deprecated":true,"type":"string"}}}},"documentation_url":"https://docs.github.com/rest"}
  • ️✔️sdk/containerservice/mgmt-v2019_08_01 [View full logs]  [Release SDK Changes]
    Unable to get details about the head commit. This is probably because the head commit is in a fork that we don't have permission to read from. HttpError: Not Found {"name":"HttpError","status":404,"headers":{"access-control-allow-origin":"*","access-control-expose-headers":"ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Used, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type, Deprecation, Sunset","connection":"close","content-encoding":"gzip","content-security-policy":"default-src 'none'","content-type":"application/json; charset=utf-8","date":"Thu, 24 Sep 2020 09:35:39 GMT","referrer-policy":"origin-when-cross-origin, strict-origin-when-cross-origin","server":"GitHub.com","status":"404 Not Found","strict-transport-security":"max-age=31536000; includeSubdomains; preload","transfer-encoding":"chunked","vary":"Accept-Encoding, Accept, X-Requested-With","x-content-type-options":"nosniff","x-frame-options":"deny","x-github-media-type":"github.v3; param=machine-man-preview; format=json","x-github-request-id":"0401:065B:7F14C39:97B1025:5F6C686A","x-xss-protection":"1; mode=block"},"request":{"method":"POST","url":"https://api.github.com/app/installations//access_tokens","headers":{"accept":"application/vnd.github.machine-man-preview+json","user-agent":"octokit.js/16.43.1 Node.js/13.14.0 (Linux 5.4; x64)","authorization":"bearer [REDACTED]","content-type":"application/json; charset=utf-8"},"body":"{}","request":{"validate":{"commit_sha":{"alias":"ref","deprecated":true,"type":"string"},"owner":{"required":true,"type":"string"},"ref":{"required":true,"type":"string"},"repo":{"required":true,"type":"string"},"sha":{"alias":"ref","deprecated":true,"type":"string"}}}},"documentation_url":"https://docs.github.com/rest"}
  • ️✔️sdk/containerservice/mgmt-v2019_10_01 [View full logs]  [Release SDK Changes]
    Unable to get details about the head commit. This is probably because the head commit is in a fork that we don't have permission to read from. HttpError: Not Found {"name":"HttpError","status":404,"headers":{"access-control-allow-origin":"*","access-control-expose-headers":"ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Used, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type, Deprecation, Sunset","connection":"close","content-encoding":"gzip","content-security-policy":"default-src 'none'","content-type":"application/json; charset=utf-8","date":"Thu, 24 Sep 2020 09:35:49 GMT","referrer-policy":"origin-when-cross-origin, strict-origin-when-cross-origin","server":"GitHub.com","status":"404 Not Found","strict-transport-security":"max-age=31536000; includeSubdomains; preload","transfer-encoding":"chunked","vary":"Accept-Encoding, Accept, X-Requested-With","x-content-type-options":"nosniff","x-frame-options":"deny","x-github-media-type":"github.v3; param=machine-man-preview; format=json","x-github-request-id":"0402:0777:D36D8F5:FDC9523:5F6C6875","x-xss-protection":"1; mode=block"},"request":{"method":"POST","url":"https://api.github.com/app/installations//access_tokens","headers":{"accept":"application/vnd.github.machine-man-preview+json","user-agent":"octokit.js/16.43.1 Node.js/13.14.0 (Linux 5.4; x64)","authorization":"bearer [REDACTED]","content-type":"application/json; charset=utf-8"},"body":"{}","request":{"validate":{"commit_sha":{"alias":"ref","deprecated":true,"type":"string"},"owner":{"required":true,"type":"string"},"ref":{"required":true,"type":"string"},"repo":{"required":true,"type":"string"},"sha":{"alias":"ref","deprecated":true,"type":"string"}}}},"documentation_url":"https://docs.github.com/rest"}
  • ️✔️sdk/containerservice/mgmt-v2019_11_01 [View full logs]  [Release SDK Changes]
    Unable to get details about the head commit. This is probably because the head commit is in a fork that we don't have permission to read from. HttpError: Not Found {"name":"HttpError","status":404,"headers":{"access-control-allow-origin":"*","access-control-expose-headers":"ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Used, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type, Deprecation, Sunset","connection":"close","content-encoding":"gzip","content-security-policy":"default-src 'none'","content-type":"application/json; charset=utf-8","date":"Thu, 24 Sep 2020 09:36:02 GMT","referrer-policy":"origin-when-cross-origin, strict-origin-when-cross-origin","server":"GitHub.com","status":"404 Not Found","strict-transport-security":"max-age=31536000; includeSubdomains; preload","transfer-encoding":"chunked","vary":"Accept-Encoding, Accept, X-Requested-With","x-content-type-options":"nosniff","x-frame-options":"deny","x-github-media-type":"github.v3; param=machine-man-preview; format=json","x-github-request-id":"0403:31DD:1A8B9D9:2E40300:5F6C6882","x-xss-protection":"1; mode=block"},"request":{"method":"POST","url":"https://api.github.com/app/installations//access_tokens","headers":{"accept":"application/vnd.github.machine-man-preview+json","user-agent":"octokit.js/16.43.1 Node.js/13.14.0 (Linux 5.4; x64)","authorization":"bearer [REDACTED]","content-type":"application/json; charset=utf-8"},"body":"{}","request":{"validate":{"commit_sha":{"alias":"ref","deprecated":true,"type":"string"},"owner":{"required":true,"type":"string"},"ref":{"required":true,"type":"string"},"repo":{"required":true,"type":"string"},"sha":{"alias":"ref","deprecated":true,"type":"string"}}}},"documentation_url":"https://docs.github.com/rest"}
  • ️✔️sdk/containerservice/mgmt-v2020_01_01 [View full logs]  [Release SDK Changes]
    Unable to get details about the head commit. This is probably because the head commit is in a fork that we don't have permission to read from. HttpError: Not Found {"name":"HttpError","status":404,"headers":{"access-control-allow-origin":"*","access-control-expose-headers":"ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Used, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type, Deprecation, Sunset","connection":"close","content-encoding":"gzip","content-security-policy":"default-src 'none'","content-type":"application/json; charset=utf-8","date":"Thu, 24 Sep 2020 09:36:12 GMT","referrer-policy":"origin-when-cross-origin, strict-origin-when-cross-origin","server":"GitHub.com","status":"404 Not Found","strict-transport-security":"max-age=31536000; includeSubdomains; preload","transfer-encoding":"chunked","vary":"Accept-Encoding, Accept, X-Requested-With","x-content-type-options":"nosniff","x-frame-options":"deny","x-github-media-type":"github.v3; param=machine-man-preview; format=json","x-github-request-id":"0409:2FED:1C4F347:3019CAC:5F6C688C","x-xss-protection":"1; mode=block"},"request":{"method":"POST","url":"https://api.github.com/app/installations//access_tokens","headers":{"accept":"application/vnd.github.machine-man-preview+json","user-agent":"octokit.js/16.43.1 Node.js/13.14.0 (Linux 5.4; x64)","authorization":"bearer [REDACTED]","content-type":"application/json; charset=utf-8"},"body":"{}","request":{"validate":{"commit_sha":{"alias":"ref","deprecated":true,"type":"string"},"owner":{"required":true,"type":"string"},"ref":{"required":true,"type":"string"},"repo":{"required":true,"type":"string"},"sha":{"alias":"ref","deprecated":true,"type":"string"}}}},"documentation_url":"https://docs.github.com/rest"}
  • ️✔️sdk/containerservice/mgmt-v2020_02_01 [View full logs]  [Release SDK Changes]
    Unable to get details about the head commit. This is probably because the head commit is in a fork that we don't have permission to read from. HttpError: Not Found {"name":"HttpError","status":404,"headers":{"access-control-allow-origin":"*","access-control-expose-headers":"ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Used, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type, Deprecation, Sunset","connection":"close","content-encoding":"gzip","content-security-policy":"default-src 'none'","content-type":"application/json; charset=utf-8","date":"Thu, 24 Sep 2020 09:36:22 GMT","referrer-policy":"origin-when-cross-origin, strict-origin-when-cross-origin","server":"GitHub.com","status":"404 Not Found","strict-transport-security":"max-age=31536000; includeSubdomains; preload","transfer-encoding":"chunked","vary":"Accept-Encoding, Accept, X-Requested-With","x-content-type-options":"nosniff","x-frame-options":"deny","x-github-media-type":"github.v3; param=machine-man-preview; format=json","x-github-request-id":"0405:5037:1800EBB:434477F:5F6C6896","x-xss-protection":"1; mode=block"},"request":{"method":"POST","url":"https://api.github.com/app/installations//access_tokens","headers":{"accept":"application/vnd.github.machine-man-preview+json","user-agent":"octokit.js/16.43.1 Node.js/13.14.0 (Linux 5.4; x64)","authorization":"bearer [REDACTED]","content-type":"application/json; charset=utf-8"},"body":"{}","request":{"validate":{"commit_sha":{"alias":"ref","deprecated":true,"type":"string"},"owner":{"required":true,"type":"string"},"ref":{"required":true,"type":"string"},"repo":{"required":true,"type":"string"},"sha":{"alias":"ref","deprecated":true,"type":"string"}}}},"documentation_url":"https://docs.github.com/rest"}
  • ️✔️sdk/containerservice/mgmt-v2020_03_01 [View full logs]  [Release SDK Changes]
    Unable to get details about the head commit. This is probably because the head commit is in a fork that we don't have permission to read from. HttpError: Not Found {"name":"HttpError","status":404,"headers":{"access-control-allow-origin":"*","access-control-expose-headers":"ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Used, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type, Deprecation, Sunset","connection":"close","content-encoding":"gzip","content-security-policy":"default-src 'none'","content-type":"application/json; charset=utf-8","date":"Thu, 24 Sep 2020 09:36:33 GMT","referrer-policy":"origin-when-cross-origin, strict-origin-when-cross-origin","server":"GitHub.com","status":"404 Not Found","strict-transport-security":"max-age=31536000; includeSubdomains; preload","transfer-encoding":"chunked","vary":"Accept-Encoding, Accept, X-Requested-With","x-content-type-options":"nosniff","x-frame-options":"deny","x-github-media-type":"github.v3; param=machine-man-preview; format=json","x-github-request-id":"0408:799B:3557B35:7D01915:5F6C68A1","x-xss-protection":"1; mode=block"},"request":{"method":"POST","url":"https://api.github.com/app/installations//access_tokens","headers":{"accept":"application/vnd.github.machine-man-preview+json","user-agent":"octokit.js/16.43.1 Node.js/13.14.0 (Linux 5.4; x64)","authorization":"bearer [REDACTED]","content-type":"application/json; charset=utf-8"},"body":"{}","request":{"validate":{"commit_sha":{"alias":"ref","deprecated":true,"type":"string"},"owner":{"required":true,"type":"string"},"ref":{"required":true,"type":"string"},"repo":{"required":true,"type":"string"},"sha":{"alias":"ref","deprecated":true,"type":"string"}}}},"documentation_url":"https://docs.github.com/rest"}
  • ️✔️sdk/containerservice/mgmt-v2020_04_01 [View full logs]  [Release SDK Changes]
    Unable to get details about the head commit. This is probably because the head commit is in a fork that we don't have permission to read from. HttpError: Not Found {"name":"HttpError","status":404,"headers":{"access-control-allow-origin":"*","access-control-expose-headers":"ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Used, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type, Deprecation, Sunset","connection":"close","content-encoding":"gzip","content-security-policy":"default-src 'none'","content-type":"application/json; charset=utf-8","date":"Thu, 24 Sep 2020 09:36:43 GMT","referrer-policy":"origin-when-cross-origin, strict-origin-when-cross-origin","server":"GitHub.com","status":"404 Not Found","strict-transport-security":"max-age=31536000; includeSubdomains; preload","transfer-encoding":"chunked","vary":"Accept-Encoding, Accept, X-Requested-With","x-content-type-options":"nosniff","x-frame-options":"deny","x-github-media-type":"github.v3; param=machine-man-preview; format=json","x-github-request-id":"0401:1D43:4EAC7A:1035C71:5F6C68AB","x-xss-protection":"1; mode=block"},"request":{"method":"POST","url":"https://api.github.com/app/installations//access_tokens","headers":{"accept":"application/vnd.github.machine-man-preview+json","user-agent":"octokit.js/16.43.1 Node.js/13.14.0 (Linux 5.4; x64)","authorization":"bearer [REDACTED]","content-type":"application/json; charset=utf-8"},"body":"{}","request":{"validate":{"commit_sha":{"alias":"ref","deprecated":true,"type":"string"},"owner":{"required":true,"type":"string"},"ref":{"required":true,"type":"string"},"repo":{"required":true,"type":"string"},"sha":{"alias":"ref","deprecated":true,"type":"string"}}}},"documentation_url":"https://docs.github.com/rest"}
  • ️✔️sdk/containerservice/mgmt-v2020_06_01 [View full logs]  [Release SDK Changes]
    Unable to get details about the head commit. This is probably because the head commit is in a fork that we don't have permission to read from. HttpError: Not Found {"name":"HttpError","status":404,"headers":{"access-control-allow-origin":"*","access-control-expose-headers":"ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Used, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type, Deprecation, Sunset","connection":"close","content-encoding":"gzip","content-security-policy":"default-src 'none'","content-type":"application/json; charset=utf-8","date":"Thu, 24 Sep 2020 09:36:55 GMT","referrer-policy":"origin-when-cross-origin, strict-origin-when-cross-origin","server":"GitHub.com","status":"404 Not Found","strict-transport-security":"max-age=31536000; includeSubdomains; preload","transfer-encoding":"chunked","vary":"Accept-Encoding, Accept, X-Requested-With","x-content-type-options":"nosniff","x-frame-options":"deny","x-github-media-type":"github.v3; param=machine-man-preview; format=json","x-github-request-id":"0405:1082:1DD7042:31DC248:5F6C68B7","x-xss-protection":"1; mode=block"},"request":{"method":"POST","url":"https://api.github.com/app/installations//access_tokens","headers":{"accept":"application/vnd.github.machine-man-preview+json","user-agent":"octokit.js/16.43.1 Node.js/13.14.0 (Linux 5.4; x64)","authorization":"bearer [REDACTED]","content-type":"application/json; charset=utf-8"},"body":"{}","request":{"validate":{"commit_sha":{"alias":"ref","deprecated":true,"type":"string"},"owner":{"required":true,"type":"string"},"ref":{"required":true,"type":"string"},"repo":{"required":true,"type":"string"},"sha":{"alias":"ref","deprecated":true,"type":"string"}}}},"documentation_url":"https://docs.github.com/rest"}
  • ️✔️sdk/containerservice/mgmt-v2020_07_01 [View full logs]  [Release SDK Changes]
    Unable to get details about the head commit. This is probably because the head commit is in a fork that we don't have permission to read from. HttpError: Not Found {"name":"HttpError","status":404,"headers":{"access-control-allow-origin":"*","access-control-expose-headers":"ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Used, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type, Deprecation, Sunset","connection":"close","content-encoding":"gzip","content-security-policy":"default-src 'none'","content-type":"application/json; charset=utf-8","date":"Thu, 24 Sep 2020 09:37:08 GMT","referrer-policy":"origin-when-cross-origin, strict-origin-when-cross-origin","server":"GitHub.com","status":"404 Not Found","strict-transport-security":"max-age=31536000; includeSubdomains; preload","transfer-encoding":"chunked","vary":"Accept-Encoding, Accept, X-Requested-With","x-content-type-options":"nosniff","x-frame-options":"deny","x-github-media-type":"github.v3; param=machine-man-preview; format=json","x-github-request-id":"0403:39AC:3419C23:7F3AA55:5F6C68C4","x-xss-protection":"1; mode=block"},"request":{"method":"POST","url":"https://api.github.com/app/installations//access_tokens","headers":{"accept":"application/vnd.github.machine-man-preview+json","user-agent":"octokit.js/16.43.1 Node.js/13.14.0 (Linux 5.4; x64)","authorization":"bearer [REDACTED]","content-type":"application/json; charset=utf-8"},"body":"{}","request":{"validate":{"commit_sha":{"alias":"ref","deprecated":true,"type":"string"},"owner":{"required":true,"type":"string"},"ref":{"required":true,"type":"string"},"repo":{"required":true,"type":"string"},"sha":{"alias":"ref","deprecated":true,"type":"string"}}}},"documentation_url":"https://docs.github.com/rest"}
  • ️✔️sdk/containerservice/mgmt-v2020_09_01 [View full logs]  [Release SDK Changes]
    Unable to get details about the head commit. This is probably because the head commit is in a fork that we don't have permission to read from. HttpError: Not Found {"name":"HttpError","status":404,"headers":{"access-control-allow-origin":"*","access-control-expose-headers":"ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Used, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type, Deprecation, Sunset","connection":"close","content-encoding":"gzip","content-security-policy":"default-src 'none'","content-type":"application/json; charset=utf-8","date":"Thu, 24 Sep 2020 09:37:17 GMT","referrer-policy":"origin-when-cross-origin, strict-origin-when-cross-origin","server":"GitHub.com","status":"404 Not Found","strict-transport-security":"max-age=31536000; includeSubdomains; preload","transfer-encoding":"chunked","vary":"Accept-Encoding, Accept, X-Requested-With","x-content-type-options":"nosniff","x-frame-options":"deny","x-github-media-type":"github.v3; param=machine-man-preview; format=json","x-github-request-id":"0402:4FF2:5260F88:B599F04:5F6C68CD","x-xss-protection":"1; mode=block"},"request":{"method":"POST","url":"https://api.github.com/app/installations//access_tokens","headers":{"accept":"application/vnd.github.machine-man-preview+json","user-agent":"octokit.js/16.43.1 Node.js/13.14.0 (Linux 5.4; x64)","authorization":"bearer [REDACTED]","content-type":"application/json; charset=utf-8"},"body":"{}","request":{"validate":{"commit_sha":{"alias":"ref","deprecated":true,"type":"string"},"owner":{"required":true,"type":"string"},"ref":{"required":true,"type":"string"},"repo":{"required":true,"type":"string"},"sha":{"alias":"ref","deprecated":true,"type":"string"}}}},"documentation_url":"https://docs.github.com/rest"}

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Sep 22, 2020

Trenton Generation - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Sep 22, 2020

Azure CLI Extension Generation - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Sep 22, 2020

azure-sdk-for-python - Release

- Breaking Change detected in SDK

⚠️ warning [Logs] [Expand Details]
  • ⚠️ Generate from b035666 with merge commit 30832c2. SDK Automation 13.0.17.20200918.2
    [azure-mgmt-containerservice][after_scripts|python] WARNING:__main__:Found too much API version: {'2019-04-01', '2017-07-01'} in label v2017_07_01
    [azure-mgmt-containerservice][after_scripts|python] WARNING:__main__:Guessing you want 2017-07-01 based on label v2017_07_01
  • ⚠️azure-mgmt-containerservice [View full logs]  [Release SDK Changes] Breaking Change Detected
    [build_conf] INFO:packaging_tools:Building template azure-mgmt-containerservice
    [build_conf] INFO:packaging_tools.conf:Skipping default conf since the file exists
    [build_conf] INFO:packaging_tools:Skipping CHANGELOG.md template, since a previous one was found
    [build_conf] INFO:packaging_tools:Template done azure-mgmt-containerservice
    [after_scripts|python] WARNING:__main__:Found too much API version: {'2019-04-01', '2017-07-01'} in label v2017_07_01
    [after_scripts|python] WARNING:__main__:Guessing you want 2017-07-01 based on label v2017_07_01
    [build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
    [build_package]   warnings.warn(msg)
    [build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
    [build_package]   warnings.warn(msg)
    Unable to get details about the head commit. This is probably because the head commit is in a fork that we don't have permission to read from. HttpError: Not Found {"name":"HttpError","status":404,"headers":{"access-control-allow-origin":"*","access-control-expose-headers":"ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Used, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type, Deprecation, Sunset","connection":"close","content-encoding":"gzip","content-security-policy":"default-src 'none'","content-type":"application/json; charset=utf-8","date":"Thu, 24 Sep 2020 09:23:11 GMT","referrer-policy":"origin-when-cross-origin, strict-origin-when-cross-origin","server":"GitHub.com","status":"404 Not Found","strict-transport-security":"max-age=31536000; includeSubdomains; preload","transfer-encoding":"chunked","vary":"Accept-Encoding, Accept, X-Requested-With","x-content-type-options":"nosniff","x-frame-options":"deny","x-github-media-type":"github.v3; param=machine-man-preview; format=json","x-github-request-id":"07C3:E401:E8F53E5:11811E0C:5F6C657F","x-xss-protection":"1; mode=block"},"request":{"method":"POST","url":"https://api.github.com/app/installations//access_tokens","headers":{"accept":"application/vnd.github.machine-man-preview+json","user-agent":"octokit.js/16.43.1 Node.js/13.14.0 (Linux 5.4; x64)","authorization":"bearer [REDACTED]","content-type":"application/json; charset=utf-8"},"body":"{}","request":{"validate":{"commit_sha":{"alias":"ref","deprecated":true,"type":"string"},"owner":{"required":true,"type":"string"},"ref":{"required":true,"type":"string"},"repo":{"required":true,"type":"string"},"sha":{"alias":"ref","deprecated":true,"type":"string"}}}},"documentation_url":"https://docs.github.com/rest"}
    [breaking_change_setup] Ignoring mock: markers 'python_version <= "2.7"' don't match your environment
    [ChangeLog] Size of delta 0.777% size of original (original: 65746 chars, delta: 511 chars)
    [ChangeLog] **Features**
    [ChangeLog] 
    [ChangeLog]   - Added operation AgentPoolsOperations.upgrade_node_image_version
    [ChangeLog] 
    [ChangeLog] **Breaking changes**
    [ChangeLog] 
    [ChangeLog]   - Removed operation ManagedClustersOperations.upgrade_node_image_version

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Sep 22, 2020

azure-sdk-for-go - Release

failed [Logs] [Expand Details]
  • Generate from b035666 with merge commit 30832c2. SDK Automation 13.0.17.20200918.2
    [AutoRest] FATAL: System.InvalidOperationException: output-folder /z/work/src/github.com/Azure/azure-sdk-for-go/services/preview/containerservice/mgmt/2019-10-27-preview/containerservice of tag package-2019-10-27-preview must not be under a preview subdirectory for a stable swagger set. Please refer the sample for readme.go.md file here https://github.com/Azure/azure-rest-api-specs/blob/master/documentation/samplefiles/readme.go.md for more information
    [AutoRest]    at AutoRest.Go.CodeGeneratorGo.PreviewCheck(String folder) in /home/vsts/work/1/s/src/CodeGeneratorGo.cs:line 187
    [AutoRest]    at AutoRest.Go.CodeGeneratorGo.d__7.MoveNext() in /home/vsts/work/1/s/src/CodeGeneratorGo.cs:line 60
    [AutoRest] --- End of stack trace from previous location where exception was thrown ---
    [AutoRest]    at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
    [AutoRest]    at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
    [AutoRest]    at AutoRest.Go.Program.d__3.MoveNext() in /home/vsts/work/1/s/src/Program.cs:line 107
    [AutoRest] --- End of stack trace from previous location where exception was thrown ---
    [AutoRest]    at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
    [AutoRest]    at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
    [AutoRest]    at System.Runtime.CompilerServices.TaskAwaiter`1.GetResult()
    [AutoRest]    at NewPlugin.d__20.MoveNext() in /home/vsts/work/1/s/autorest.common/src/Plugins/NewPlugin.cs:line 163
    [AutoRest] FATAL: go/generate - FAILED
    [AutoRest] FATAL: Error: Plugin go reported failure.
    [AutoRest] Failure during batch task - {"tag":"package-2019-10-27-preview"} -- Error: Plugin go reported failure..
    [AutoRest]   Error: Plugin go reported failure.
    Failed to run autorest.
    Error: /z/node_modules/.bin/autorest [email protected]/autorest.go@~2.1.155 --go --verbose --multiapi --use-onever --preview-chk --version=V2 --go-sdk-folder=/z/work/src/github.com/Azure/azure-sdk-for-go /z/work/azure-rest-api-specs/specification/containerservice/resource-manager/readme.md FATAL: System.InvalidOperationException: output-folder /z/work/src/github.com/Azure/azure-sdk-for-go/services/preview/containerservice/mgmt/2019-10-27-preview/containerservice of tag package-2019-10-27-preview must not be under a preview subdirectory for a stable swagger set. Please refer the sample for readme.go.md file here https://github.com/Azure/azure-rest-api-specs/blob/master/documentation/samplefiles/readme.go.md for more information
       at AutoRest.Go.CodeGeneratorGo.PreviewCheck(String folder) in /home/vsts/work/1/s/src/CodeGeneratorGo.cs:line 187
       at AutoRest.Go.CodeGeneratorGo.d__7.MoveNext() in /home/vsts/work/1/s/src/CodeGeneratorGo.cs:line 60
    --- End of stack trace from previous location where exception was thrown ---
       at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
       at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
       at AutoRest.Go.Program.d__3.MoveNext() in /home/vsts/work/1/s/src/Program.cs:line 107
    --- End of stack trace from previous location where exception was thrown ---
       at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
       at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
       at System.Runtime.CompilerServices.TaskAwaiter`1.GetResult()
       at NewPlugin.d__20.MoveNext() in /home/vsts/work/1/s/autorest.common/src/Plugins/NewPlugin.cs:line 163
    FATAL: go/generate - FAILED
    FATAL: Error: Plugin go reported failure.
    Failure during batch task - {"tag":"package-2019-10-27-preview"} -- Error: Plugin go reported failure..
      Error: Plugin go reported failure.
    , {} 
    Failed to find any diff after autorest so no changed packages was found.

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Sep 22, 2020

azure-sdk-for-net - Release

️✔️ succeeded [Logs] [Expand Details]
  • ️✔️ Generate from b035666 with merge commit 30832c2. SDK Automation 13.0.17.20200918.2
    [AutoRest] realpath(): Permission denied
    [AutoRest] realpath(): Permission denied
    [AutoRest] realpath(): Permission denied
    [AutoRest] realpath(): Permission denied
    [AutoRest] realpath(): Permission denied
    [AutoRest] realpath(): Permission denied
  • ️✔️Microsoft.Azure.Management.ContainerService [View full logs]  [Release SDK Changes]
    Unable to get details about the head commit. This is probably because the head commit is in a fork that we don't have permission to read from. HttpError: Not Found {"name":"HttpError","status":404,"headers":{"access-control-allow-origin":"*","access-control-expose-headers":"ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Used, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type, Deprecation, Sunset","connection":"close","content-encoding":"gzip","content-security-policy":"default-src 'none'","content-type":"application/json; charset=utf-8","date":"Thu, 24 Sep 2020 09:25:23 GMT","referrer-policy":"origin-when-cross-origin, strict-origin-when-cross-origin","server":"GitHub.com","status":"404 Not Found","strict-transport-security":"max-age=31536000; includeSubdomains; preload","transfer-encoding":"chunked","vary":"Accept-Encoding, Accept, X-Requested-With","x-content-type-options":"nosniff","x-frame-options":"deny","x-github-media-type":"github.v3; param=machine-man-preview; format=json","x-github-request-id":"0702:2B82:83024B:1412E7E:5F6C6603","x-xss-protection":"1; mode=block"},"request":{"method":"POST","url":"https://api.github.com/app/installations//access_tokens","headers":{"accept":"application/vnd.github.machine-man-preview+json","user-agent":"octokit.js/16.43.1 Node.js/13.14.0 (Linux 5.4; x64)","authorization":"bearer [REDACTED]","content-type":"application/json; charset=utf-8"},"body":"{}","request":{"validate":{"commit_sha":{"alias":"ref","deprecated":true,"type":"string"},"owner":{"required":true,"type":"string"},"ref":{"required":true,"type":"string"},"repo":{"required":true,"type":"string"},"sha":{"alias":"ref","deprecated":true,"type":"string"}}}},"documentation_url":"https://docs.github.com/rest"}

This was referenced Sep 22, 2020
@PhoenixHe-NV
Copy link
Contributor

@gtxistxgao Is there any SDK related to these API versions?

@marwanad
Copy link
Contributor

There are published Go and python SDKs for that.

I think this should classify as a bug fix and not a breaking change.

@changlong-liu
Copy link
Member

Hi @gtxistxgao Python SDK have been released as stable:https://pypi.org/project/azure-mgmt-containerservice/9.4.0/

This PR will bring breaking change in SDK, I don't think we can do this unnecessary change in a released stable SDK.

@gtxistxgao
Copy link
Contributor Author

Hi @gtxistxgao Python SDK have been released as stable:https://pypi.org/project/azure-mgmt-containerservice/9.4.0/

This PR will bring breaking change in SDK, I don't think we can do this unnecessary change in a released stable SDK.

This is not an unnecessary change. The operation stays in a different operation client in python API. It will bring potential risk to customer's implementation when they upgrade to a later version SDK when we corrected this bug. The node image upgrade is still a preview feature at this point. We can generated a 9.4.1 version as bug fix.

@gtxistxgao gtxistxgao changed the title [AKS] hotfix: upgradeNodeImageVersion should be an agent pools operation [AKS] Bugfix: upgradeNodeImageVersion should be an agent pools operation Sep 22, 2020
@gtxistxgao gtxistxgao changed the title [AKS] Bugfix: upgradeNodeImageVersion should be an agent pools operation [AKS] Swagger Bugfix: upgradeNodeImageVersion should be an agent pools operation Sep 22, 2020
@marwanad
Copy link
Contributor

@NullMDR can you help take a look and merge the PR?

@changlong-liu
Copy link
Member

his point. We

Hi @gtxistxgao , @marwanad ,
I don't deny to merge this PR if service side think it's necessary. But the coming Python SDK should be 10.0.0 for below reasons:

  1. It will break customer code.
  2. it's already in a stable api-version/SDK version.

@PhoenixHe-NV PhoenixHe-NV added the Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 label Sep 24, 2020
@PhoenixHe-NV
Copy link
Contributor

Discussed offline. Python SDK will bump major version

@PhoenixHe-NV PhoenixHe-NV merged commit 30832c2 into Azure:master Sep 24, 2020
@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Sep 24, 2020

azure-resource-manager-schemas - Release

️✔️ succeeded [Logs] [Expand Details]
  • ️✔️ Generate from b035666 with merge commit 30832c2. Schema Automation 13.0.17.20200918.2
    [containerservice][after_scripts|node] configure: WARNING: secure clearing/zeroing of memory is not supported by the selected crypto backend
    [containerservice][after_scripts|node] configure: WARNING: secure clearing/zeroing of memory is not supported by the selected crypto backend
    [containerservice][after_scripts|node] configure: WARNING: secure clearing/zeroing of memory is not supported by the selected crypto backend
  • ️✔️containerservice [View full logs]  [Release Schema Changes]
      [after_scripts|node] PostProcessor finished successfully.
      [after_scripts|node]   5731 passing (1m)
      AzureResourceSchema has no registered package commands.
      Unable to get details about the head commit. This is probably because the head commit is in a fork that we don't have permission to read from. HttpError: Not Found {"name":"HttpError","status":404,"headers":{"access-control-allow-origin":"*","access-control-expose-headers":"ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Used, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type, Deprecation, Sunset","connection":"close","content-encoding":"gzip","content-security-policy":"default-src 'none'","content-type":"application/json; charset=utf-8","date":"Thu, 24 Sep 2020 09:26:49 GMT","referrer-policy":"origin-when-cross-origin, strict-origin-when-cross-origin","server":"GitHub.com","status":"404 Not Found","strict-transport-security":"max-age=31536000; includeSubdomains; preload","transfer-encoding":"chunked","vary":"Accept-Encoding, Accept, X-Requested-With","x-content-type-options":"nosniff","x-frame-options":"deny","x-github-media-type":"github.v3; param=machine-man-preview; format=json","x-github-request-id":"0400:2076:34B99C9:7CB6C68:5F6C6659","x-xss-protection":"1; mode=block"},"request":{"method":"POST","url":"https://api.github.com/app/installations//access_tokens","headers":{"accept":"application/vnd.github.machine-man-preview+json","user-agent":"octokit.js/16.43.1 Node.js/13.14.0 (Linux 5.4; x64)","authorization":"bearer [REDACTED]","content-type":"application/json; charset=utf-8"},"body":"{}","request":{"validate":{"commit_sha":{"alias":"ref","deprecated":true,"type":"string"},"owner":{"required":true,"type":"string"},"ref":{"required":true,"type":"string"},"repo":{"required":true,"type":"string"},"sha":{"alias":"ref","deprecated":true,"type":"string"}}}},"documentation_url":"https://docs.github.com/rest"}

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Sep 24, 2020

    azure-sdk-for-python-track2 - Release

    No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

    nitegupt pushed a commit to nitegupt/azure-rest-api-specs that referenced this pull request Sep 25, 2020
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 CI-BreakingChange-Python
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    4 participants