-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AKS] Swagger Bugfix: upgradeNodeImageVersion should be an agent pools operation #10879
Conversation
[Staging] Swagger Validation Report
❌ |
Rule | Message |
---|---|
1008 - ModifiedOperationId |
The operation id has been changed from 'ManagedClusters_UpgradeNodeImageVersion' to 'AgentPools_UpgradeNodeImageVersion'. This will impact generated code. New: Microsoft.ContainerService/stable/2020-07-01/managedClusters.json#L1231:7 Old: Microsoft.ContainerService/stable/2020-07-01/managedClusters.json#L1231:7 |
1008 - ModifiedOperationId |
The operation id has been changed from 'ManagedClusters_UpgradeNodeImageVersion' to 'AgentPools_UpgradeNodeImageVersion'. This will impact generated code. New: Microsoft.ContainerService/stable/2020-09-01/managedClusters.json#L1322:7 Old: Microsoft.ContainerService/stable/2020-09-01/managedClusters.json#L1322:7 |
️️✔️
LintDiff [Detail]
️✔️
Validation passes for LintDiff.
️️✔️
Avocado [Detail]
️✔️
Validation passes for Avocado.
️️✔️
ModelValidation [Detail]
️✔️
Validation passes for ModelValidation.
️️✔️
SemanticValidation [Detail]
️✔️
Validation passes for SemanticValidation.
Azure Pipelines successfully started running 1 pipeline(s). |
azure-sdk-for-js - Release
|
azure-sdk-for-java - Release
|
Trenton Generation - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
Azure CLI Extension Generation - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-sdk-for-python - Release
- Breaking Change detected in SDK
|
azure-sdk-for-go - Release
|
azure-sdk-for-net - Release
|
@gtxistxgao Is there any SDK related to these API versions? |
There are published Go and python SDKs for that. I think this should classify as a bug fix and not a breaking change. |
Hi @gtxistxgao Python SDK have been released as stable:https://pypi.org/project/azure-mgmt-containerservice/9.4.0/ This PR will bring breaking change in SDK, I don't think we can do this unnecessary change in a released stable SDK. |
This is not an unnecessary change. The operation stays in a different operation client in python API. It will bring potential risk to customer's implementation when they upgrade to a later version SDK when we corrected this bug. The node image upgrade is still a preview feature at this point. We can generated a 9.4.1 version as bug fix. |
@NullMDR can you help take a look and merge the PR? |
Hi @gtxistxgao , @marwanad ,
|
Discussed offline. Python SDK will bump major version |
azure-resource-manager-schemas - Release
|
azure-sdk-for-python-track2 - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Contribution checklist:
"Upgrade Node Image Version" API is under "Managed Clusters" tab, which is wrong as it is an agent pool only operation. So it should be in "Agent Pools" tag. The python SDK also put it under "ManagedClustersOperations".
I made a mistake in the swagger PR that put a "ManagedClusters" before it. #10294
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.
Please follow the link to find more details on PR review process.