API Spec change for DNC RP #10819

tamilmani1989 · 2020-09-16T22:23:23Z

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

I commit to follow the Breaking Change Policy of “no breaking changes
I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
- Adding new API(s)
- Adding a new API version
- Adding a new service
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.

Removing API(s) in stable version
Removing properties in stable version
Removing API version(s) in stable version
Updating API in stable version with Breaking Change Validation errors
Updating API(s) in preview over 1 year

Please follow the link to find more details on PR review process.

openapi-pipeline-app · 2020-09-16T22:23:28Z

[Staging] Swagger Validation Report

️️✔️BreakingChange [Detail]

 There are no breaking changes.

️️✔️LintDiff [Detail]

 Validation passes for LintDiff.

️️✔️Avocado [Detail]

 Validation passes for Avocado.

️️✔️ModelValidation [Detail]

 Validation passes for ModelValidation.

️️✔️SemanticValidation [Detail]

 Validation passes for SemanticValidation.

_{Posted by Swagger Pipeline | How to fix these errors?}

azure-pipelines · 2020-09-16T22:23:41Z

Azure Pipelines successfully started running 1 pipeline(s).

openapi-sdkautomation · 2020-09-16T22:26:34Z

Azure CLI Extension Generation - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

openapi-sdkautomation · 2020-09-16T22:26:44Z

azure-sdk-for-go - Release

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from 6ce95fa with merge commit 25e3eaa. SDK Automation 13.0.17.20200918.2

️✔️preview/delegatednetwork/mgmt/2020-08-08-preview [View full logs] [Release SDK Changes]

preview.delegatednetwork.mgmt.2020-08-08-preview.zip

Unable to get details about the head commit. This is probably because the head commit is in a fork that we don't have permission to read from. HttpError: Not Found {"name":"HttpError","status":404,"headers":{"access-control-allow-origin":"*","access-control-expose-headers":"ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Used, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type, Deprecation, Sunset","connection":"close","content-encoding":"gzip","content-security-policy":"default-src 'none'","content-type":"application/json; charset=utf-8","date":"Sun, 27 Sep 2020 02:26:25 GMT","referrer-policy":"origin-when-cross-origin, strict-origin-when-cross-origin","server":"GitHub.com","status":"404 Not Found","strict-transport-security":"max-age=31536000; includeSubdomains; preload","transfer-encoding":"chunked","vary":"Accept-Encoding, Accept, X-Requested-With","x-content-type-options":"nosniff","x-frame-options":"deny","x-github-media-type":"github.v3; param=machine-man-preview; format=json","x-github-request-id":"0782:07F7:E27C1D:17A1F40:5F6FF851","x-xss-protection":"1; mode=block"},"request":{"method":"POST","url":"https://api.github.com/app/installations//access_tokens","headers":{"accept":"application/vnd.github.machine-man-preview+json","user-agent":"octokit.js/16.43.1 Node.js/13.14.0 (Linux 5.4; x64)","authorization":"bearer [REDACTED]","content-type":"application/json; charset=utf-8"},"body":"{}","request":{"validate":{"commit_sha":{"alias":"ref","deprecated":true,"type":"string"},"owner":{"required":true,"type":"string"},"ref":{"required":true,"type":"string"},"repo":{"required":true,"type":"string"},"sha":{"alias":"ref","deprecated":true,"type":"string"}}}},"documentation_url":"https://docs.github.com/rest"}

openapi-sdkautomation · 2020-09-16T22:26:48Z

azure-sdk-for-java - Release

⚠️ warning [Logs] [Expand Details]

⚠️ Generate from 6ce95fa with merge commit 25e3eaa. SDK Automation 13.0.17.20200918.2

⚠️sdk/DelegatedNetwork/mgmt-2020-08-08-preview [View full logs] [Release SDK Changes]

[mvn] [ERROR] Failed to execute goal org.apache.maven.plugins:maven-javadoc-plugin:2.8:jar (default-cli) on project azure-mgmt-delegatednetwork: MavenReportException: Error while creating archive: 
[mvn] [ERROR] Exit code: 1 - javadoc: error - Illegal package name: "com.microsoft.azure.management.delegatednetwork.2020-08-08-preview"
[mvn] [ERROR] 
[mvn] [ERROR] Command line was: /usr/lib/jvm/java-8-openjdk-amd64/jre/../bin/javadoc @options @packages
[mvn] [ERROR] 
[mvn] [ERROR] Refer to the generated Javadoc files in '/z/work/azure-sdk-for-java/sdk/DelegatedNetwork/mgmt-2020-08-08-preview/target/apidocs' dir.
[mvn] [ERROR] -> [Help 1]
[mvn] [ERROR] 
[mvn] [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[mvn] [ERROR] Re-run Maven using the -X switch to enable full debug logging.
[mvn] [ERROR] 
[mvn] [ERROR] For more information about the errors and possible solutions, please read the following articles:
[mvn] [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException
Unable to get details about the head commit. This is probably because the head commit is in a fork that we don't have permission to read from. HttpError: Not Found {"name":"HttpError","status":404,"headers":{"access-control-allow-origin":"*","access-control-expose-headers":"ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Used, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type, Deprecation, Sunset","connection":"close","content-encoding":"gzip","content-security-policy":"default-src 'none'","content-type":"application/json; charset=utf-8","date":"Sun, 27 Sep 2020 02:26:23 GMT","referrer-policy":"origin-when-cross-origin, strict-origin-when-cross-origin","server":"GitHub.com","status":"404 Not Found","strict-transport-security":"max-age=31536000; includeSubdomains; preload","transfer-encoding":"chunked","vary":"Accept-Encoding, Accept, X-Requested-With","x-content-type-options":"nosniff","x-frame-options":"deny","x-github-media-type":"github.v3; param=machine-man-preview; format=json","x-github-request-id":"0782:3D37:8C3AC:156152:5F6FF84F","x-xss-protection":"1; mode=block"},"request":{"method":"POST","url":"https://api.github.com/app/installations//access_tokens","headers":{"accept":"application/vnd.github.machine-man-preview+json","user-agent":"octokit.js/16.43.1 Node.js/13.14.0 (Linux 5.4; x64)","authorization":"bearer [REDACTED]","content-type":"application/json; charset=utf-8"},"body":"{}","request":{"validate":{"commit_sha":{"alias":"ref","deprecated":true,"type":"string"},"owner":{"required":true,"type":"string"},"ref":{"required":true,"type":"string"},"repo":{"required":true,"type":"string"},"sha":{"alias":"ref","deprecated":true,"type":"string"}}}},"documentation_url":"https://docs.github.com/rest"}

openapi-sdkautomation · 2020-09-16T22:26:57Z

azure-sdk-for-js - Release

⚠️ warning [Logs] [Expand Details]

⚠️ Generate from 6ce95fa with merge commit 25e3eaa. SDK Automation 13.0.17.20200918.2
```
Failed to find any diff after autorest so no changed packages was found.
```

openapi-sdkautomation · 2020-09-16T22:27:03Z

azure-sdk-for-net - Release

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from 6ce95fa with merge commit 25e3eaa. SDK Automation 13.0.17.20200918.2

[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied

️✔️Microsoft.Azure.Management.DelegatedNetwork [View full logs] [Release SDK Changes]

Unable to get details about the head commit. This is probably because the head commit is in a fork that we don't have permission to read from. HttpError: Not Found {"name":"HttpError","status":404,"headers":{"access-control-allow-origin":"*","access-control-expose-headers":"ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Used, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type, Deprecation, Sunset","connection":"close","content-encoding":"gzip","content-security-policy":"default-src 'none'","content-type":"application/json; charset=utf-8","date":"Sun, 27 Sep 2020 02:25:16 GMT","referrer-policy":"origin-when-cross-origin, strict-origin-when-cross-origin","server":"GitHub.com","status":"404 Not Found","strict-transport-security":"max-age=31536000; includeSubdomains; preload","transfer-encoding":"chunked","vary":"Accept-Encoding, Accept, X-Requested-With","x-content-type-options":"nosniff","x-frame-options":"deny","x-github-media-type":"github.v3; param=machine-man-preview; format=json","x-github-request-id":"0781:1A2B:2F5F4B:8DE541:5F6FF80C","x-xss-protection":"1; mode=block"},"request":{"method":"POST","url":"https://api.github.com/app/installations//access_tokens","headers":{"accept":"application/vnd.github.machine-man-preview+json","user-agent":"octokit.js/16.43.1 Node.js/13.14.0 (Linux 5.4; x64)","authorization":"bearer [REDACTED]","content-type":"application/json; charset=utf-8"},"body":"{}","request":{"validate":{"commit_sha":{"alias":"ref","deprecated":true,"type":"string"},"owner":{"required":true,"type":"string"},"ref":{"required":true,"type":"string"},"repo":{"required":true,"type":"string"},"sha":{"alias":"ref","deprecated":true,"type":"string"}}}},"documentation_url":"https://docs.github.com/rest"}

openapi-sdkautomation · 2020-09-16T22:27:05Z

azure-sdk-for-python - Release

⚠️ warning [Logs] [Expand Details]

⚠️ Generate from 6ce95fa with merge commit 25e3eaa. SDK Automation 13.0.17.20200918.2
```
Failed to find any diff after autorest so no changed packages was found.
```

openapi-sdkautomation · 2020-09-16T22:27:07Z

azure-sdk-for-python-track2 - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

openapi-sdkautomation · 2020-09-16T22:27:13Z

azure-resource-manager-schemas - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

openapi-sdkautomation · 2020-09-16T22:27:18Z

Trenton Generation - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

azure-pipelines · 2020-09-18T19:37:48Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2020-09-18T19:46:32Z

Azure Pipelines successfully started running 1 pipeline(s).

lirenhe · 2020-09-21T06:11:12Z

@tamilmani1989 , it looks the referenced file specification/dnc/resource-manager/Microsoft.DelegatedNetwork/preview/2020-08-08-preview/examples/delegatedNetworkControllerListByRG.json does not exist that caused a couple of tool check errors.

azure-pipelines · 2020-09-21T23:42:54Z

Azure Pipelines successfully started running 1 pipeline(s).

tamilmani1989 · 2020-09-22T05:19:09Z

@lirenhe fixed and everything passed..can you please approve?

Could you also resolve the conflict? And could you also highlight the change in your PR?

@lirenhe
resolved the conflict

Main changes:

added new resource orchestratorInstaces
changed delegatedSubnets from extension resource to tracked resource
added few fields in apischema

...resource-manager/Microsoft.DelegatedNetwork/preview/2020-08-08-preview/delegatedSubnets.json

...rce-manager/Microsoft.DelegatedNetwork/preview/2020-08-08-preview/orchestratorInstances.json

azure-pipelines · 2020-09-22T22:49:15Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2020-09-25T21:09:32Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2020-09-25T21:13:43Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2020-09-25T21:17:52Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2020-09-25T21:28:51Z

Azure Pipelines successfully started running 1 pipeline(s).

...n/dnc/resource-manager/Microsoft.DelegatedNetwork/preview/2020-08-08-preview/controller.json

pilor · 2020-09-25T22:45:31Z

...n/dnc/resource-manager/Microsoft.DelegatedNetwork/preview/2020-08-08-preview/controller.json

+    }
+  },
+  "paths": {
+    "/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.DelegatedNetwork/controller/{resourceName}": {


the resource type name needs to be plural ("controllers")

can't update this..since updated nrp code with same name and its in production and also some resources created with this type

...n/dnc/resource-manager/Microsoft.DelegatedNetwork/preview/2020-08-08-preview/controller.json

pilor · 2020-09-25T22:47:28Z

...n/dnc/resource-manager/Microsoft.DelegatedNetwork/preview/2020-08-08-preview/controller.json

+          "readOnly": true,
+          "description": "The current state of dnc controller resource."
+        },
+        "controllerProperties": {


What is the first party app ID being used for? This was supposed to transition to using managed identity

this is for customers to connect to our controller. our controller has to authenticate users connecting to our cluster. this won;t be used as client aad to connect to customer cluster. for that msi defined in orchestrators resource will be used..

@chandanAggarwal

...nc/resource-manager/Microsoft.DelegatedNetwork/preview/2020-08-08-preview/orchestrators.json

pilor · 2020-09-25T22:54:18Z

...nc/resource-manager/Microsoft.DelegatedNetwork/preview/2020-08-08-preview/orchestrators.json

+          "description": "K8s APIServer url",
+          "type": "string"
+        },
+        "controllerDetails": {


If the managed identity is associated with the orchestrator what is the dncAppId exposed in the controller still used for? Can it be removed from that resource?

explained above

...nc/resource-manager/Microsoft.DelegatedNetwork/preview/2020-08-08-preview/orchestrators.json

...resource-manager/Microsoft.DelegatedNetwork/preview/2020-08-08-preview/delegatedSubnets.json

azure-pipelines · 2020-09-25T23:24:58Z

Azure Pipelines successfully started running 1 pipeline(s).

...n/dnc/resource-manager/Microsoft.DelegatedNetwork/preview/2020-08-08-preview/controller.json

azure-pipelines · 2020-09-25T23:32:11Z

Azure Pipelines successfully started running 1 pipeline(s).

tamilmani1989 added 7 commits September 7, 2020 11:45

updated apispec

7dba823

spell error fix

cc1464c

removed dncappid from response

115a16e

updated apispec

4d61d27

Added appid and endpoint in response

7ce45f1

Merge branch 'master' of https://github.com/Azure/azure-rest-api-specs

7303d92

adde controller id in delegated subnet response

cc447bd

openapi-assignment-bot bot assigned lirenhe Sep 16, 2020

This was referenced Sep 16, 2020

[AutoPR sdk/DelegatedNetwork/mgmt-2020-08-08-preview] API Spec change for DNC RP AzureSDKAutomation/azure-sdk-for-java#4062

Closed

[AutoPR Microsoft.Azure.Management.DelegatedNetwork] API Spec change for DNC RP AzureSDKAutomation/azure-sdk-for-net#1729

Closed

updated examples

3bdd51e

updated

a9c6b46

lirenhe added the Reviewed-ChangesRequested <valid label in PR review process>add this label when assignee request changes after review label Sep 21, 2020

updated apispec

29c9fe0

spell check and prettier fix

a05b198

openapi-assignment-bot bot added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Sep 22, 2020

tamilmani1989 removed the Reviewed-ChangesRequested <valid label in PR review process>add this label when assignee request changes after review label Sep 22, 2020

pilor self-requested a review September 22, 2020 20:04

pilor added the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label Sep 22, 2020

pilor suggested changes Sep 22, 2020

View reviewed changes

addressed review comments

2031476

addressed feedback comments

689250e

spell check fix

e00bbb6

updated readme.md

b9e9112

updated definition name

0f81279

pilor suggested changes Sep 25, 2020

View reviewed changes

addressed feedback comments

f8eb777

pilor suggested changes Sep 25, 2020

View reviewed changes

...n/dnc/resource-manager/Microsoft.DelegatedNetwork/preview/2020-08-08-preview/controller.json Show resolved Hide resolved

fixed lint issue

6ce95fa

pilor approved these changes Sep 25, 2020

View reviewed changes

lirenhe approved these changes Sep 27, 2020

View reviewed changes

lirenhe merged commit 25e3eaa into Azure:master Sep 27, 2020

ctaggart mentioned this pull request Nov 8, 2020

reuse ControllerDetails definition in dnc 2020-08-08-preview #11578

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

API Spec change for DNC RP #10819

API Spec change for DNC RP #10819

tamilmani1989 commented Sep 16, 2020 •

edited by lirenhe

Loading

openapi-pipeline-app bot commented Sep 16, 2020 •

edited

Loading

azure-pipelines bot commented Sep 16, 2020

openapi-sdkautomation bot commented Sep 16, 2020 •

edited

Loading

openapi-sdkautomation bot commented Sep 16, 2020 •

edited

Loading

openapi-sdkautomation bot commented Sep 16, 2020 •

edited

Loading

openapi-sdkautomation bot commented Sep 16, 2020 •

edited

Loading

openapi-sdkautomation bot commented Sep 16, 2020 •

edited

Loading

openapi-sdkautomation bot commented Sep 16, 2020 •

edited

Loading

openapi-sdkautomation bot commented Sep 16, 2020 •

edited

Loading

openapi-sdkautomation bot commented Sep 16, 2020 •

edited

Loading

openapi-sdkautomation bot commented Sep 16, 2020 •

edited

Loading

azure-pipelines bot commented Sep 18, 2020

azure-pipelines bot commented Sep 18, 2020

lirenhe commented Sep 21, 2020

azure-pipelines bot commented Sep 21, 2020

tamilmani1989 commented Sep 22, 2020 •

edited

Loading

azure-pipelines bot commented Sep 22, 2020

azure-pipelines bot commented Sep 25, 2020

azure-pipelines bot commented Sep 25, 2020

azure-pipelines bot commented Sep 25, 2020

azure-pipelines bot commented Sep 25, 2020

pilor Sep 25, 2020

tamilmani1989 Sep 25, 2020

pilor Sep 25, 2020

tamilmani1989 Sep 25, 2020

pilor Sep 25, 2020

tamilmani1989 Sep 25, 2020

azure-pipelines bot commented Sep 25, 2020

azure-pipelines bot commented Sep 25, 2020

API Spec change for DNC RP #10819

API Spec change for DNC RP #10819

Conversation

tamilmani1989 commented Sep 16, 2020 • edited by lirenhe Loading

Contribution checklist:

ARM API Review Checklist

Breaking Change Review Checklist

openapi-pipeline-app bot commented Sep 16, 2020 • edited Loading

[Staging] Swagger Validation Report

azure-pipelines bot commented Sep 16, 2020

openapi-sdkautomation bot commented Sep 16, 2020 • edited Loading

Azure CLI Extension Generation - Release

openapi-sdkautomation bot commented Sep 16, 2020 • edited Loading

azure-sdk-for-go - Release

openapi-sdkautomation bot commented Sep 16, 2020 • edited Loading

azure-sdk-for-java - Release

openapi-sdkautomation bot commented Sep 16, 2020 • edited Loading

azure-sdk-for-js - Release

openapi-sdkautomation bot commented Sep 16, 2020 • edited Loading

azure-sdk-for-net - Release

openapi-sdkautomation bot commented Sep 16, 2020 • edited Loading

azure-sdk-for-python - Release

openapi-sdkautomation bot commented Sep 16, 2020 • edited Loading

azure-sdk-for-python-track2 - Release

openapi-sdkautomation bot commented Sep 16, 2020 • edited Loading

azure-resource-manager-schemas - Release

openapi-sdkautomation bot commented Sep 16, 2020 • edited Loading

Trenton Generation - Release

azure-pipelines bot commented Sep 18, 2020

azure-pipelines bot commented Sep 18, 2020

lirenhe commented Sep 21, 2020

azure-pipelines bot commented Sep 21, 2020

tamilmani1989 commented Sep 22, 2020 • edited Loading

azure-pipelines bot commented Sep 22, 2020

azure-pipelines bot commented Sep 25, 2020

azure-pipelines bot commented Sep 25, 2020

azure-pipelines bot commented Sep 25, 2020

azure-pipelines bot commented Sep 25, 2020

pilor Sep 25, 2020

Choose a reason for hiding this comment

tamilmani1989 Sep 25, 2020

Choose a reason for hiding this comment

pilor Sep 25, 2020

Choose a reason for hiding this comment

tamilmani1989 Sep 25, 2020

Choose a reason for hiding this comment

pilor Sep 25, 2020

Choose a reason for hiding this comment

tamilmani1989 Sep 25, 2020

Choose a reason for hiding this comment

azure-pipelines bot commented Sep 25, 2020

azure-pipelines bot commented Sep 25, 2020

tamilmani1989 commented Sep 16, 2020 •

edited by lirenhe

Loading

openapi-pipeline-app bot commented Sep 16, 2020 •

edited

Loading

openapi-sdkautomation bot commented Sep 16, 2020 •

edited

Loading

openapi-sdkautomation bot commented Sep 16, 2020 •

edited

Loading

openapi-sdkautomation bot commented Sep 16, 2020 •

edited

Loading

openapi-sdkautomation bot commented Sep 16, 2020 •

edited

Loading

openapi-sdkautomation bot commented Sep 16, 2020 •

edited

Loading

openapi-sdkautomation bot commented Sep 16, 2020 •

edited

Loading

openapi-sdkautomation bot commented Sep 16, 2020 •

edited

Loading

openapi-sdkautomation bot commented Sep 16, 2020 •

edited

Loading

openapi-sdkautomation bot commented Sep 16, 2020 •

edited

Loading

tamilmani1989 commented Sep 22, 2020 •

edited

Loading