-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Synapse] Support long running operation for Integration Runtime #10353
Conversation
[Staging] Swagger Validation Report
❌ |
Rule | Message |
---|---|
1011 - AddingResponseCode |
The new version adds a response code '202'. New: Microsoft.Synapse/preview/2019-06-01-preview/integrationRuntime.json#L195:11 |
1011 - AddingResponseCode |
The new version adds a response code '202'. New: Microsoft.Synapse/preview/2019-06-01-preview/integrationRuntime.json#L247:11 |
️️✔️
LintDiff [Detail]
️✔️
Validation passes for LintDiff.
️️✔️
Avocado [Detail]
️✔️
Validation passes for Avocado.
Azure Pipelines successfully started running 1 pipeline(s). |
azure-sdk-for-go - Release
|
azure-sdk-for-java - Release
|
Azure CLI Extension Generation - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-sdk-for-net - Release
|
azure-sdk-for-js - Release
|
azure-sdk-for-python - Release
|
azure-sdk-for-python-track2 - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
Trenton Generation - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
@wonner , it's breaking change to add new response code. Does it target the end of year for GA? |
Hi @raych1, thanks for your quick response. Currently we don't have an accurate time for SDK GA. Does it matter? The reason to add this status code is because according to our experiments, the original Swagger spec is incorrect - the RP returns 202 in fact. |
Can one of the admins verify this patch? |
So, this change is to align the swagger with the service implementation, right? |
Right. And we find that the generated SDK code cannot handle long running operation well. That's why we add "x-ms-long-running-operation" extension. |
Co-authored-by: Wan Yang <[email protected]>
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.
Please follow the link to find more details on PR review process.