Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Synapse] Support long running operation for Integration Runtime #10353

Merged
merged 1 commit into from
Aug 7, 2020

Conversation

wonner
Copy link
Contributor

@wonner wonner commented Aug 6, 2020

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

  • Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.

    • Adding new API(s)
    • Adding a new API version
    • Adding a new service
  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in stable version
  • Removing properties in stable version
  • Removing API version(s) in stable version
  • Updating API in stable version with Breaking Change Validation errors
  • Updating API(s) in preview over 1 year

Please follow the link to find more details on PR review process.

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Aug 6, 2020

[Staging] Swagger Validation Report

BreakingChange: 2 Errors, 0 Warnings [Detail] [Expand]
Rule Message
1011 - AddingResponseCode The new version adds a response code '202'.
New: Microsoft.Synapse/preview/2019-06-01-preview/integrationRuntime.json#L195:11
1011 - AddingResponseCode The new version adds a response code '202'.
New: Microsoft.Synapse/preview/2019-06-01-preview/integrationRuntime.json#L247:11
️✔️LintDiff [Detail]
 Validation passes for LintDiff. 
️✔️Avocado [Detail]
 Validation passes for Avocado. 
Posted by Swagger Pipeline | How to fix these errors?

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Aug 6, 2020

azure-sdk-for-go - Release

️✔️ succeeded [Logs] [Expand Details]

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Aug 6, 2020

azure-sdk-for-java - Release

⚠️ warning [Logs] [Expand Details]
  • ⚠️ Generate from 96c0e47 with merge commit c714e3e. SDK Automation 13.0.17.20200807.2
  • ⚠️sdk/synapse/mgmt-v2019_06_01_preview [View full logs]  [Release SDK Changes]
      [mvn] [ERROR] COMPILATION ERROR : 
      [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/synapse/mgmt-v2019_06_01_preview/src/main/java/com/microsoft/azure/management/synapse/v2019_06_01_preview/implementation/BigDataPoolsInner.java:[17,66] cannot find symbol
      [mvn]   symbol:   class ErrorContractInnerException
      [mvn]   location: package com.microsoft.azure.management.synapse.v2019_06_01_preview
      [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/synapse/mgmt-v2019_06_01_preview/src/main/java/com/microsoft/azure/management/synapse/v2019_06_01_preview/implementation/OperationsInner.java:[15,66] cannot find symbol
      [mvn]   symbol:   class ErrorContractInnerException
      [mvn]   location: package com.microsoft.azure.management.synapse.v2019_06_01_preview
      [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/synapse/mgmt-v2019_06_01_preview/src/main/java/com/microsoft/azure/management/synapse/v2019_06_01_preview/implementation/IpFirewallRulesInner.java:[16,66] cannot find symbol
      [mvn]   symbol:   class ErrorContractInnerException
      [mvn]   location: package com.microsoft.azure.management.synapse.v2019_06_01_preview
      [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/synapse/mgmt-v2019_06_01_preview/src/main/java/com/microsoft/azure/management/synapse/v2019_06_01_preview/implementation/SqlPoolsInner.java:[16,66] cannot find symbol
      [mvn]   symbol:   class ErrorContractInnerException
      [mvn]   location: package com.microsoft.azure.management.synapse.v2019_06_01_preview
      [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/synapse/mgmt-v2019_06_01_preview/src/main/java/com/microsoft/azure/management/synapse/v2019_06_01_preview/implementation/SqlPoolMetadataSyncConfigsInner.java:[13,66] cannot find symbol
      [mvn]   symbol:   class ErrorContractInnerException
      [mvn]   location: package com.microsoft.azure.management.synapse.v2019_06_01_preview
      [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/synapse/mgmt-v2019_06_01_preview/src/main/java/com/microsoft/azure/management/synapse/v2019_06_01_preview/implementation/WorkspacesInner.java:[19,66] cannot find symbol
      [mvn]   symbol:   class ErrorContractInnerException
      [mvn]   location: package com.microsoft.azure.management.synapse.v2019_06_01_preview
      [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/synapse/mgmt-v2019_06_01_preview/src/main/java/com/microsoft/azure/management/synapse/v2019_06_01_preview/implementation/WorkspaceAadAdminsInner.java:[15,66] cannot find symbol
      [mvn]   symbol:   class ErrorContractInnerException
      [mvn]   location: package com.microsoft.azure.management.synapse.v2019_06_01_preview
      [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/synapse/mgmt-v2019_06_01_preview/src/main/java/com/microsoft/azure/management/synapse/v2019_06_01_preview/implementation/WorkspaceManagedIdentitySqlControlSettingsInner.java:[13,66] cannot find symbol
      [mvn]   symbol:   class ErrorContractInnerException
      [mvn]   location: package com.microsoft.azure.management.synapse.v2019_06_01_preview
      [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/synapse/mgmt-v2019_06_01_preview/src/main/java/com/microsoft/azure/management/synapse/v2019_06_01_preview/implementation/PrivateEndpointConnectionsInner.java:[15,66] cannot find symbol
      [mvn]   symbol:   class ErrorContractInnerException
      [mvn]   location: package com.microsoft.azure.management.synapse.v2019_06_01_preview
      [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/synapse/mgmt-v2019_06_01_preview/src/main/java/com/microsoft/azure/management/synapse/v2019_06_01_preview/implementation/PrivateLinkHubsInner.java:[19,66] cannot find symbol
      [mvn]   symbol:   class ErrorContractInnerException
      [mvn]   location: package com.microsoft.azure.management.synapse.v2019_06_01_preview
      [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/synapse/mgmt-v2019_06_01_preview/src/main/java/com/microsoft/azure/management/synapse/v2019_06_01_preview/implementation/SqlPoolVulnerabilityAssessmentRuleBaselinesImpl.java:[42,119] cannot find symbol
      [mvn]   symbol:   class VulnerabilityAssessmentPolicyBaselineName
      [mvn]   location: class com.microsoft.azure.management.synapse.v2019_06_01_preview.implementation.SqlPoolVulnerabilityAssessmentRuleBaselinesImpl
      [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/synapse/mgmt-v2019_06_01_preview/src/main/java/com/microsoft/azure/management/synapse/v2019_06_01_preview/implementation/IntegrationRuntimeInner.java:[24,50] cannot find symbol
      [mvn]   symbol: class ManagedIntegrationRuntime
      [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/synapse/mgmt-v2019_06_01_preview/src/main/java/com/microsoft/azure/management/synapse/v2019_06_01_preview/implementation/IntegrationRuntimeInner.java:[25,53] cannot find symbol
      [mvn]   symbol: class SelfHostedIntegrationRuntime
      [mvn] [ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.1:compile (default-compile) on project azure-mgmt-synapse: Compilation failure: Compilation failure: 
      [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/synapse/mgmt-v2019_06_01_preview/src/main/java/com/microsoft/azure/management/synapse/v2019_06_01_preview/implementation/BigDataPoolsInner.java:[17,66] cannot find symbol
      [mvn] [ERROR]   symbol:   class ErrorContractInnerException
      [mvn] [ERROR]   location: package com.microsoft.azure.management.synapse.v2019_06_01_preview
      [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/synapse/mgmt-v2019_06_01_preview/src/main/java/com/microsoft/azure/management/synapse/v2019_06_01_preview/implementation/OperationsInner.java:[15,66] cannot find symbol
      [mvn] [ERROR]   symbol:   class ErrorContractInnerException
      [mvn] [ERROR]   location: package com.microsoft.azure.management.synapse.v2019_06_01_preview
      [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/synapse/mgmt-v2019_06_01_preview/src/main/java/com/microsoft/azure/management/synapse/v2019_06_01_preview/implementation/IpFirewallRulesInner.java:[16,66] cannot find symbol
      [mvn] [ERROR]   symbol:   class ErrorContractInnerException
      [mvn] [ERROR]   location: package com.microsoft.azure.management.synapse.v2019_06_01_preview
      [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/synapse/mgmt-v2019_06_01_preview/src/main/java/com/microsoft/azure/management/synapse/v2019_06_01_preview/implementation/SqlPoolsInner.java:[16,66] cannot find symbol
      [mvn] [ERROR]   symbol:   class ErrorContractInnerException
      [mvn] [ERROR]   location: package com.microsoft.azure.management.synapse.v2019_06_01_preview
      [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/synapse/mgmt-v2019_06_01_preview/src/main/java/com/microsoft/azure/management/synapse/v2019_06_01_preview/implementation/SqlPoolMetadataSyncConfigsInner.java:[13,66] cannot find symbol
      [mvn] [ERROR]   symbol:   class ErrorContractInnerException
      [mvn] [ERROR]   location: package com.microsoft.azure.management.synapse.v2019_06_01_preview
      [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/synapse/mgmt-v2019_06_01_preview/src/main/java/com/microsoft/azure/management/synapse/v2019_06_01_preview/implementation/WorkspacesInner.java:[19,66] cannot find symbol
      [mvn] [ERROR]   symbol:   class ErrorContractInnerException
      [mvn] [ERROR]   location: package com.microsoft.azure.management.synapse.v2019_06_01_preview
      [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/synapse/mgmt-v2019_06_01_preview/src/main/java/com/microsoft/azure/management/synapse/v2019_06_01_preview/implementation/WorkspaceAadAdminsInner.java:[15,66] cannot find symbol
      [mvn] [ERROR]   symbol:   class ErrorContractInnerException
      [mvn] [ERROR]   location: package com.microsoft.azure.management.synapse.v2019_06_01_preview
      [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/synapse/mgmt-v2019_06_01_preview/src/main/java/com/microsoft/azure/management/synapse/v2019_06_01_preview/implementation/WorkspaceManagedIdentitySqlControlSettingsInner.java:[13,66] cannot find symbol
      [mvn] [ERROR]   symbol:   class ErrorContractInnerException
      [mvn] [ERROR]   location: package com.microsoft.azure.management.synapse.v2019_06_01_preview
      [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/synapse/mgmt-v2019_06_01_preview/src/main/java/com/microsoft/azure/management/synapse/v2019_06_01_preview/implementation/PrivateEndpointConnectionsInner.java:[15,66] cannot find symbol
      [mvn] [ERROR]   symbol:   class ErrorContractInnerException
      [mvn] [ERROR]   location: package com.microsoft.azure.management.synapse.v2019_06_01_preview
      [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/synapse/mgmt-v2019_06_01_preview/src/main/java/com/microsoft/azure/management/synapse/v2019_06_01_preview/implementation/PrivateLinkHubsInner.java:[19,66] cannot find symbol
      [mvn] [ERROR]   symbol:   class ErrorContractInnerException
      [mvn] [ERROR]   location: package com.microsoft.azure.management.synapse.v2019_06_01_preview
      [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/synapse/mgmt-v2019_06_01_preview/src/main/java/com/microsoft/azure/management/synapse/v2019_06_01_preview/implementation/SqlPoolVulnerabilityAssessmentRuleBaselinesImpl.java:[42,119] cannot find symbol
      [mvn] [ERROR]   symbol:   class VulnerabilityAssessmentPolicyBaselineName
      [mvn] [ERROR]   location: class com.microsoft.azure.management.synapse.v2019_06_01_preview.implementation.SqlPoolVulnerabilityAssessmentRuleBaselinesImpl
      [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/synapse/mgmt-v2019_06_01_preview/src/main/java/com/microsoft/azure/management/synapse/v2019_06_01_preview/implementation/IntegrationRuntimeInner.java:[24,50] cannot find symbol
      [mvn] [ERROR]   symbol: class ManagedIntegrationRuntime
      [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/synapse/mgmt-v2019_06_01_preview/src/main/java/com/microsoft/azure/management/synapse/v2019_06_01_preview/implementation/IntegrationRuntimeInner.java:[25,53] cannot find symbol
      [mvn] [ERROR]   symbol: class SelfHostedIntegrationRuntime
      [mvn] [ERROR] -> [Help 1]
      [mvn] [ERROR] 
      [mvn] [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
      [mvn] [ERROR] Re-run Maven using the -X switch to enable full debug logging.
      [mvn] [ERROR] 
      [mvn] [ERROR] For more information about the errors and possible solutions, please read the following articles:
      [mvn] [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Aug 6, 2020

    Azure CLI Extension Generation - Release

    No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Aug 6, 2020

    azure-sdk-for-net - Release

    ️✔️ succeeded [Logs] [Expand Details]

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Aug 6, 2020

    azure-sdk-for-js - Release

    ️✔️ succeeded [Logs] [Expand Details]
    • ️✔️ Generate from 96c0e47 with merge commit c714e3e. SDK Automation 13.0.17.20200807.2
    • ️✔️@azure/arm-synapse [View full logs]  [Release SDK Changes]
      Only show 100 items here, please refer to log for details.
      [npmPack] npm WARN deprecated [email protected]: This package has been deprecated and is no longer maintained. Please use @rollup/plugin-node-resolve.
      [npmPack] npm WARN deprecated [email protected]: https://github.com/lydell/resolve-url#deprecated
      [npmPack] npm WARN deprecated [email protected]: Please see https://github.com/lydell/urix#deprecated
      [npmPack] npm notice created a lockfile as package-lock.json. You should commit this file.
      [npmPack] loaded rollup.config.js with warnings
      [npmPack] (!) Unused external imports
      [npmPack] default imported from external module 'rollup' but never used
      [npmPack] 
      [npmPack] ./esm/synapseManagementClient.js → ./dist/arm-synapse.js...
      [npmPack] created ./dist/arm-synapse.js in 894ms
      [npmPack] npm notice 
      [npmPack] npm notice package: @azure/[email protected]
      [npmPack] npm notice === Tarball Contents === 
      [npmPack] npm notice 533.8kB dist/arm-synapse.js                                                   
      [npmPack] npm notice 197.3kB dist/arm-synapse.min.js                                               
      [npmPack] npm notice 10.5kB  esm/operations/bigDataPools.js                                        
      [npmPack] npm notice 2.3kB   esm/models/bigDataPoolsMappers.js                                     
      [npmPack] npm notice 345B    esm/models/index.js                                                   
      [npmPack] npm notice 2.0kB   esm/operations/index.js                                               
      [npmPack] npm notice 3.8kB   esm/operations/integrationRuntimeAuthKeysOperations.js                
      [npmPack] npm notice 518B    esm/models/integrationRuntimeAuthKeysOperationsMappers.js             
      [npmPack] npm notice 2.3kB   esm/operations/integrationRuntimeConnectionInfos.js                   
      [npmPack] npm notice 478B    esm/models/integrationRuntimeConnectionInfosMappers.js                
      [npmPack] npm notice 2.2kB   esm/operations/integrationRuntimeCredentials.js                       
      [npmPack] npm notice 440B    esm/models/integrationRuntimeCredentialsMappers.js                    
      [npmPack] npm notice 2.4kB   esm/operations/integrationRuntimeMonitoringDataOperations.js          
      [npmPack] npm notice 525B    esm/models/integrationRuntimeMonitoringDataOperationsMappers.js       
      [npmPack] npm notice 2.4kB   esm/operations/integrationRuntimeNodeIpAddressOperations.js           
      [npmPack] npm notice 485B    esm/models/integrationRuntimeNodeIpAddressOperationsMappers.js        
      [npmPack] npm notice 5.1kB   esm/operations/integrationRuntimeNodes.js                             
      [npmPack] npm notice 505B    esm/models/integrationRuntimeNodesMappers.js                          
      [npmPack] npm notice 3.7kB   esm/operations/integrationRuntimeObjectMetadata.js                    
      [npmPack] npm notice 669B    esm/models/integrationRuntimeObjectMetadataMappers.js                 
      [npmPack] npm notice 13.9kB  esm/operations/integrationRuntimes.js                                 
      [npmPack] npm notice 2.5kB   esm/models/integrationRuntimesMappers.js                              
      [npmPack] npm notice 2.3kB   esm/operations/integrationRuntimeStatusOperations.js                  
      [npmPack] npm notice 739B    esm/models/integrationRuntimeStatusOperationsMappers.js               
      [npmPack] npm notice 10.9kB  esm/operations/ipFirewallRules.js                                     
      [npmPack] npm notice 2.4kB   esm/models/ipFirewallRulesMappers.js                                  
      [npmPack] npm notice 147.0kB esm/models/mappers.js                                                 
      [npmPack] npm notice 5.2kB   esm/operations/operations.js                                          
      [npmPack] npm notice 763B    esm/models/operationsMappers.js                                       
      [npmPack] npm notice 9.1kB   esm/models/parameters.js                                              
      [npmPack] npm notice 8.9kB   esm/operations/privateEndpointConnections.js                          
      [npmPack] npm notice 2.3kB   esm/models/privateEndpointConnectionsMappers.js                       
      [npmPack] npm notice 8.8kB   esm/operations/privateLinkHubs.js                                     
      [npmPack] npm notice 2.3kB   esm/models/privateLinkHubsMappers.js                                  
      [npmPack] npm notice 3.9kB   esm/operations/privateLinkResources.js                                
      [npmPack] npm notice 2.2kB   esm/models/privateLinkResourcesMappers.js                             
      [npmPack] npm notice 983B    rollup.config.js                                                      
      [npmPack] npm notice 3.8kB   esm/operations/sqlPoolBlobAuditingPolicies.js                         
      [npmPack] npm notice 2.2kB   esm/models/sqlPoolBlobAuditingPoliciesMappers.js                      
      [npmPack] npm notice 2.2kB   esm/operations/sqlPoolConnectionPolicies.js                           
      [npmPack] npm notice 2.2kB   esm/models/sqlPoolConnectionPoliciesMappers.js                        
      [npmPack] npm notice 2.3kB   esm/operations/sqlPoolDataWarehouseUserActivities.js                  
      [npmPack] npm notice 2.2kB   esm/models/sqlPoolDataWarehouseUserActivitiesMappers.js               
      [npmPack] npm notice 2.2kB   esm/operations/sqlPoolGeoBackupPolicies.js                            
      [npmPack] npm notice 2.2kB   esm/models/sqlPoolGeoBackupPoliciesMappers.js                         
      [npmPack] npm notice 3.6kB   esm/operations/sqlPoolMetadataSyncConfigs.js                          
      [npmPack] npm notice 2.2kB   esm/models/sqlPoolMetadataSyncConfigsMappers.js                       
      [npmPack] npm notice 2.4kB   esm/operations/sqlPoolOperationResults.js                             
      [npmPack] npm notice 434B    esm/models/sqlPoolOperationResultsMappers.js                          
      [npmPack] npm notice 2.8kB   esm/operations/sqlPoolOperations.js                                   
      [npmPack] npm notice 2.2kB   esm/models/sqlPoolOperationsMappers.js                                
      [npmPack] npm notice 2.9kB   esm/operations/sqlPoolReplicationLinks.js                             
      [npmPack] npm notice 2.2kB   esm/models/sqlPoolReplicationLinksMappers.js                          
      [npmPack] npm notice 5.5kB   esm/operations/sqlPoolRestorePoints.js                                
      [npmPack] npm notice 2.2kB   esm/models/sqlPoolRestorePointsMappers.js                             
      [npmPack] npm notice 15.5kB  esm/operations/sqlPools.js                                            
      [npmPack] npm notice 2.8kB   esm/operations/sqlPoolSchemas.js                                      
      [npmPack] npm notice 2.2kB   esm/models/sqlPoolSchemasMappers.js                                   
      [npmPack] npm notice 3.8kB   esm/operations/sqlPoolSecurityAlertPolicies.js                        
      [npmPack] npm notice 2.2kB   esm/models/sqlPoolSecurityAlertPoliciesMappers.js                     
      [npmPack] npm notice 11.1kB  esm/operations/sqlPoolSensitivityLabels.js                            
      [npmPack] npm notice 2.2kB   esm/models/sqlPoolSensitivityLabelsMappers.js                         
      [npmPack] npm notice 2.3kB   esm/models/sqlPoolsMappers.js                                         
      [npmPack] npm notice 3.1kB   esm/operations/sqlPoolTableColumns.js                                 
      [npmPack] npm notice 2.2kB   esm/models/sqlPoolTableColumnsMappers.js                              
      [npmPack] npm notice 2.9kB   esm/operations/sqlPoolTables.js                                       
      [npmPack] npm notice 2.2kB   esm/models/sqlPoolTablesMappers.js                                    
      [npmPack] npm notice 3.9kB   esm/operations/sqlPoolTransparentDataEncryptions.js                   
      [npmPack] npm notice 2.2kB   esm/models/sqlPoolTransparentDataEncryptionsMappers.js                
      [npmPack] npm notice 2.7kB   esm/operations/sqlPoolUsages.js                                       
      [npmPack] npm notice 462B    esm/models/sqlPoolUsagesMappers.js                                    
      [npmPack] npm notice 4.3kB   esm/operations/sqlPoolVulnerabilityAssessmentRuleBaselines.js         
      [npmPack] npm notice 2.2kB   esm/models/sqlPoolVulnerabilityAssessmentRuleBaselinesMappers.js      
      [npmPack] npm notice 6.9kB   esm/operations/sqlPoolVulnerabilityAssessments.js                     
      [npmPack] npm notice 7.0kB   esm/operations/sqlPoolVulnerabilityAssessmentScans.js                 
      [npmPack] npm notice 2.2kB   esm/models/sqlPoolVulnerabilityAssessmentScansMappers.js              
      [npmPack] npm notice 2.2kB   esm/models/sqlPoolVulnerabilityAssessmentsMappers.js                  
      [npmPack] npm notice 4.9kB   esm/synapseManagementClient.js                                        
      [npmPack] npm notice 2.5kB   esm/synapseManagementClientContext.js                                 
      [npmPack] npm notice 6.4kB   esm/operations/workspaceAadAdmins.js                                  
      [npmPack] npm notice 2.2kB   esm/models/workspaceAadAdminsMappers.js                               
      [npmPack] npm notice 3.7kB   esm/operations/workspaceManagedIdentitySqlControlSettings.js          
      [npmPack] npm notice 2.2kB   esm/models/workspaceManagedIdentitySqlControlSettingsMappers.js       
      [npmPack] npm notice 11.7kB  esm/operations/workspaces.js                                          
      [npmPack] npm notice 2.3kB   esm/models/workspacesMappers.js                                       
      [npmPack] npm notice 1.6kB   package.json                                                          
      [npmPack] npm notice 457B    tsconfig.json                                                         

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Aug 6, 2020

    azure-sdk-for-python - Release

    ️✔️ succeeded [Logs] [Expand Details]
    • ️✔️ Generate from 96c0e47 with merge commit c714e3e. SDK Automation 13.0.17.20200807.2
    • ️✔️azure-mgmt-synapse [View full logs]  [Release SDK Changes]
      [build_conf] INFO:packaging_tools:Building template azure-mgmt-synapse
      [build_conf] INFO:packaging_tools.conf:Skipping default conf since the file exists
      [build_conf] INFO:packaging_tools:Skipping CHANGELOG.md template, since a previous one was found
      [build_conf] INFO:packaging_tools:Template done azure-mgmt-synapse
      [build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
      [build_package]   warnings.warn(msg)
      [build_package] warning: no files found matching '*.py' under directory 'tests'
      [build_package] warning: no files found matching '*.yaml' under directory 'tests'
      [build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
      [build_package]   warnings.warn(msg)
      [build_package] warning: no files found matching '*.py' under directory 'tests'
      [build_package] warning: no files found matching '*.yaml' under directory 'tests'
      [breaking_change_setup] Ignoring mock: markers 'python_version <= "2.7"' don't match your environment
      [ChangeLog] Size of delta 0.091% size of original (original: 118925 chars, delta: 108 chars)
      [ChangeLog] 

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Aug 6, 2020

    azure-sdk-for-python-track2 - Release

    No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Aug 6, 2020

    Trenton Generation - Release

    No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

    @raych1
    Copy link
    Member

    raych1 commented Aug 6, 2020

    @wonner , it's breaking change to add new response code. Does it target the end of year for GA?

    @idear1203
    Copy link
    Contributor

    it's breaking change to add new response code. Does it target the end of year for GA?

    Hi @raych1, thanks for your quick response. Currently we don't have an accurate time for SDK GA. Does it matter?

    The reason to add this status code is because according to our experiments, the original Swagger spec is incorrect - the RP returns 202 in fact.

    @azuresdkci
    Copy link
    Contributor

    Can one of the admins verify this patch?

    @raych1
    Copy link
    Member

    raych1 commented Aug 7, 2020

    it's breaking change to add new response code. Does it target the end of year for GA?

    Hi @raych1, thanks for your quick response. Currently we don't have an accurate time for SDK GA. Does it matter?

    The reason to add this status code is because according to our experiments, the original Swagger spec is incorrect - the RP returns 202 in fact.

    So, this change is to align the swagger with the service implementation, right?

    @idear1203
    Copy link
    Contributor

    idear1203 commented Aug 7, 2020

    it's breaking change to add new response code. Does it target the end of year for GA?

    Hi @raych1, thanks for your quick response. Currently we don't have an accurate time for SDK GA. Does it matter?
    The reason to add this status code is because according to our experiments, the original Swagger spec is incorrect - the RP returns 202 in fact.

    So, this change is to align the swagger with the service implementation, right?

    Right. And we find that the generated SDK code cannot handle long running operation well. That's why we add "x-ms-long-running-operation" extension.

    @raych1 raych1 added the Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 label Aug 7, 2020
    @raych1 raych1 merged commit c714e3e into Azure:master Aug 7, 2020
    innosam pushed a commit to innosam/azure-rest-api-specs that referenced this pull request Aug 17, 2020
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    4 participants