Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DataShare] sort definitions in the 2019 version #10301

Merged
merged 3 commits into from
Aug 5, 2020
Merged

[DataShare] sort definitions in the 2019 version #10301

merged 3 commits into from
Aug 5, 2020

Conversation

vnvaditya
Copy link
Contributor

@vnvaditya vnvaditya commented Jul 30, 2020

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

  • Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.

    • Adding new API(s)
    • Adding a new API version
    • Adding a new service
  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in stable version
  • Removing properties in stable version
  • Removing API version(s) in stable version
  • Updating API in stable version with Breaking Change Validation errors
  • Updating API(s) in preview over 1 year

Please follow the link to find more details on PR review process.

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Jul 30, 2020

[Staging] Swagger Validation Report

️✔️BreakingChange [Detail]
 There are no breaking changes. 
️✔️LintDiff [Detail]
 Validation passes for LintDiff. 
️✔️Avocado [Detail]
 Validation passes for Avocado. 
Posted by Swagger Pipeline | How to fix these errors?

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jul 30, 2020

azure-sdk-for-go - Release

️✔️ succeeded [Logs] [Expand Details]

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jul 30, 2020

Trenton Generation - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jul 30, 2020

azure-sdk-for-python - Release

- Breaking Change detected in SDK

⚠️ warning [Logs] [Expand Details]
  • ⚠️ Generate from 230e179 with merge commit db262fd. SDK Automation 13.0.17.20200619.4
  • ⚠️azure-mgmt-datashare [View full logs]  [Release SDK Changes] Breaking Change Detected
    [build_conf] INFO:packaging_tools:Building template azure-mgmt-datashare
    [build_conf] INFO:packaging_tools.conf:Skipping default conf since the file exists
    [build_conf] INFO:packaging_tools:Skipping CHANGELOG.md template, since a previous one was found
    [build_conf] INFO:packaging_tools:Template done azure-mgmt-datashare
    [build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
    [build_package]   warnings.warn(msg)
    [build_package] warning: no files found matching '*.py' under directory 'tests'
    [build_package] warning: no files found matching '*.yaml' under directory 'tests'
    [build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
    [build_package]   warnings.warn(msg)
    [build_package] warning: no files found matching '*.py' under directory 'tests'
    [build_package] warning: no files found matching '*.yaml' under directory 'tests'
    [breaking_change_setup] Ignoring mock: markers 'python_version <= "2.7"' don't match your environment
    [ChangeLog] Size of delta 2.793% size of original (original: 70386 chars, delta: 1966 chars)
    [ChangeLog] **Breaking changes**
    [ChangeLog] 
    [ChangeLog]   - Operation DataSetMappingsOperations.list_by_share_subscription has a new signature
    [ChangeLog]   - Operation DataSetMappingsOperations.list_by_share_subscription has a new signature
    [ChangeLog]   - Operation DataSetsOperations.list_by_share has a new signature
    [ChangeLog]   - Operation DataSetsOperations.list_by_share has a new signature
    [ChangeLog]   - Operation InvitationsOperations.list_by_share has a new signature
    [ChangeLog]   - Operation InvitationsOperations.list_by_share has a new signature
    [ChangeLog]   - Operation ShareSubscriptionsOperations.list_synchronization_details has a new signature
    [ChangeLog]   - Operation ShareSubscriptionsOperations.list_synchronization_details has a new signature
    [ChangeLog]   - Operation ShareSubscriptionsOperations.list_synchronizations has a new signature
    [ChangeLog]   - Operation ShareSubscriptionsOperations.list_synchronizations has a new signature
    [ChangeLog]   - Operation SharesOperations.list_synchronization_details has a new signature
    [ChangeLog]   - Operation SharesOperations.list_synchronization_details has a new signature
    [ChangeLog]   - Operation SharesOperations.list_synchronizations has a new signature
    [ChangeLog]   - Operation SharesOperations.list_synchronizations has a new signature
    [ChangeLog]   - Operation SharesOperations.list_by_account has a new signature
    [ChangeLog]   - Operation ShareSubscriptionsOperations.list_by_account has a new signature

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jul 30, 2020

azure-sdk-for-js - Release

️✔️ succeeded [Logs] [Expand Details]
  • ️✔️ Generate from 230e179 with merge commit db262fd. SDK Automation 13.0.17.20200619.4
  • ️✔️@azure/arm-datashare [View full logs]  [Release SDK Changes]
    Only show 100 items here, please refer to log for details.
    [npmPack] npm WARN deprecated [email protected]: This package has been deprecated and is no longer maintained. Please use @rollup/plugin-node-resolve.
    [npmPack] npm WARN deprecated [email protected]: https://github.com/lydell/resolve-url#deprecated
    [npmPack] npm WARN deprecated [email protected]: Please see https://github.com/lydell/urix#deprecated
    [npmPack] npm notice created a lockfile as package-lock.json. You should commit this file.
    [npmPack] loaded rollup.config.js with warnings
    [npmPack] (!) Unused external imports
    [npmPack] default imported from external module 'rollup' but never used
    [npmPack] 
    [npmPack] ./esm/dataShareManagementClient.js → ./dist/arm-datashare.js...
    [npmPack] created ./dist/arm-datashare.js in 538ms
    [npmPack] npm notice 
    [npmPack] npm notice package: @azure/[email protected]
    [npmPack] npm notice === Tarball Contents === 
    [npmPack] npm notice 10.3kB  esm/operations/accounts.js                           
    [npmPack] npm notice 1.3kB   esm/models/accountsMappers.js                        
    [npmPack] npm notice 249.8kB dist/arm-datashare.js                                
    [npmPack] npm notice 92.3kB  dist/arm-datashare.min.js                            
    [npmPack] npm notice 4.3kB   esm/operations/consumerInvitations.js                
    [npmPack] npm notice 1.3kB   esm/models/consumerInvitationsMappers.js             
    [npmPack] npm notice 3.1kB   esm/operations/consumerSourceDataSets.js             
    [npmPack] npm notice 1.3kB   esm/models/consumerSourceDataSetsMappers.js          
    [npmPack] npm notice 7.1kB   esm/operations/dataSetMappings.js                    
    [npmPack] npm notice 1.3kB   esm/models/dataSetMappingsMappers.js                 
    [npmPack] npm notice 7.6kB   esm/operations/dataSets.js                           
    [npmPack] npm notice 1.3kB   esm/models/dataSetsMappers.js                        
    [npmPack] npm notice 2.3kB   esm/dataShareManagementClient.js                     
    [npmPack] npm notice 2.6kB   esm/dataShareManagementClientContext.js              
    [npmPack] npm notice 345B    esm/models/index.js                                  
    [npmPack] npm notice 765B    esm/operations/index.js                              
    [npmPack] npm notice 6.6kB   esm/operations/invitations.js                        
    [npmPack] npm notice 1.3kB   esm/models/invitationsMappers.js                     
    [npmPack] npm notice 90.1kB  esm/models/mappers.js                                
    [npmPack] npm notice 2.2kB   esm/operations/operations.js                         
    [npmPack] npm notice 623B    esm/models/operationsMappers.js                      
    [npmPack] npm notice 4.4kB   esm/models/parameters.js                             
    [npmPack] npm notice 8.2kB   esm/operations/providerShareSubscriptions.js         
    [npmPack] npm notice 1.3kB   esm/models/providerShareSubscriptionsMappers.js      
    [npmPack] npm notice 989B    rollup.config.js                                     
    [npmPack] npm notice 11.3kB  esm/operations/shares.js                             
    [npmPack] npm notice 1.4kB   esm/models/sharesMappers.js                          
    [npmPack] npm notice 20.1kB  esm/operations/shareSubscriptions.js                 
    [npmPack] npm notice 1.5kB   esm/models/shareSubscriptionsMappers.js              
    [npmPack] npm notice 8.4kB   esm/operations/synchronizationSettings.js            
    [npmPack] npm notice 1.3kB   esm/models/synchronizationSettingsMappers.js         
    [npmPack] npm notice 9.5kB   esm/operations/triggers.js                           
    [npmPack] npm notice 1.3kB   esm/models/triggersMappers.js                        
    [npmPack] npm notice 1.7kB   package.json                                         
    [npmPack] npm notice 457B    tsconfig.json                                        
    [npmPack] npm notice 3.4kB   esm/operations/accounts.d.ts.map                     
    [npmPack] npm notice 5.7kB   esm/operations/accounts.js.map                       
    [npmPack] npm notice 708B    esm/models/accountsMappers.d.ts.map                  
    [npmPack] npm notice 721B    esm/models/accountsMappers.js.map                    
    [npmPack] npm notice 521.4kB dist/arm-datashare.js.map                            
    [npmPack] npm notice 69.7kB  dist/arm-datashare.min.js.map                        
    [npmPack] npm notice 2.0kB   esm/operations/consumerInvitations.d.ts.map          
    [npmPack] npm notice 2.7kB   esm/operations/consumerInvitations.js.map            
    [npmPack] npm notice 707B    esm/models/consumerInvitationsMappers.d.ts.map       
    [npmPack] npm notice 720B    esm/models/consumerInvitationsMappers.js.map         
    [npmPack] npm notice 1.3kB   esm/operations/consumerSourceDataSets.d.ts.map       
    [npmPack] npm notice 1.7kB   esm/operations/consumerSourceDataSets.js.map         
    [npmPack] npm notice 713B    esm/models/consumerSourceDataSetsMappers.d.ts.map    
    [npmPack] npm notice 726B    esm/models/consumerSourceDataSetsMappers.js.map      
    [npmPack] npm notice 3.1kB   esm/operations/dataSetMappings.d.ts.map              
    [npmPack] npm notice 3.9kB   esm/operations/dataSetMappings.js.map                
    [npmPack] npm notice 699B    esm/models/dataSetMappingsMappers.d.ts.map           
    [npmPack] npm notice 712B    esm/models/dataSetMappingsMappers.js.map             
    [npmPack] npm notice 2.8kB   esm/operations/dataSets.d.ts.map                     
    [npmPack] npm notice 4.2kB   esm/operations/dataSets.js.map                       
    [npmPack] npm notice 682B    esm/models/dataSetsMappers.d.ts.map                  
    [npmPack] npm notice 695B    esm/models/dataSetsMappers.js.map                    
    [npmPack] npm notice 1.0kB   esm/dataShareManagementClient.d.ts.map               
    [npmPack] npm notice 1.4kB   esm/dataShareManagementClient.js.map                 
    [npmPack] npm notice 516B    esm/dataShareManagementClientContext.d.ts.map        
    [npmPack] npm notice 1.4kB   esm/dataShareManagementClientContext.js.map          
    [npmPack] npm notice 41.4kB  esm/models/index.d.ts.map                            
    [npmPack] npm notice 380B    esm/operations/index.d.ts.map                        
    [npmPack] npm notice 126B    esm/models/index.js.map                              
    [npmPack] npm notice 395B    esm/operations/index.js.map                          
    [npmPack] npm notice 3.0kB   esm/operations/invitations.d.ts.map                  
    [npmPack] npm notice 3.9kB   esm/operations/invitations.js.map                    
    [npmPack] npm notice 688B    esm/models/invitationsMappers.d.ts.map               
    [npmPack] npm notice 701B    esm/models/invitationsMappers.js.map                 
    [npmPack] npm notice 3.7kB   esm/models/mappers.d.ts.map                          
    [npmPack] npm notice 50.9kB  esm/models/mappers.js.map                            
    [npmPack] npm notice 1.0kB   esm/operations/operations.d.ts.map                   
    [npmPack] npm notice 1.4kB   esm/operations/operations.js.map                     
    [npmPack] npm notice 287B    esm/models/operationsMappers.d.ts.map                
    [npmPack] npm notice 300B    esm/models/operationsMappers.js.map                  
    [npmPack] npm notice 1.1kB   esm/models/parameters.d.ts.map                       
    [npmPack] npm notice 3.3kB   esm/models/parameters.js.map                         
    [npmPack] npm notice 2.8kB   esm/operations/providerShareSubscriptions.d.ts.map   
    [npmPack] npm notice 4.0kB   esm/operations/providerShareSubscriptions.js.map     
    [npmPack] npm notice 721B    esm/models/providerShareSubscriptionsMappers.d.ts.map
    [npmPack] npm notice 734B    esm/models/providerShareSubscriptionsMappers.js.map  
    [npmPack] npm notice 4.5kB   esm/operations/shares.d.ts.map                       
    [npmPack] npm notice 6.5kB   esm/operations/shares.js.map                         
    [npmPack] npm notice 743B    esm/models/sharesMappers.d.ts.map                    
    [npmPack] npm notice 756B    esm/models/sharesMappers.js.map                      
    [npmPack] npm notice 6.3kB   esm/operations/shareSubscriptions.d.ts.map           
    [npmPack] npm notice 10.0kB  esm/operations/shareSubscriptions.js.map             

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jul 30, 2020

Azure CLI Extension Generation - Release

  • Installation instruction for service datashare [Preview Changes]
    az extension add --source=https://sdkautomation.blob.core.windows.net/sdkautomation-pipeline/Azure/azure-rest-api-specs/10301/azure-cli-extensions/Azure/azure-cli-extensions/datashare/datashare-0.1.0-py3-none-any.whl
️✔️ succeeded [Logs] [Expand Details]
  • ️✔️ Generate from 230e179 with merge commit db262fd. Azure CLI Automation 13.0.17.20200619.4
    [AutoRest] WARNING (): cli.auto-parameter-hidden is not true, skip visibility cleaner
    [AutoRest] 
    [AutoRest] NO TEST SCENARIO PROVIDED - DEFAULT WILL BE USED
    [AutoRest] ADD FOLLOWING SECTION TO readme.cli.md FILE TO MODIFY IT
    [AutoRest] --------------------------------------------------------
    [AutoRest]   test-scenario:
    [AutoRest]     - name: /Accounts/put/Accounts_Create
    [AutoRest]     - name: /Accounts/get/Accounts_Get
    [AutoRest]     - name: /Accounts/get/Accounts_ListByResourceGroup
    [AutoRest]     - name: /Accounts/get/Accounts_ListBySubscription
    [AutoRest]     - name: /Accounts/patch/Accounts_Update
    [AutoRest]     - name: /ConsumerInvitations/get/ConsumerInvitations_Get
    [AutoRest]     - name: /ConsumerInvitations/get/ConsumerInvitations_ListInvitations
    [AutoRest]     - name: /ConsumerInvitations/post/ConsumerInvitations_RejectInvitation
    [AutoRest]     - name: /ConsumerSourceDataSets/get/ConsumerSourceDataSets_ListByShareSubscription
    [AutoRest]     - name: /DataSetMappings/put/DataSetMappings_Create
    [AutoRest]     - name: /DataSetMappings/put/DataSetMappings_SqlDB_Create
    [AutoRest]     - name: /DataSetMappings/put/DataSetMappings_SqlDWDataSetToAdlsGen2File_Create
    [AutoRest]     - name: /DataSetMappings/put/DataSetMappings_SqlDW_Create
    [AutoRest]     - name: /DataSetMappings/get/DataSetMappings_Get
    [AutoRest]     - name: /DataSetMappings/get/DataSetMappings_ListByShareSubscription
    [AutoRest]     - name: /DataSets/put/DataSets_Create
    [AutoRest]     - name: /DataSets/put/DataSets_KustoCluster_Create
    [AutoRest]     - name: /DataSets/put/DataSets_KustoDatabase_Create
    [AutoRest]     - name: /DataSets/put/DataSets_SqlDBTable_Create
    [AutoRest]     - name: /DataSets/put/DataSets_SqlDWTable_Create
    [AutoRest]     - name: /DataSets/get/DataSets_Get
    [AutoRest]     - name: /DataSets/get/DataSets_ListByShare
    [AutoRest]     - name: /Invitations/put/Invitations_Create
    [AutoRest]     - name: /Invitations/get/Invitations_Get
    [AutoRest]     - name: /Invitations/get/Invitations_ListByShare
    [AutoRest]     - name: /ProviderShareSubscriptions/get/ProviderShareSubscriptions_GetByShare
    [AutoRest]     - name: /ProviderShareSubscriptions/get/ProviderShareSubscriptions_ListByShare
    [AutoRest]     - name: /ProviderShareSubscriptions/post/ProviderShareSubscriptions_Reinstate
    [AutoRest]     - name: /ProviderShareSubscriptions/post/ProviderShareSubscriptions_Revoke
    [AutoRest]     - name: /ShareSubscriptions/put/ShareSubscriptions_Create
    [AutoRest]     - name: /ShareSubscriptions/get/ShareSubscriptions_Get
    [AutoRest]     - name: /ShareSubscriptions/get/ShareSubscriptions_ListByAccount
    [AutoRest]     - name: /ShareSubscriptions/post/ShareSubscriptions_CancelSynchronization
    [AutoRest]     - name: /ShareSubscriptions/post/ShareSubscriptions_ListSourceShareSynchronizationSettings
    [AutoRest]     - name: /ShareSubscriptions/post/ShareSubscriptions_ListSynchronizationDetails
    [AutoRest]     - name: /ShareSubscriptions/post/ShareSubscriptions_ListSynchronizations
    [AutoRest]     - name: /ShareSubscriptions/post/ShareSubscriptions_Synchronize
    [AutoRest]     - name: /Shares/put/Shares_Create
    [AutoRest]     - name: /Shares/get/Shares_Get
    [AutoRest]     - name: /Shares/get/Shares_ListByAccount
    [AutoRest]     - name: /Shares/post/Shares_ListSynchronizationDetails
    [AutoRest]     - name: /Shares/post/Shares_ListSynchronizations
    [AutoRest]     - name: /SynchronizationSettings/put/SynchronizationSettings_Create
    [AutoRest]     - name: /SynchronizationSettings/get/SynchronizationSettings_Get
    [AutoRest]     - name: /SynchronizationSettings/get/SynchronizationSettings_ListByShare
    [AutoRest]     - name: /Triggers/put/Triggers_Create
    [AutoRest]     - name: /Triggers/get/Triggers_Get
    [AutoRest]     - name: /Triggers/get/Triggers_ListByShareSubscription
    [AutoRest]     - name: /Accounts/delete/Accounts_Delete
    [AutoRest]     - name: /DataSetMappings/delete/DataSetMappings_Delete
    [AutoRest]     - name: /DataSets/delete/DataSets_Delete
    [AutoRest]     - name: /Invitations/delete/Invitations_Delete
    [AutoRest]     - name: /ShareSubscriptions/delete/ShareSubscriptions_Delete
    [AutoRest]     - name: /Shares/delete/Shares_Delete
    [AutoRest]     - name: /SynchronizationSettings/delete/SynchronizationSettings_Delete
    [AutoRest]     - name: /Triggers/delete/Triggers_Delete
    [AutoRest] --------------------------------------------------------
  • ️✔️datashare [View full logs]  [Release Azure CLI Changes]

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jul 30, 2020

azure-sdk-for-python-track2 - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jul 30, 2020

azure-sdk-for-net - Release

️✔️ succeeded [Logs] [Expand Details]

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jul 30, 2020

azure-sdk-for-java - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@vnvaditya
Copy link
Contributor Author

vnvaditya commented Jul 31, 2020

This is the final followup to sorting and ordering of API's and definitions. #10273

Python API's also shouldn't be breaking change. We just added query parameters. Refer: #10209

@vnvaditya vnvaditya changed the title sort definitions in the 2019 version [DataShare] sort definitions in the 2019 version Jul 31, 2020
@openapi-assignment-bot openapi-assignment-bot bot added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Aug 4, 2020
@leni-msft leni-msft merged commit db262fd into Azure:master Aug 5, 2020
@leni-msft leni-msft removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Aug 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants