[Hub Generated] Review request for Microsoft.Capacity to add version preview/2019-04-01 #10297

aditink · 2020-07-30T05:35:02Z

This is a PR generated at OpenAPI Hub. You can view your work branch via this link.

Contribution checklist:

I have reviewed the documentation for AME onboarding.
Validation tools have been run on swagger spec(s) updated and errors have all been fixed with this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.

adding/removing APIs.
adding/removing properties.
adding/removing API-version.
adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Please follow the link to find more details on PR review process.

openapi-pipeline-app · 2020-07-30T05:35:06Z

[Staging] Swagger Validation Report

️❌BreakingChange: 1 Errors, 0 Warnings [Detail] [Expand]

Rule	Message
`❌` 1020 - AddedEnumValue	The new version is adding enum value(s) 'Databricks, AppService, ManagedDisk, BlockBlob, RedisCache, AzureDataExplorer, MySql, MariaDb, PostgreSql, DedicatedHost, SapHana, SqlAzureHybridBenefit' from the old version. New: Microsoft.Capacity/preview/2019-04-01/reservations.json#L1115:9 Old: Microsoft.Capacity/preview/2019-04-01/reservations.json#L1115:9

️️✔️LintDiff [Detail]

 Validation passes for LintDiff.

️️✔️Avocado [Detail]

 Validation passes for Avocado.

_{Posted by Swagger Pipeline | How to fix these errors?}

azure-pipelines · 2020-07-30T05:35:19Z

Azure Pipelines successfully started running 1 pipeline(s).

openapi-sdkautomation · 2020-07-30T05:36:42Z

azure-sdk-for-go - Release

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from 4f9ba85 with merge commit 9ea4dc2. SDK Automation 13.0.17.20200619.4
️✔️preview/reservations/mgmt/2018-06-01 [View full logs] [Release SDK Changes]
- preview.reservations.mgmt.2018-06-01.zip
️✔️preview/reservations/mgmt/2019-04-01 [View full logs] [Release SDK Changes]
- preview.reservations.mgmt.2019-04-01.zip
️✔️preview/reservations/mgmt/2019-07-19-preview [View full logs] [Release SDK Changes]
- preview.reservations.mgmt.2019-07-19-preview.zip
️✔️reservations/mgmt/2017-11-01 [View full logs] [Release SDK Changes]
- reservations.mgmt.2017-11-01.zip

openapi-sdkautomation · 2020-07-30T05:36:42Z

azure-sdk-for-net - Release

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from 4f9ba85 with merge commit 9ea4dc2. SDK Automation 13.0.17.20200619.4

[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied

️✔️Microsoft.Azure.Management.Reservations [View full logs] [Release SDK Changes]
- Microsoft.Azure.Management.Reservations.1.14.0-preview.nupkg
- Microsoft.Azure.Management.Reservations.1.14.0-preview.snupkg

openapi-sdkautomation · 2020-07-30T05:36:44Z

azure-sdk-for-js - Release

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from 4f9ba85 with merge commit 9ea4dc2. SDK Automation 13.0.17.20200619.4

️✔️@azure/arm-reservations [View full logs] [Release SDK Changes]

azure-arm-reservations-5.1.0.tgz

Only show 100 items here, please refer to log for details.

[npmPack] npm WARN deprecated [email protected]: This package has been deprecated and is no longer maintained. Please use @rollup/plugin-node-resolve.
[npmPack] npm WARN deprecated [email protected]: https://github.com/lydell/resolve-url#deprecated
[npmPack] npm WARN deprecated [email protected]: Please see https://github.com/lydell/urix#deprecated
[npmPack] npm notice created a lockfile as package-lock.json. You should commit this file.
[npmPack] loaded rollup.config.js with warnings
[npmPack] (!) Unused external imports
[npmPack] default imported from external module 'rollup' but never used
[npmPack] 
[npmPack] ./esm/azureReservationAPI.js → ./dist/arm-reservations.js...
[npmPack] created ./dist/arm-reservations.js in 458ms
[npmPack] npm notice 
[npmPack] npm notice package: @azure/[email protected]
[npmPack] npm notice === Tarball Contents === 
[npmPack] npm notice 142.8kB dist/arm-reservations.js                     
[npmPack] npm notice 48.8kB  dist/arm-reservations.min.js                 
[npmPack] npm notice 2.9kB   esm/operations/autoQuotaIncrease.js          
[npmPack] npm notice 1.2kB   esm/models/autoQuotaIncreaseMappers.js       
[npmPack] npm notice 4.0kB   esm/azureReservationAPI.js                   
[npmPack] npm notice 2.2kB   esm/azureReservationAPIContext.js            
[npmPack] npm notice 345B    esm/models/index.js                          
[npmPack] npm notice 547B    esm/operations/index.js                      
[npmPack] npm notice 61.2kB  esm/models/mappers.js                        
[npmPack] npm notice 2.2kB   esm/operations/operation.js                  
[npmPack] npm notice 475B    esm/models/operationMappers.js               
[npmPack] npm notice 4.2kB   esm/models/parameters.js                     
[npmPack] npm notice 11.5kB  esm/operations/quota.js                      
[npmPack] npm notice 1.2kB   esm/models/quotaMappers.js                   
[npmPack] npm notice 3.8kB   esm/operations/quotaRequestStatus.js         
[npmPack] npm notice 1.2kB   esm/models/quotaRequestStatusMappers.js      
[npmPack] npm notice 14.3kB  esm/operations/reservation.js                
[npmPack] npm notice 1.3kB   esm/models/reservationMappers.js             
[npmPack] npm notice 6.1kB   esm/operations/reservationOrder.js           
[npmPack] npm notice 1.3kB   esm/models/reservationOrderMappers.js        
[npmPack] npm notice 989B    rollup.config.js                             
[npmPack] npm notice 1.7kB   package.json                                 
[npmPack] npm notice 457B    tsconfig.json                                
[npmPack] npm notice 267.1kB dist/arm-reservations.js.map                 
[npmPack] npm notice 39.3kB  dist/arm-reservations.min.js.map             
[npmPack] npm notice 1.2kB   esm/operations/autoQuotaIncrease.d.ts.map    
[npmPack] npm notice 1.6kB   esm/operations/autoQuotaIncrease.js.map      
[npmPack] npm notice 586B    esm/models/autoQuotaIncreaseMappers.d.ts.map 
[npmPack] npm notice 599B    esm/models/autoQuotaIncreaseMappers.js.map   
[npmPack] npm notice 1.6kB   esm/azureReservationAPI.d.ts.map             
[npmPack] npm notice 2.4kB   esm/azureReservationAPI.js.map               
[npmPack] npm notice 426B    esm/azureReservationAPIContext.d.ts.map      
[npmPack] npm notice 1.2kB   esm/azureReservationAPIContext.js.map        
[npmPack] npm notice 21.2kB  esm/models/index.d.ts.map                    
[npmPack] npm notice 248B    esm/operations/index.d.ts.map                
[npmPack] npm notice 126B    esm/models/index.js.map                      
[npmPack] npm notice 263B    esm/operations/index.js.map                  
[npmPack] npm notice 3.3kB   esm/models/mappers.d.ts.map                  
[npmPack] npm notice 33.8kB  esm/models/mappers.js.map                    
[npmPack] npm notice 1.0kB   esm/operations/operation.d.ts.map            
[npmPack] npm notice 1.4kB   esm/operations/operation.js.map              
[npmPack] npm notice 226B    esm/models/operationMappers.d.ts.map         
[npmPack] npm notice 239B    esm/models/operationMappers.js.map           
[npmPack] npm notice 1.0kB   esm/models/parameters.d.ts.map               
[npmPack] npm notice 3.3kB   esm/models/parameters.js.map                 
[npmPack] npm notice 2.7kB   esm/operations/quota.d.ts.map                
[npmPack] npm notice 4.7kB   esm/operations/quota.js.map                  
[npmPack] npm notice 608B    esm/models/quotaMappers.d.ts.map             
[npmPack] npm notice 621B    esm/models/quotaMappers.js.map               
[npmPack] npm notice 1.8kB   esm/operations/quotaRequestStatus.d.ts.map   
[npmPack] npm notice 2.3kB   esm/operations/quotaRequestStatus.js.map     
[npmPack] npm notice 601B    esm/models/quotaRequestStatusMappers.d.ts.map
[npmPack] npm notice 614B    esm/models/quotaRequestStatusMappers.js.map  
[npmPack] npm notice 3.7kB   esm/operations/reservation.d.ts.map          
[npmPack] npm notice 7.2kB   esm/operations/reservation.js.map            
[npmPack] npm notice 647B    esm/models/reservationMappers.d.ts.map       
[npmPack] npm notice 660B    esm/models/reservationMappers.js.map         
[npmPack] npm notice 2.2kB   esm/operations/reservationOrder.d.ts.map     
[npmPack] npm notice 3.5kB   esm/operations/reservationOrder.js.map       
[npmPack] npm notice 636B    esm/models/reservationOrderMappers.d.ts.map  
[npmPack] npm notice 649B    esm/models/reservationOrderMappers.js.map    
[npmPack] npm notice 3.6kB   README.md                                    
[npmPack] npm notice 2.7kB   esm/operations/autoQuotaIncrease.d.ts        
[npmPack] npm notice 5.3kB   src/operations/autoQuotaIncrease.ts          
[npmPack] npm notice 852B    esm/models/autoQuotaIncreaseMappers.d.ts     
[npmPack] npm notice 1.2kB   src/models/autoQuotaIncreaseMappers.ts       
[npmPack] npm notice 3.5kB   esm/azureReservationAPI.d.ts                 
[npmPack] npm notice 6.4kB   src/azureReservationAPI.ts                   
[npmPack] npm notice 653B    esm/azureReservationAPIContext.d.ts          
[npmPack] npm notice 2.0kB   src/azureReservationAPIContext.ts            
[npmPack] npm notice 57.5kB  esm/models/index.d.ts                        
[npmPack] npm notice 231B    esm/operations/index.d.ts                    
[npmPack] npm notice 55.0kB  src/models/index.ts                          
[npmPack] npm notice 515B    src/operations/index.ts                      
[npmPack] npm notice 4.5kB   esm/models/mappers.d.ts                      
[npmPack] npm notice 48.3kB  src/models/mappers.ts                        
[npmPack] npm notice 2.0kB   esm/operations/operation.d.ts                
[npmPack] npm notice 4.0kB   src/operations/operation.ts                  
[npmPack] npm notice 165B    esm/models/operationMappers.d.ts             
[npmPack] npm notice 442B    src/models/operationMappers.ts               
[npmPack] npm notice 1.2kB   esm/models/parameters.d.ts                   
[npmPack] npm notice 4.2kB   src/models/parameters.ts                     
[npmPack] npm notice 9.7kB   esm/operations/quota.d.ts                    
[npmPack] npm notice 15.8kB  src/operations/quota.ts                      
[npmPack] npm notice 919B    esm/models/quotaMappers.d.ts                 
[npmPack] npm notice 1.3kB   src/models/quotaMappers.ts                   
[npmPack] npm notice 4.7kB   esm/operations/quotaRequestStatus.d.ts

openapi-sdkautomation · 2020-07-30T05:36:45Z

azure-sdk-for-java - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

openapi-sdkautomation · 2020-07-30T05:36:45Z

Azure CLI Extension Generation - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

openapi-sdkautomation · 2020-07-30T05:36:46Z

azure-sdk-for-python - Release

- Breaking Change detected in SDK

⚠️ warning [Logs] [Expand Details]

⚠️ Generate from 4f9ba85 with merge commit 9ea4dc2. SDK Automation 13.0.17.20200619.4

⚠️azure-mgmt-reservations [View full logs] [Release SDK Changes] Breaking Change Detected

[build_conf] INFO:packaging_tools:Building template azure-mgmt-reservations
[build_conf] INFO:packaging_tools.conf:Skipping default conf since the file exists
[build_conf] INFO:packaging_tools:Skipping CHANGELOG.md template, since a previous one was found
[build_conf] INFO:packaging_tools:Template done azure-mgmt-reservations
[build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
[build_package]   warnings.warn(msg)
[build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
[build_package]   warnings.warn(msg)
[breaking_change_setup] Ignoring mock: markers 'python_version <= "2.7"' don't match your environment
[ChangeLog] Size of delta 15.319% size of original (original: 36890 chars, delta: 5651 chars)
[ChangeLog] **Features**
[ChangeLog] 
[ChangeLog]   - Added operation QuotaOperations.create_or_update
[ChangeLog]   - Added operation QuotaOperations.list
[ChangeLog]   - Added operation QuotaOperations.get
[ChangeLog]   - Added operation QuotaOperations.update
[ChangeLog]   - Added operation group QuotaRequestStatusOperations
[ChangeLog] 
[ChangeLog] **Breaking changes**
[ChangeLog] 
[ChangeLog]   - Model QuotaRequestOneResourceSubmitResponse no longer has parameter name1
[ChangeLog]   - Model QuotaRequestOneResourceSubmitResponse no longer has parameter unit
[ChangeLog]   - Model QuotaRequestOneResourceSubmitResponse no longer has parameter limit
[ChangeLog]   - Model QuotaRequestOneResourceSubmitResponse no longer has parameter resource_type
[ChangeLog]   - Model QuotaRequestOneResourceSubmitResponse no longer has parameter current_value
[ChangeLog]   - Model QuotaRequestOneResourceSubmitResponse no longer has parameter quota_period
[ChangeLog]   - Model SupportRequestAction no longer has parameter auto_quota_increase_state
[ChangeLog]   - Model CurrentQuotaLimit has a new signature
[ChangeLog]   - Model CurrentQuotaLimitBase has a new signature
[ChangeLog]   - Model EmailActions has a new signature
[ChangeLog]   - Removed operation QuotaOperations.list_status
[ChangeLog]   - Removed operation group QuotaRequestsOperations
[ChangeLog]   - Removed operation group QuotaRequestOperations
[ChangeLog]   - Removed operation group QuotasOperations

openapi-sdkautomation · 2020-07-30T05:36:47Z

azure-sdk-for-python-track2 - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

azure-pipelines · 2020-07-30T05:37:57Z

Azure Pipelines successfully started running 1 pipeline(s).

openapi-sdkautomation · 2020-07-30T05:39:21Z

Trenton Generation - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

azuresdkci · 2020-07-30T05:48:09Z

Can one of the admins verify this patch?

fengzhou-msft · 2020-08-03T06:20:48Z

As identified in the automated checks there are breaking changes, please review Policy for Breaking Changes and request an approval .

adrianhall · 2020-08-04T21:08:29Z

Exception for breaking change requirement granted - extensible enum with additional values added - allowed with no version change (cc: @JeffreyRichterMSFT)

fengzhou-msft · 2020-08-05T02:31:07Z

/azp run

azure-pipelines · 2020-08-05T02:31:27Z

Azure Pipelines successfully started running 3 pipeline(s).

fengzhou-msft · 2020-08-05T03:46:38Z

@akning-ms The ModelValidation error doesn't seem to be caused by the changes in this PR. Can you take a look and merge if the change looks good to you?

akning-ms · 2020-08-05T04:39:39Z

@raych1 to check ModelValidation failure

raych1 · 2020-08-05T08:41:26Z

@raych1 to check ModelValidation failure

There're some legacy errors for the example files. It needs to be fixed in future.

{ message:
   'Validating "examples" and "x-ms-examples" in  d:\\git\\github\\azure-rest-api-specs\\specification\\reservations\\resource-manager\\Microsoft.Capacity\\preview\\2019-04-01\\reservations.json:\n',
  level: '\u001b[32minfo\u001b[39m' }
{ code: 'REQUEST_VALIDATION_ERROR',
  id: 'OAV109',
  message:
   'Found errors in validating the request for x-ms-example "AvailableScopes" in operation "Reservation_AvailableScopes".:\nFound errors in validating the request for x-ms-example "AvailableScopes" in operation "Reservation_AvailableScopes".',
  innerErrors:
   [ { code: 'INVALID_REQUEST_PARAMETER',
       errors:
        [ { code: 'INVALID_TYPE',
            params: [ 'array', 'object' ],
            message: 'Expected type array but found type object',
            path: [],
            title:
             '{"path":["parameters","ScopeParameter","schema"],"position":{"line":1650,"column":17},"url":"d:\\\\git\\\\github\\\\azure-rest-api-specs\\\\specification\\\\reservations\\\\resource-manager\\\\Microsoft.Capacity\\\\preview\\\\2019-04-01\\\\reservations.json","directives":{}}' } ],
       in: 'body',
       message:
        'Invalid parameter (body): Value failed JSON Schema validation',
       name: 'body',
       path: [ 'parameters', 'body' ],
       schemaPath:
        '#/paths/~1providers~1Microsoft.Capacity~1reservationOrders~1{reservationOrderId}~1reservations~1{reservationId}~1availableScopes/post/parameters/3',
       title:
        '{"path":["parameters","body"],"position":{"line":6,"column":13},"url":"d:/git/github/azure-rest-api-specs/specification/reservations/resource-manager/Microsoft.Capacity/preview/2019-04-01/examples/GetAvailableScope.json"}' } ],
  level: '\u001b[31merror\u001b[39m' }
{ message:
   'Response with statusCode "200" for x-ms-example "AvailableScopes" in operation "Reservation_AvailableScopes" is valid.',
  level: '\u001b[32minfo\u001b[39m' }
{ message:
   'Request parameters for x-ms-example "Catalog" in operation "GetCatalog" is valid.',
  level: '\u001b[32minfo\u001b[39m' }
{ '0':
   { code: 'RESPONSE_VALIDATION_ERROR',
     id: 'OAV108',
     message:
      'Found errors in validating the response with statusCode "200" for x-ms-example "Catalog" in operation "GetCatalog".',
     innerErrors:
      [ { code: 'INVALID_RESPONSE_BODY',
          errors:
           [ { code: 'ANY_OF_MISSING',
               params: [],
               message: 'Data does not match any schemas from \'anyOf\'',
               path: [ 2 ],
               title:
                '#/paths/~1subscriptions~1{subscriptionId}~1providers~1Microsoft.Capacity~1catalogs/get/responses/200/schema/items',
               inner:
                [ { code: 'ANY_OF_MISSING',
                    params: [],
                    message: 'Data does not match any schemas from \'anyOf\'',
                    path: [ 2, 'billingPlans' ],
                    title: '#/definitions/Catalog/properties/billingPlans',
                    inner:
                     [ { code: 'INVALID_TYPE',
                         params: [ 'object', 'array' ],
                         message: 'Expected type object but found type array',
                         path: [ 'billingPlans' ],
                         title: '#/definitions/Catalog/properties/billingPlans',
                         description: 'The billing plan options available for this SKU.',
                         position: { line: 739, column: 25 },
                         url:
                          'd:\\git\\github\\azure-rest-api-specs\\specification\\reservations\\resource-manager\\Microsoft.Capacity\\preview\\2019-04-01\\reservations.json',
                         directives: {} },
                       { code: 'INVALID_TYPE',
                         params: [ 'null', 'array' ],
                         message: 'Expected type null but found type array',
                         path: [ 'billingPlans' ],
                         title: '#/definitions/Catalog/properties/billingPlans',
                         position: { line: 739, column: 25 },
                         url:
                          'd:\\git\\github\\azure-rest-api-specs\\specification\\reservations\\resource-manager\\Microsoft.Capacity\\preview\\2019-04-01\\reservations.json',
                         directives: {} } ],
                    position: { line: 739, column: 25 },
                    url:
                     'd:\\git\\github\\azure-rest-api-specs\\specification\\reservations\\resource-manager\\Microsoft.Capacity\\preview\\2019-04-01\\reservations.json',
                    directives: {} },
                  { code: 'INVALID_TYPE',
                    params: [ 'null', 'object' ],
                    message: 'Expected type null but found type object',
                    path: [ 2 ],
                    title:
                     '#/paths/~1subscriptions~1{subscriptionId}~1providers~1Microsoft.Capacity~1catalogs/get/responses/200/schema/items',
                    position: { line: 105, column: 24 },
                    url:
                     'd:\\git\\github\\azure-rest-api-specs\\specification\\reservations\\resource-manager\\Microsoft.Capacity\\preview\\2019-04-01\\reservations.json',
                    directives: {} } ],
               position: { line: 105, column: 24 },
               url:
                'd:\\git\\github\\azure-rest-api-specs\\specification\\reservations\\resource-manager\\Microsoft.Capacity\\preview\\2019-04-01\\reservations.json',
               directives: {} },
             { code: 'ANY_OF_MISSING',
               params: [],
               message: 'Data does not match any schemas from \'anyOf\'',
               path: [ 1 ],
               title:
                '#/paths/~1subscriptions~1{subscriptionId}~1providers~1Microsoft.Capacity~1catalogs/get/responses/200/schema/items',
               inner:
                [ { code: 'ANY_OF_MISSING',
                    params: [],
                    message: 'Data does not match any schemas from \'anyOf\'',
                    path: [ 1, 'billingPlans' ],
                    title: '#/definitions/Catalog/properties/billingPlans',
                    inner:
                     [ { code: 'INVALID_TYPE',
                         params: [ 'object', 'array' ],
                         message: 'Expected type object but found type array',
                         path: [ 'billingPlans' ],
                         title: '#/definitions/Catalog/properties/billingPlans',
                         description: 'The billing plan options available for this SKU.',
                         position: { line: 739, column: 25 },
                         url:
                          'd:\\git\\github\\azure-rest-api-specs\\specification\\reservations\\resource-manager\\Microsoft.Capacity\\preview\\2019-04-01\\reservations.json',
                         directives: {} },
                       { code: 'INVALID_TYPE',
                         params: [ 'null', 'array' ],
                         message: 'Expected type null but found type array',
                         path: [ 'billingPlans' ],
                         title: '#/definitions/Catalog/properties/billingPlans',
                         position: { line: 739, column: 25 },
                         url:
                          'd:\\git\\github\\azure-rest-api-specs\\specification\\reservations\\resource-manager\\Microsoft.Capacity\\preview\\2019-04-01\\reservations.json',
                         directives: {} } ],
                    position: { line: 739, column: 25 },
                    url:
                     'd:\\git\\github\\azure-rest-api-specs\\specification\\reservations\\resource-manager\\Microsoft.Capacity\\preview\\2019-04-01\\reservations.json',
                    directives: {} },
                  { code: 'INVALID_TYPE',
                    params: [ 'null', 'object' ],
                    message: 'Expected type null but found type object',
                    path: [ 1 ],
                    title:
                     '#/paths/~1subscriptions~1{subscriptionId}~1providers~1Microsoft.Capacity~1catalogs/get/responses/200/schema/items',
                    position: { line: 105, column: 24 },
                    url:
                     'd:\\git\\github\\azure-rest-api-specs\\specification\\reservations\\resource-manager\\Microsoft.Capacity\\preview\\2019-04-01\\reservations.json',
                    directives: {} } ],
               position: { line: 105, column: 24 },
               url:
                'd:\\git\\github\\azure-rest-api-specs\\specification\\reservations\\resource-manager\\Microsoft.Capacity\\preview\\2019-04-01\\reservations.json',
               directives: {} } ],
          message: 'Invalid body: Value failed JSON Schema validation',
          path: [] } ] },
  level: '\u001b[31merror\u001b[39m',
  message:
   'Found errors in validating the response with statusCode "200" for x-ms-example "Catalog" in operation "GetCatalog".:\n' }
{ message:
   'Request parameters for x-ms-example "AppliedReservationList" in operation "GetAppliedReservationList" is valid.',
  level: '\u001b[32minfo\u001b[39m' }
{ message:
   'Response with statusCode "200" for x-ms-example "AppliedReservationList" in operation "GetAppliedReservationList" is valid.',
  level: '\u001b[32minfo\u001b[39m' }
{ code: 'REQUEST_VALIDATION_ERROR',
  id: 'OAV109',
  message:
   'Found errors in validating the request for x-ms-example "Purchase" in operation "ReservationOrder_Calculate".:\nFound errors in validating the request for x-ms-example "Purchase" in operation "ReservationOrder_Calculate".',
  innerErrors:
   [ { code: 'INVALID_REQUEST_PARAMETER',
       errors:
        [ { code: 'ANY_OF_MISSING',
            params: [],
            message: 'Data does not match any schemas from \'anyOf\'',
            path: [ 'properties' ],
            title:
             '{"path":["definitions","PurchaseRequest","properties","properties"],"position":{"line":1344,"column":23},"url":"d:\\\\git\\\\github\\\\azure-rest-api-specs\\\\specification\\\\reservations\\\\resource-manager\\\\Microsoft.Capacity\\\\preview\\\\2019-04-01\\\\reservations.json","directives":{}}',
            inner:
             [ { code: 'ANY_OF_MISSING',
                 params: [],
                 message: 'Data does not match any schemas from \'anyOf\'',
                 path: [ 'properties', 'quantity' ],
                 title:
                  '{"path":["definitions","PurchaseRequestProperties","properties","quantity"],"position":{"line":1239,"column":21},"url":"d:\\\\git\\\\github\\\\azure-rest-api-specs\\\\specification\\\\reservations\\\\resource-manager\\\\Microsoft.Capacity\\\\preview\\\\2019-04-01\\\\reservations.json","directives":{}}',
                 inner:
                  [ { code: 'INVALID_FORMAT',
                      params: [ 'int32', '1' ],
                      message: 'Object didn\'t pass validation for format int32: 1',
                      path: [ 'quantity' ],
                      title:
                       '{"path":["definitions","ReservationQuantity"],"position":{"line":1565,"column":28},"url":"d:\\\\git\\\\github\\\\azure-rest-api-specs\\\\specification\\\\reservations\\\\resource-manager\\\\Microsoft.Capacity\\\\preview\\\\2019-04-01\\\\reservations.json","directives":{}}',
                      description:
                       'Quantity of the SKUs that are part of the Reservation. Must be greater than zero.' },
                    { code: 'INVALID_TYPE',
                      params: [ 'integer', 'string' ],
                      message: 'Expected type integer but found type string',
                      path: [ 'quantity' ],
                      title:
                       '{"path":["definitions","ReservationQuantity"],"position":{"line":1565,"column":28},"url":"d:\\\\git\\\\github\\\\azure-rest-api-specs\\\\specification\\\\reservations\\\\resource-manager\\\\Microsoft.Capacity\\\\preview\\\\2019-04-01\\\\reservations.json","directives":{}}',
                      description:
                       'Quantity of the SKUs that are part of the Reservation. Must be greater than zero.' },
                    { code: 'INVALID_TYPE',
                      params: [ 'null', 'string' ],
                      message: 'Expected type null but found type string',
                      path: [ 'quantity' ],
                      title:
                       '{"path":["definitions","PurchaseRequestProperties","properties","quantity"],"position":{"line":1239,"column":21},"url":"d:\\\\git\\\\github\\\\azure-rest-api-specs\\\\specification\\\\reservations\\\\resource-manager\\\\Microsoft.Capacity\\\\preview\\\\2019-04-01\\\\reservations.json","directives":{}}' } ] },
               { code: 'INVALID_TYPE',
                 params: [ 'null', 'object' ],
                 message: 'Expected type null but found type object',
                 path: [ 'properties' ],
                 title:
                  '{"path":["definitions","PurchaseRequest","properties","properties"],"position":{"line":1344,"column":23},"url":"d:\\\\git\\\\github\\\\azure-rest-api-specs\\\\specification\\\\reservations\\\\resource-manager\\\\Microsoft.Capacity\\\\preview\\\\2019-04-01\\\\reservations.json","directives":{}}' } ] } ],
       in: 'body',
       message:
        'Invalid parameter (body): Value failed JSON Schema validation',
       name: 'body',
       path: [ 'parameters', 'body' ],
       schemaPath:
        '#/paths/~1providers~1Microsoft.Capacity~1calculatePrice/post/parameters/1',
       title:
        '{"path":["parameters","body"],"position":{"line":4,"column":13},"url":"d:/git/github/azure-rest-api-specs/specification/reservations/resource-manager/Microsoft.Capacity/preview/2019-04-01/examples/CalculateReservationOrder.json"}' } ],
  level: '\u001b[31merror\u001b[39m' }
{ message:
   'Response with statusCode "200" for x-ms-example "Purchase" in operation "ReservationOrder_Calculate" is valid.',
  level: '\u001b[32minfo\u001b[39m' }
{ message:
   'Request parameters for x-ms-example "ReservationOrderList" in operation "ReservationOrder_List" is valid.',
  level: '\u001b[32minfo\u001b[39m' }
{ message:
   'Response with statusCode "200" for x-ms-example "ReservationOrderList" in operation "ReservationOrder_List" is valid.',
  level: '\u001b[32minfo\u001b[39m' }
{ code: 'REQUEST_VALIDATION_ERROR',
  id: 'OAV109',
  message:
   'Found errors in validating the request for x-ms-example "Purchase" in operation "ReservationOrder_Purchase".:\nFound errors in validating the request for x-ms-example "Purchase" in operation "ReservationOrder_Purchase".',
  innerErrors:
   [ { code: 'INVALID_REQUEST_PARAMETER',
       errors:
        [ { code: 'ANY_OF_MISSING',
            params: [],
            message: 'Data does not match any schemas from \'anyOf\'',
            path: [ 'properties' ],
            title:
             '{"path":["definitions","PurchaseRequest","properties","properties"],"position":{"line":1344,"column":23},"url":"d:\\\\git\\\\github\\\\azure-rest-api-specs\\\\specification\\\\reservations\\\\resource-manager\\\\Microsoft.Capacity\\\\preview\\\\2019-04-01\\\\reservations.json","directives":{}}',
            inner:
             [ { code: 'ANY_OF_MISSING',
                 params: [],
                 message: 'Data does not match any schemas from \'anyOf\'',
                 path: [ 'properties', 'quantity' ],
                 title:
                  '{"path":["definitions","PurchaseRequestProperties","properties","quantity"],"position":{"line":1239,"column":21},"url":"d:\\\\git\\\\github\\\\azure-rest-api-specs\\\\specification\\\\reservations\\\\resource-manager\\\\Microsoft.Capacity\\\\preview\\\\2019-04-01\\\\reservations.json","directives":{}}',
                 inner:
                  [ { code: 'INVALID_FORMAT',
                      params: [ 'int32', '1' ],
                      message: 'Object didn\'t pass validation for format int32: 1',
                      path: [ 'quantity' ],
                      title:
                       '{"path":["definitions","ReservationQuantity"],"position":{"line":1565,"column":28},"url":"d:\\\\git\\\\github\\\\azure-rest-api-specs\\\\specification\\\\reservations\\\\resource-manager\\\\Microsoft.Capacity\\\\preview\\\\2019-04-01\\\\reservations.json","directives":{}}',
                      description:
                       'Quantity of the SKUs that are part of the Reservation. Must be greater than zero.' },
                    { code: 'INVALID_TYPE',
                      params: [ 'integer', 'string' ],
                      message: 'Expected type integer but found type string',
                      path: [ 'quantity' ],
                      title:
                       '{"path":["definitions","ReservationQuantity"],"position":{"line":1565,"column":28},"url":"d:\\\\git\\\\github\\\\azure-rest-api-specs\\\\specification\\\\reservations\\\\resource-manager\\\\Microsoft.Capacity\\\\preview\\\\2019-04-01\\\\reservations.json","directives":{}}',
                      description:
                       'Quantity of the SKUs that are part of the Reservation. Must be greater than zero.' },
                    { code: 'INVALID_TYPE',
                      params: [ 'null', 'string' ],
                      message: 'Expected type null but found type string',
                      path: [ 'quantity' ],
                      title:
                       '{"path":["definitions","PurchaseRequestProperties","properties","quantity"],"position":{"line":1239,"column":21},"url":"d:\\\\git\\\\github\\\\azure-rest-api-specs\\\\specification\\\\reservations\\\\resource-manager\\\\Microsoft.Capacity\\\\preview\\\\2019-04-01\\\\reservations.json","directives":{}}' } ] },
               { code: 'INVALID_TYPE',
                 params: [ 'null', 'object' ],
                 message: 'Expected type null but found type object',
                 path: [ 'properties' ],
                 title:
                  '{"path":["definitions","PurchaseRequest","properties","properties"],"position":{"line":1344,"column":23},"url":"d:\\\\git\\\\github\\\\azure-rest-api-specs\\\\specification\\\\reservations\\\\resource-manager\\\\Microsoft.Capacity\\\\preview\\\\2019-04-01\\\\reservations.json","directives":{}}' } ] } ],
       in: 'body',
       message:
        'Invalid parameter (body): Value failed JSON Schema validation',
       name: 'body',
       path: [ 'parameters', 'body' ],
       schemaPath:
        '#/paths/~1providers~1Microsoft.Capacity~1reservationOrders~1{reservationOrderId}/put/parameters/2',
       title:
        '{"path":["parameters","body"],"position":{"line":5,"column":13},"url":"d:/git/github/azure-rest-api-specs/specification/reservations/resource-manager/Microsoft.Capacity/preview/2019-04-01/examples/PurchaseReservationOrder.json"}' } ],

akning-ms · 2020-08-06T01:52:37Z

Hi @aditink, according to @fengzhou-msft , you are urgent to get this PR merge. so I will suppress modal validation error to help merge first. as example quality is also very important for our downstream CLI tool. pls submit another PR to fix above modal validation failure

updated reservedResourceType

6d2330e

openapi-assignment-bot bot assigned fengzhou-msft Jul 30, 2020

fix space-tab inconsistency

4f9ba85

openapi-sdkautomation bot mentioned this pull request Jul 30, 2020

[AutoPR Microsoft.Azure.Management.Reservations] [Hub Generated] Review request for Microsoft.Capacity to add version preview/2019-04-01 AzureSDKAutomation/azure-sdk-for-net#1460

Closed

fengzhou-msft added the BreakingChangeReviewRequired label Aug 3, 2020

adrianhall added Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 AzureAPIBoardSignedOff and removed BreakingChangeReviewRequired labels Aug 4, 2020

fengzhou-msft approved these changes Aug 5, 2020

View reviewed changes

akning-ms added the SuppressionTrack Track suppression in PR label Aug 6, 2020

akning-ms merged commit 9ea4dc2 into Azure:master Aug 6, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Hub Generated] Review request for Microsoft.Capacity to add version preview/2019-04-01 #10297

[Hub Generated] Review request for Microsoft.Capacity to add version preview/2019-04-01 #10297

aditink commented Jul 30, 2020

openapi-pipeline-app bot commented Jul 30, 2020 •

edited

Loading

azure-pipelines bot commented Jul 30, 2020

openapi-sdkautomation bot commented Jul 30, 2020 •

edited

Loading

openapi-sdkautomation bot commented Jul 30, 2020 •

edited

Loading

openapi-sdkautomation bot commented Jul 30, 2020 •

edited

Loading

openapi-sdkautomation bot commented Jul 30, 2020 •

edited

Loading

openapi-sdkautomation bot commented Jul 30, 2020 •

edited

Loading

openapi-sdkautomation bot commented Jul 30, 2020 •

edited

Loading

openapi-sdkautomation bot commented Jul 30, 2020 •

edited

Loading

azure-pipelines bot commented Jul 30, 2020

openapi-sdkautomation bot commented Jul 30, 2020 •

edited

Loading

azuresdkci commented Jul 30, 2020

fengzhou-msft commented Aug 3, 2020

adrianhall commented Aug 4, 2020

fengzhou-msft commented Aug 5, 2020

azure-pipelines bot commented Aug 5, 2020

fengzhou-msft commented Aug 5, 2020

akning-ms commented Aug 5, 2020

raych1 commented Aug 5, 2020

akning-ms commented Aug 6, 2020

[Hub Generated] Review request for Microsoft.Capacity to add version preview/2019-04-01 #10297

[Hub Generated] Review request for Microsoft.Capacity to add version preview/2019-04-01 #10297

Conversation

aditink commented Jul 30, 2020

Contribution checklist:

ARM API Review Checklist

openapi-pipeline-app bot commented Jul 30, 2020 • edited Loading

[Staging] Swagger Validation Report

azure-pipelines bot commented Jul 30, 2020

openapi-sdkautomation bot commented Jul 30, 2020 • edited Loading

azure-sdk-for-go - Release

openapi-sdkautomation bot commented Jul 30, 2020 • edited Loading

azure-sdk-for-net - Release

openapi-sdkautomation bot commented Jul 30, 2020 • edited Loading

azure-sdk-for-js - Release

openapi-sdkautomation bot commented Jul 30, 2020 • edited Loading

azure-sdk-for-java - Release

openapi-sdkautomation bot commented Jul 30, 2020 • edited Loading

Azure CLI Extension Generation - Release

openapi-sdkautomation bot commented Jul 30, 2020 • edited Loading

azure-sdk-for-python - Release

- Breaking Change detected in SDK

openapi-sdkautomation bot commented Jul 30, 2020 • edited Loading

azure-sdk-for-python-track2 - Release

azure-pipelines bot commented Jul 30, 2020

openapi-sdkautomation bot commented Jul 30, 2020 • edited Loading

Trenton Generation - Release

azuresdkci commented Jul 30, 2020

fengzhou-msft commented Aug 3, 2020

adrianhall commented Aug 4, 2020

fengzhou-msft commented Aug 5, 2020

azure-pipelines bot commented Aug 5, 2020

fengzhou-msft commented Aug 5, 2020

akning-ms commented Aug 5, 2020

raych1 commented Aug 5, 2020

akning-ms commented Aug 6, 2020

openapi-pipeline-app bot commented Jul 30, 2020 •

edited

Loading

openapi-sdkautomation bot commented Jul 30, 2020 •

edited

Loading

openapi-sdkautomation bot commented Jul 30, 2020 •

edited

Loading

openapi-sdkautomation bot commented Jul 30, 2020 •

edited

Loading

openapi-sdkautomation bot commented Jul 30, 2020 •

edited

Loading

openapi-sdkautomation bot commented Jul 30, 2020 •

edited

Loading

openapi-sdkautomation bot commented Jul 30, 2020 •

edited

Loading

openapi-sdkautomation bot commented Jul 30, 2020 •

edited

Loading

openapi-sdkautomation bot commented Jul 30, 2020 •

edited

Loading