Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DataLake]: Update Swagger objects to have proper inheritance #928

Closed
begoldsm opened this issue Feb 11, 2017 · 4 comments
Closed

[DataLake]: Update Swagger objects to have proper inheritance #928

begoldsm opened this issue Feb 11, 2017 · 4 comments
Assignees
@begoldsm
Labels
Data Lake Analytics P1 Service Attention Workflow: This issue is responsible by Azure service team.

Comments

@begoldsm
Copy link
Contributor

Need explicit inheritance for (flow is each lower object is "AllOf" the one above it, in the nested lists)

  • JobInformation

    • BaseJobInformation
    • SubmitJobResponse
    • JobInformation
    • SubmitJobParameters (maybe)

  • Account (adla and adls)

    • ListAccount
    • Account
begoldsm pushed a commit to begoldsm/azure-rest-api-specs that referenced this issue Feb 11, 2017
Unlink example
710f2be 
This is due to github issue:
Azure#928
@begoldsm
Copy link
Contributor Author

@amarzavery can you assign this to me, I can't modify assignees.

olydis pushed a commit that referenced this issue Feb 11, 2017
@begoldsm @olydis
Reorder param to avoid breaking change, add first example for ADL (#927)
0ae749b 
* fix for validation error in ADLA

Remove minimum and add an explanation.

* Initial example for feedback

Please look at this and let me know if this is the right approach

* move firewallallowazureIps to the end

This avoids a param reordering breaking change.

* fix example.

* Unlink example

This is due to github issue:
#928
@kirthik
Copy link
Contributor

kirthik commented Jun 9, 2017

@begoldsm - Could you provide an update on this issue? Is it fixed?

@begoldsm
Copy link
Contributor Author

begoldsm commented Jun 9, 2017

@kirthick this is not yet fixed. This is a nice to have clean up task that will result in a lot of breaking changes to subsequent releases of the sdk. This is requirement is only to make our strict swagger validation tests work so that an object that is returned doesn't have missing "required" properties.

I will sync with PM to prioritize this and reply back here with an eta

@begoldsm begoldsm mentioned this issue Jul 17, 2017
Merged
10 tasks
@begoldsm
Copy link
Contributor Author

@veronicagg and @kirthik this should be resolved by PR #1429 can you confirm and close this if so?

@bsiegel bsiegel added the Service Attention Workflow: This issue is responsible by Azure service team. label Sep 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@begoldsm begoldsm

Labels
Data Lake Analytics P1 Service Attention Workflow: This issue is responsible by Azure service team.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@bsiegel @kirthik @begoldsm @veronicagg