Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[AzureLabs] [APIIssue] Resource creation using POST #4637

Open
ravbhatnagar opened this issue Nov 30, 2018 · 1 comment
Open

[AzureLabs] [APIIssue] Resource creation using POST #4637

ravbhatnagar opened this issue Nov 30, 2018 · 1 comment
Assignees
@praries880
Labels
Lab Services Service Attention Workflow: This issue is responsible by Azure service team.

Comments

@ravbhatnagar
Copy link
Contributor

Create resources using POST API - The resource provider uses the POST method for creating certain types of resources. POSTs are not idempotent and cant be invoked from the template. So, in the case where a school/organization wants to set up the entire lab (achieve the e2e scenario) by using an ARM template, it will not be possible. And moreover, in Azure, creating resources is done using PUTs. And so this makes this service inconsistent with other services in Azure.

  • Adding Users under a lab are modeled as a POST action. It should ideally be modeled as a child resource and modeled as a PUT.
  • Creating a lab under a "labAccount" is modeled as an action instead of a PUT.
    Service team has ACKd to address this in the new API-version.
@ravbhatnagar
Copy link
Contributor Author

#4621

@ravbhatnagar ravbhatnagar mentioned this issue Nov 30, 2018
Merged
5 tasks
@praries880 praries880 added Service Attention Workflow: This issue is responsible by Azure service team. Lab Services labels Dec 5, 2018
mccleanp pushed a commit that referenced this issue Mar 23, 2022
@kceiw
[Hub Generated] Review request for Microsoft.DevAI to add version pre…
7596d22 
…view/2021-02-04-preview (#4637)

* New Swagger Spec File

* New Swagger Example Spec File

* New Readme Config File

* New Azure AZ Readme Config File

* New Azure CLI Readme Config File

* New Go Language Readme Config File

* New Python Language Readme Config File

* New Typescript Language Readme Config File

* New C# Language Readme Config File

* Add Microsoft.DevAI first specification

* update readme.

* Update the swagger

* Update spec.

* Update swagger

* Update spec

* Test flattern properties.

* Update spec.

* Update readme for generating sdk.

* Update the description

* Fix spelling.

* Update the spec.

* Fix issues reported from checks

* Remove the empty schema

* Add a proper dynamic object to getConfig response

* Tweak the spec

* Fix the examples and responses

* fix spelling

* Use the same schema for PUT and GET

* Remove the external ref extension.

* Fix parameter ref and add TrackedResource external ref

- We defined some global parameters but don't reference to them in the
  operations. Now it fixed.
- The example validation complains "location" isn't defined. There is a
  TrackedResource defined in the common-type. Now use that external
  reference and somehow the example validation passed.

* Tweak the swagger file.

* Remove the format from the schema.

- The sdk automation doesn't seem to be able to handle it inside an
  array.

* Not inline the properties.

* Update swagger around machine pool

* Update readme

* fix the path in readme

* update custom words

* Fix style

* Fix styles

* Add description to an enum

* Revert "Update readme"

This reverts commit ef0efda05e79e86ed02b77e77e4fb24d67e7e7f8.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@praries880 praries880

Labels
Lab Services Service Attention Workflow: This issue is responsible by Azure service team.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ravbhatnagar @praries880 @akning-ms