Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy paste error in SystemData Type documentation #12712

Open
LukeSlev opened this issue Jan 28, 2021 · 1 comment
Open

Copy paste error in SystemData Type documentation #12712

LukeSlev opened this issue Jan 28, 2021 · 1 comment
Assignees
Labels
ARM Service Attention Workflow: This issue is responsible by Azure service team.

Comments

@LukeSlev
Copy link
Contributor

When adding SystemData to our new api I came across what seems like a copy paste error for one of the properties of SystemData

"description": "The type of identity that last modified the resource."

According to this doc https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-contracts.md#system-metadata-for-all-azure-resources the description should be different - the timestamp of resource last modification (UTC).

@ghost ghost added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Jan 28, 2021
@PhoenixHe-NV PhoenixHe-NV added ARM Service Attention Workflow: This issue is responsible by Azure service team. labels Jan 29, 2021
@ghost ghost removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Jan 29, 2021
@ghost
Copy link

ghost commented Jan 29, 2021

Thanks for the feedback! We are routing this to the appropriate team for follow-up. cc @armleads-azure.

Issue Details

When adding SystemData to our new api I came across what seems like a copy paste error for one of the properties of SystemData

"description": "The type of identity that last modified the resource."

According to this doc https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-contracts.md#system-metadata-for-all-azure-resources the description should be different - the timestamp of resource last modification (UTC).

Author: LukeSlev
Assignees: PhoenixHe-msft
Labels:

ARM, Service Attention, needs-triage

Milestone: -

jennyhunter-msft added a commit to jennyhunter-msft/azure-rest-api-specs that referenced this issue Feb 4, 2021
In response to Issue Azure#12712, fixing the error in the description of the lastModifiedAt systemData property
akning-ms pushed a commit that referenced this issue Feb 10, 2021
* Fixing error in lastModifiedAt description

In response to Issue #12712, fixing the error in the description of the lastModifiedAt systemData property

* Updated v1 types.json to fix lastModifiedAt typo

Updated the description for lastModifiedAt to address a typo

* Updated lastModifiedAt text for alignment

Updated the lastModifiedAt text to align with other documented sources
mkarmark pushed a commit to mkarmark/azure-rest-api-specs that referenced this issue Jul 21, 2021
* Fixing error in lastModifiedAt description

In response to Issue Azure#12712, fixing the error in the description of the lastModifiedAt systemData property

* Updated v1 types.json to fix lastModifiedAt typo

Updated the description for lastModifiedAt to address a typo

* Updated lastModifiedAt text for alignment

Updated the lastModifiedAt text to align with other documented sources
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ARM Service Attention Workflow: This issue is responsible by Azure service team.
Projects
None yet
Development

No branches or pull requests

3 participants