Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[ADLA] - [BUGFIX] - Adding an innerError field to the JobInnerError o…
…bject recursively (#1627) * Refactoring changes in order to match with Ben's refactoring changes * There is no functional change in this commit * This change is purely for refactoring related to Ben's refactoring changes (which has already been accepted): #1429 * Reordering fields in the example files to match with Ben's refactoring changes * Other minor changes or moving code around * Adding an innerError field to JobInnerError object There can be more levels of the innerError field in an JobInnerError object. There is currently only one level of nesting or innerError. Practically, however, the service returns up to two levels. Thus we made the change below: Currently we have: * JobErrorDetails * JobInnerError Now we have: * JobErrorDetails * JobInnerError * JobInnerSecond * JobInnerThird * Getting rid of JobInnerErrorSecond and JobInnerErrorThird * Getting rid of JobInnerErrorSecond and JobInnerErrorThird in place of a recursive definition * [BUGFIX] - Reverting readOnly for two fields * In this already-merged PR (#1429), Ben made some object-refactoring changes - one of them being to make all the fields in USqlJobProperties read-only as a good design decision. However, by making the fields statistics and debugData read-only, this caused some conflicts in the Powershell code. We need to pan out the design more carefully for these two fields with respect to their associated APIs ("/Jobs/{jobIdentity}/GetDebugDataPath" for the debugData field and "/Jobs/{jobIdentity}/GetStatistics" for the statistics field) before making them read-only. If I do not make the change proposed here, I would have to create two new cmdlets: one for getting the JobDataPath object and another for getting the JobStatistics object, which we do not want to do until we have a better understanding of their designs as a whole. Hence, the reverting change proposed here.
- Loading branch information