SDK review feedback

Azure · Feb 1, 2024 · f08e946 · f08e946
1 parent 0301346
commit f08e946
Show file tree

Hide file tree

Showing 8 changed files with 51 additions and 49 deletions.
diff --git a/custom-words.txt b/custom-words.txt
@@ -1,4 +1,4 @@
-a128cbcpad
+a128cbcpad
 a192cbcpad
 a256cbcpad
 aadds
@@ -3977,4 +3977,3 @@ protobuf
 proto
 msvideo
 SOQL
-Sddc
diff --git a/...ification/eventgrid/data-plane/Microsoft.AVS/preview/2023-09-01-preview/PrivateCloud.json b/...ification/eventgrid/data-plane/Microsoft.AVS/preview/2023-09-01-preview/PrivateCloud.json
@@ -7,147 +7,150 @@
   },
   "paths": {},
   "definitions": {
-    "SddcUpdatingEventData": {
-      "description": "Schema of the Data property of an EventGridEvent for a Microsoft.AVS.SddcUpdating event.",
+    "AvsPrivateCloudUpdatingEventData": {
+      "description": "Schema of the Data property of an EventGridEvent for a Microsoft.AVS.PrivateCloudUpdating event.",
       "type": "object",
       "allOf": [
         {
-          "$ref": "#/definitions/SddcEventProperties"
+          "$ref": "#/definitions/AvsPrivateCloudEventProperties"
         }
       ],
       "properties": {}
     },
-    "SddcUpdatedEventData": {
-      "description": "Schema of the Data property of an EventGridEvent for a Microsoft.AVS.SddcUpdated event.",
+    "AvsPrivateCloudUpdatedEventData": {
+      "description": "Schema of the Data property of an EventGridEvent for a Microsoft.AVS.PrivateCloudUpdated event.",
       "type": "object",
       "allOf": [
         {
-          "$ref": "#/definitions/SddcEventProperties"
+          "$ref": "#/definitions/AvsPrivateCloudEventProperties"
         }
       ],
       "properties": {}
     },
-    "SddcFailedEventData": {
-      "description": "Schema of the Data property of an EventGridEvent for a Microsoft.AVS.SddcFailed event.",
+    "AvsPrivateCloudFailedEventData": {
+      "description": "Schema of the Data property of an EventGridEvent for a Microsoft.AVS.PrivateCloudFailed event.",
       "type": "object",
       "allOf": [
         {
-          "$ref": "#/definitions/SddcEventProperties"
+          "$ref": "#/definitions/AvsPrivateCloudEventProperties"
         }
       ],
       "properties": {
-        "failure": {
+        "failureMessage": {
           "description": "Failure reason of an event.",
           "type": "string"
         }
       }
     },
-    "ClusterCreatedEventData": {
+    "AvsClusterCreatedEventData": {
       "description": "Schema of the Data property of an EventGridEvent for a Microsoft.AVS.ClusterCreated event.",
       "type": "object",
       "allOf": [
         {
-          "$ref": "#/definitions/ClusterEventProperties"
+          "$ref": "#/definitions/AvsClusterEventProperties"
         }
       ],
       "properties": {}
     },
-    "ClusterDeletedEventData": {
+    "AvsClusterDeletedEventData": {
       "description": "Schema of the Data property of an EventGridEvent for a Microsoft.AVS.ClusterDeleted event.",
       "type": "object",
       "allOf": [
         {
-          "$ref": "#/definitions/ClusterEventProperties"
+          "$ref": "#/definitions/AvsClusterEventProperties"
         }
       ],
       "properties": {}
     },
-    "ClusterUpdatingEventData": {
+    "AvsClusterUpdatingEventData": {
       "description": "Schema of the Data property of an EventGridEvent for a Microsoft.AVS.ClusterUpdating event.",
       "type": "object",
       "allOf": [
         {
-          "$ref": "#/definitions/ClusterEventProperties"
+          "$ref": "#/definitions/AvsClusterEventProperties"
         }
       ],
       "properties": {}
     },
-    "ClusterUpdatedEventData": {
+    "AvsClusterUpdatedEventData": {
       "description": "Schema of the Data property of an EventGridEvent for a Microsoft.AVS.ClusterUpdated event.",
       "type": "object",
       "allOf": [
         {
-          "$ref": "#/definitions/ClusterEventProperties"
+          "$ref": "#/definitions/AvsClusterEventProperties"
         }
       ],
       "properties": {}
     },
-    "ClusterFailedEventData": {
+    "AvsClusterFailedEventData": {
       "description": "Schema of the Data property of an EventGridEvent for a Microsoft.AVS.ClusterFailed event.",
       "type": "object",
       "allOf": [
         {
-          "$ref": "#/definitions/ClusterEventProperties"
+          "$ref": "#/definitions/AvsClusterEventProperties"
         }
       ],
       "properties": {
-        "failure": {
+        "failureMessage": {
           "description": "Failure reason of an event.",
           "type": "string"
         }
       }
     },
-    "ScriptExecutionStartedEventData": {
+    "AvsScriptExecutionStartedEventData": {
       "description": "Schema of the Data property of an EventGridEvent for a Microsoft.AVS.ScriptExecutionStarted event.",
       "type": "object",
       "allOf": [
         {
-          "$ref": "#/definitions/ScriptExecutionEventProperties"
+          "$ref": "#/definitions/AvsScriptExecutionEventProperties"
         }
       ],
       "properties": {}
     },
-    "ScriptExecutionFinishedEventData": {
+    "AvsScriptExecutionFinishedEventData": {
       "description": "Schema of the Data property of an EventGridEvent for a Microsoft.AVS.ScriptExecutionFinished event.",
       "type": "object",
       "allOf": [
         {
-          "$ref": "#/definitions/ScriptExecutionEventProperties"
+          "$ref": "#/definitions/AvsScriptExecutionEventProperties"
         }
       ],
       "properties": {
         "namedOutputs": {
           "description": "Named outputs of completed execution, if any.",
-          "type": "object"
+          "type": "object",
+          "items": {
+            "type": "string"
+          }
         }
       }
     },
-    "ScriptExecutionCancelledEventData": {
+    "AvsScriptExecutionCancelledEventData": {
       "description": "Schema of the Data property of an EventGridEvent for a Microsoft.AVS.ScriptExecutionCancelled event.",
       "type": "object",
       "allOf": [
         {
-          "$ref": "#/definitions/ScriptExecutionEventProperties"
+          "$ref": "#/definitions/AvsScriptExecutionEventProperties"
         }
       ],
       "properties": {}
     },
-    "ScriptExecutionFailedEventData": {
+    "AvsScriptExecutionFailedEventData": {
       "description": "Schema of the Data property of an EventGridEvent for a Microsoft.AVS.ScriptExecutionFailed event.",
       "type": "object",
       "allOf": [
         {
-          "$ref": "#/definitions/ScriptExecutionEventProperties"
+          "$ref": "#/definitions/AvsScriptExecutionEventProperties"
         }
       ],
       "properties": {
-        "failure": {
+        "failureMessage": {
           "description": "Failure reason of an event.",
           "type": "string"
         }
       }
     },
-    "SddcEventProperties": {
+    "AvsPrivateCloudEventProperties": {
       "description": "Schema of the Data property of an EventGridEvent for Microsoft.AVS/privateClouds events.",
       "type": "object",
       "properties": {
@@ -157,29 +160,29 @@
         }
       }
     },
-    "ClusterEventProperties": {
+    "AvsClusterEventProperties": {
       "description": "Schema of the Data property of an EventGridEvent for Microsoft.AVS/clusters events.",
       "type": "object",
       "properties": {
         "operationId": {
           "description": "Id of the operation that caused this event.",
           "type": "string"
         },
-        "added": {
+        "addedHostNames": {
           "description": "Hosts added to the cluster in this event, if any.",
           "type": "array",
           "items": {
             "type": "string"
           }
         },
-        "removed": {
+        "removedHostNames": {
           "description": "Hosts removed to the cluster in this event, if any.",
           "type": "array",
           "items": {
             "type": "string"
           }
         },
-        "maintenance": {
+        "inMaintenanceHostNames": {
           "description": "Hosts in Maintenance mode in the cluster, if any.",
           "type": "array",
           "items": {
@@ -188,7 +191,7 @@
         }
       }
     },
-    "ScriptExecutionEventProperties": {
+    "AvsScriptExecutionEventProperties": {
       "description": "Schema of the Data property of an EventGridEvent for Microsoft.AVS/scriptExecutions events.",
       "type": "object",
       "properties": {

diff --git a/...icrosoft.AVS/preview/2023-09-01-preview/examples/cloud-events-schema/cluster_updated.json b/...icrosoft.AVS/preview/2023-09-01-preview/examples/cloud-events-schema/cluster_updated.json
@@ -5,13 +5,13 @@
   "time": "2023-12-09T16:50:19.9995668-05:00",
   "id": "9b87886d-21a5-4af5-8e3e-10c4b8dac73b",
   "data": {
-    "added": [
+    "addedHostNames": [
       "esx17-r04.p01.431cc…"
     ],
-    "removed": [
+    "removedHostNames": [
       "esx15-r01.p01.431cc…"
     ],
-    "maintenance": [
+    "inMaintenanceHostNames": [
       "esx01-r03.p01.431cc…"
     ],
     "operationId": "c8c0b304-2db3-402b-8a6b-06065e0e1755"

diff --git a/...es/cloud-events-schema/sddc_updating.json → ...-events-schema/privatecloud_updating.json b/...es/cloud-events-schema/sddc_updating.json → ...-events-schema/privatecloud_updating.json
@@ -1,7 +1,7 @@
 {
   "source": "/subscriptions/{subscription_id}/resourceGroups/{resource_group_name}/providers/Microsoft.AVS/privateClouds/{sddc_name}",
   "subject": "",
-  "type": "Microsoft.AVS.SddcUpdating",
+  "type": "Microsoft.AVS.PrivateCloudUpdating",
   "time": "2023-12-09T16:50:19.9995668-05:00",
   "id": "9b87886d-21a5-4af5-8e3e-10c4b8dac73b",
   "data": {

diff --git a/....AVS/preview/2023-09-01-preview/examples/cloud-events-schema/script_execution_failed.json b/....AVS/preview/2023-09-01-preview/examples/cloud-events-schema/script_execution_failed.json
@@ -6,7 +6,7 @@
   "id": "9b87886d-21a5-4af5-8e3e-10c4b8dac73b",
   "data": {
     "operationId": "fe1cb595-71c8-47d7-b505-60d39a44d53d",
-    "failure": "05/04/2023 03:15:40 Get-SpbmStoragePolicy SpbmStoragePolicy with name ' RAID-5 FTT-1' was not found using the specified filter(s).",
+    "failureMessage": "05/04/2023 03:15:40 Get-SpbmStoragePolicy SpbmStoragePolicy with name ' RAID-5 FTT-1' was not found using the specified filter(s).",
     "cmdletId": "[email protected]/Set-LocationStoragePolicy",
     "output": []
   },

diff --git a/.../Microsoft.AVS/preview/2023-09-01-preview/examples/event-grid-schema/cluster_updated.json b/.../Microsoft.AVS/preview/2023-09-01-preview/examples/event-grid-schema/cluster_updated.json
@@ -3,13 +3,13 @@
   "eventType": "Microsoft.AVS.ClusterUpdated",
   "topic": "/subscriptions/{subscription_id}/resourceGroups/{resource_group_name}/providers/Microsoft.AVS/privateClouds/{sddc_name}",
   "data": {
-    "added": [
+    "addedHostNames": [
       "esx17-r04.p01.431cc…"
     ],
-    "removed": [
+    "removedHostNames": [
       "esx15-r01.p01.431cc…"
     ],
-    "maintenance": [
+    "inMaintenanceHostNames": [
       "esx01-r03.p01.431cc…"
     ],
     "operationId": "c8c0b304-2db3-402b-8a6b-06065e0e1755"

diff --git a/...ples/event-grid-schema/sddc_updating.json → ...nt-grid-schema/privatecloud_updating.json b/...ples/event-grid-schema/sddc_updating.json → ...nt-grid-schema/privatecloud_updating.json
@@ -1,6 +1,6 @@
 {
   "id": "9b87886d-21a5-4af5-8e3e-10c4b8dac73b",
-  "eventType": "Microsoft.AVS.SddcUpdating",
+  "eventType": "Microsoft.AVS.PrivateCloudUpdating",
   "topic": "/subscriptions/{subscription_id}/resourceGroups/{resource_group_name}/providers/Microsoft.AVS/privateClouds/{sddc_name}",
   "data": {
     "operationId": "6dcd7db8-0679-40d9-bb8a-6f2a684395e2"

diff --git a/...ft.AVS/preview/2023-09-01-preview/examples/event-grid-schema/script_execution_failed.json b/...ft.AVS/preview/2023-09-01-preview/examples/event-grid-schema/script_execution_failed.json
@@ -4,7 +4,7 @@
   "topic": "/subscriptions/{subscription_id}/resourceGroups/{resource_group_name}/providers/Microsoft.AVS/privateClouds/{sddc_name}",
   "data": {
     "operationId": "fe1cb595-71c8-47d7-b505-60d39a44d53d",
-    "failure": "05/04/2023 03:15:40 Get-SpbmStoragePolicy SpbmStoragePolicy with name ' RAID-5 FTT-1' was not found using the specified filter(s).",
+    "failureMessage": "05/04/2023 03:15:40 Get-SpbmStoragePolicy SpbmStoragePolicy with name ' RAID-5 FTT-1' was not found using the specified filter(s).",
     "cmdletId": "[email protected]/Set-LocationStoragePolicy",
     "output": []
   },