Skip to content

Commit

Permalink
Align the casing of LifetimeActionsType with the service. (#24475)
Browse files Browse the repository at this point in the history 
* Align the casing of LifetimeActionsType with the service.

* Add suppressions for EnumUniqueValue

* Fix suppressions YAML

* Move ARM suppressions to right readme.md

---------

Co-authored-by: Heath Stewart <[email protected]>
  • Loading branch information
@adarce @heaths
adarce and heaths authored Aug 24, 2023
1 parent c6c97bb commit c06b7c2
Show file tree
Hide file tree
Showing 26 changed files with 252 additions and 79 deletions.
4 changes: 2 additions & 2 deletions ...a-plane/Microsoft.KeyVault/preview/7.3-preview/examples/GetKeyRotationPolicy-example.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -14,15 +14,15 @@
"timeAfterCreate": "P90D"
},
"action": {
"type": "rotate"
"type": "Rotate"
}
},
{
"trigger": {
"timeBeforeExpiry": "P30D"
},
"action": {
"type": "notify"
"type": "Notify"
}
}
],
Expand Down
8 changes: 4 additions & 4 deletions ...lane/Microsoft.KeyVault/preview/7.3-preview/examples/UpdateKeyRotationPolicy-example.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -10,15 +10,15 @@
"timeAfterCreate": "P90D"
},
"action": {
"type": "rotate"
"type": "Rotate"
}
},
{
"trigger": {
"timeBeforeExpiry": "P30D"
},
"action": {
"type": "notify"
"type": "Notify"
}
}
],
Expand All @@ -37,15 +37,15 @@
"timeAfterCreate": "P90D"
},
"action": {
"type": "rotate"
"type": "Rotate"
}
},
{
"trigger": {
"timeBeforeExpiry": "P30D"
},
"action": {
"type": "notify"
"type": "Notify"
}
}
],
Expand Down
13 changes: 9 additions & 4 deletions specification/keyvault/data-plane/Microsoft.KeyVault/preview/7.3-preview/keys.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -2195,20 +2195,25 @@
"type": "string",
"description": "The type of the action.",
"enum": [
"Rotate",
"rotate",
"notify"
"Notify"
],
"x-ms-enum": {
"name": "ActionType",
"modelAsString": false,
"values": [
{
"value": "Rotate",
"description": "Rotate the key based on the key policy. Key Vault only. Managed HSM uses camelCase 'rotate' instead."
},
{
"value": "rotate",
"description": "Rotate the key based on the key policy."
"description": "Rotate the key based on the key policy. Managed HSM only. Key Vault uses PascalCase 'Rotate' instead."
},
{
"value": "notify",
"description": "Trigger event grid events. For preview, the notification time is not configurable and it is default to 30 days before expiry."
"value": "Notify",
"description": "Trigger Event Grid events. Defaults to 30 days before expiry. Key Vault only."
}
]
}
Expand Down
4 changes: 2 additions & 2 deletions ...plane/Microsoft.KeyVault/preview/7.4-preview.1/examples/GetKeyRotationPolicy-example.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -14,15 +14,15 @@
"timeAfterCreate": "P90D"
},
"action": {
"type": "rotate"
"type": "Rotate"
}
},
{
"trigger": {
"timeBeforeExpiry": "P30D"
},
"action": {
"type": "notify"
"type": "Notify"
}
}
],
Expand Down
8 changes: 4 additions & 4 deletions ...ne/Microsoft.KeyVault/preview/7.4-preview.1/examples/UpdateKeyRotationPolicy-example.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -10,15 +10,15 @@
"timeAfterCreate": "P90D"
},
"action": {
"type": "rotate"
"type": "Rotate"
}
},
{
"trigger": {
"timeBeforeExpiry": "P30D"
},
"action": {
"type": "notify"
"type": "Notify"
}
}
],
Expand All @@ -37,15 +37,15 @@
"timeAfterCreate": "P90D"
},
"action": {
"type": "rotate"
"type": "Rotate"
}
},
{
"trigger": {
"timeBeforeExpiry": "P30D"
},
"action": {
"type": "notify"
"type": "Notify"
}
}
],
Expand Down
13 changes: 9 additions & 4 deletions specification/keyvault/data-plane/Microsoft.KeyVault/preview/7.4-preview.1/keys.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -2223,20 +2223,25 @@
"type": "string",
"description": "The type of the action.",
"enum": [
"Rotate",
"rotate",
"notify"
"Notify"
],
"x-ms-enum": {
"name": "ActionType",
"modelAsString": false,
"values": [
{
"value": "Rotate",
"description": "Rotate the key based on the key policy. Key Vault only. Managed HSM uses camelCase 'rotate' instead."
},
{
"value": "rotate",
"description": "Rotate the key based on the key policy."
"description": "Rotate the key based on the key policy. Managed HSM only. Key Vault uses PascalCase 'Rotate' instead."
},
{
"value": "notify",
"description": "Trigger event grid events. For preview, the notification time is not configurable and it is default to 30 days before expiry."
"value": "Notify",
"description": "Trigger Event Grid events. Defaults to 30 days before expiry. Key Vault only."
}
]
}
Expand Down
4 changes: 2 additions & 2 deletions ...plane/Microsoft.KeyVault/preview/7.5-preview.1/examples/GetKeyRotationPolicy-example.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -14,15 +14,15 @@
"timeAfterCreate": "P90D"
},
"action": {
"type": "rotate"
"type": "Rotate"
}
},
{
"trigger": {
"timeBeforeExpiry": "P30D"
},
"action": {
"type": "notify"
"type": "Notify"
}
}
],
Expand Down
8 changes: 4 additions & 4 deletions ...ne/Microsoft.KeyVault/preview/7.5-preview.1/examples/UpdateKeyRotationPolicy-example.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -10,15 +10,15 @@
"timeAfterCreate": "P90D"
},
"action": {
"type": "rotate"
"type": "Rotate"
}
},
{
"trigger": {
"timeBeforeExpiry": "P30D"
},
"action": {
"type": "notify"
"type": "Notify"
}
}
],
Expand All @@ -37,15 +37,15 @@
"timeAfterCreate": "P90D"
},
"action": {
"type": "rotate"
"type": "Rotate"
}
},
{
"trigger": {
"timeBeforeExpiry": "P30D"
},
"action": {
"type": "notify"
"type": "Notify"
}
}
],
Expand Down
15 changes: 10 additions & 5 deletions specification/keyvault/data-plane/Microsoft.KeyVault/preview/7.5-preview.1/keys.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -2201,20 +2201,25 @@
"type": "string",
"description": "The type of the action.",
"enum": [
"Rotate",
"rotate",
"notify"
"Notify"
],
"x-ms-enum": {
"name": "KeyRotationPolicyAction",
"name": "ActionType",
"modelAsString": false,
"values": [
{
"value": "Rotate",
"description": "Rotate the key based on the key policy. Key Vault only. Managed HSM uses camelCase 'rotate' instead."
},
{
"value": "rotate",
"description": "Rotate the key based on the key policy."
"description": "Rotate the key based on the key policy. Managed HSM only. Key Vault uses PascalCase 'Rotate' instead."
},
{
"value": "notify",
"description": "Trigger event grid events. For preview, the notification time is not configurable and it is default to 30 days before expiry."
"value": "Notify",
"description": "Trigger Event Grid events. Defaults to 30 days before expiry. Key Vault only."
}
]
}
Expand Down
4 changes: 2 additions & 2 deletions ...vault/data-plane/Microsoft.KeyVault/stable/7.3/examples/GetKeyRotationPolicy-example.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -14,15 +14,15 @@
"timeAfterCreate": "P90D"
},
"action": {
"type": "rotate"
"type": "Rotate"
}
},
{
"trigger": {
"timeBeforeExpiry": "P30D"
},
"action": {
"type": "notify"
"type": "Notify"
}
}
],
Expand Down
8 changes: 4 additions & 4 deletions ...lt/data-plane/Microsoft.KeyVault/stable/7.3/examples/UpdateKeyRotationPolicy-example.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -10,15 +10,15 @@
"timeAfterCreate": "P90D"
},
"action": {
"type": "rotate"
"type": "Rotate"
}
},
{
"trigger": {
"timeBeforeExpiry": "P30D"
},
"action": {
"type": "notify"
"type": "Notify"
}
}
],
Expand All @@ -37,15 +37,15 @@
"timeAfterCreate": "P90D"
},
"action": {
"type": "rotate"
"type": "Rotate"
}
},
{
"trigger": {
"timeBeforeExpiry": "P30D"
},
"action": {
"type": "notify"
"type": "Notify"
}
}
],
Expand Down
13 changes: 9 additions & 4 deletions specification/keyvault/data-plane/Microsoft.KeyVault/stable/7.3/keys.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -2196,20 +2196,25 @@
"type": "string",
"description": "The type of the action.",
"enum": [
"Rotate",
"rotate",
"notify"
"Notify"
],
"x-ms-enum": {
"name": "ActionType",
"modelAsString": false,
"values": [
{
"value": "Rotate",
"description": "Rotate the key based on the key policy. Key Vault only. Managed HSM uses camelCase 'rotate' instead."
},
{
"value": "rotate",
"description": "Rotate the key based on the key policy."
"description": "Rotate the key based on the key policy. Managed HSM only. Key Vault uses PascalCase 'Rotate' instead."
},
{
"value": "notify",
"description": "Trigger event grid events. For preview, the notification time is not configurable and it is default to 30 days before expiry."
"value": "Notify",
"description": "Trigger Event Grid events. Defaults to 30 days before expiry. Key Vault only."
}
]
}
Expand Down
4 changes: 2 additions & 2 deletions ...vault/data-plane/Microsoft.KeyVault/stable/7.4/examples/GetKeyRotationPolicy-example.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -14,15 +14,15 @@
"timeAfterCreate": "P90D"
},
"action": {
"type": "rotate"
"type": "Rotate"
}
},
{
"trigger": {
"timeBeforeExpiry": "P30D"
},
"action": {
"type": "notify"
"type": "Notify"
}
}
],
Expand Down
8 changes: 4 additions & 4 deletions ...lt/data-plane/Microsoft.KeyVault/stable/7.4/examples/UpdateKeyRotationPolicy-example.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -10,15 +10,15 @@
"timeAfterCreate": "P90D"
},
"action": {
"type": "rotate"
"type": "Rotate"
}
},
{
"trigger": {
"timeBeforeExpiry": "P30D"
},
"action": {
"type": "notify"
"type": "Notify"
}
}
],
Expand All @@ -37,15 +37,15 @@
"timeAfterCreate": "P90D"
},
"action": {
"type": "rotate"
"type": "Rotate"
}
},
{
"trigger": {
"timeBeforeExpiry": "P30D"
},
"action": {
"type": "notify"
"type": "Notify"
}
}
],
Expand Down
Loading

0 comments on commit c06b7c2

Please sign in to comment.