Skip to content

Commit

Permalink
fix Nsp link properties description (#27601)
Browse files Browse the repository at this point in the history
* fix link spec

* updated examples

* fix pretty
  • Loading branch information
vineetmimrot authored Feb 5, 2024
1 parent 4948660 commit b72d96e
Show file tree
Hide file tree
Showing 4 changed files with 26 additions and 14 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,13 @@
"linkName": "link1",
"parameters": {
"properties": {
"autoApprovedRemotePerimeterResourceId": "/subscriptions/subId/resourceGroups/rg1/providers/Microsoft.Network/networkSecurityPerimeters/nsp2"
"autoApprovedRemotePerimeterResourceId": "/subscriptions/subId/resourceGroups/rg1/providers/Microsoft.Network/networkSecurityPerimeters/nsp2",
"localInboundProfiles": [
"*"
],
"remoteInboundProfiles": [
"*"
]
}
}
},
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1810,7 +1810,7 @@
"items": {
"type": "string"
},
"description": "Local Inbound profile names to which Inbound is allowed. Use ['*'] to allow inbound to all profiles. It's default value is ['*'].",
"description": "Local Inbound profile names to which Inbound is allowed. Use ['*'] to allow inbound to all profiles.",
"uniqueItems": true
},
"localOutboundProfiles": {
Expand All @@ -1827,7 +1827,7 @@
"items": {
"type": "string"
},
"description": "Remote Inbound profile names to which Inbound is allowed. Use ['*'] to allow inbound to all profiles. This property can only be updated in auto-approval mode. It's default value is ['*'].",
"description": "Remote Inbound profile names to which Inbound is allowed. Use ['*'] to allow inbound to all profiles. This property can only be updated in auto-approval mode.",
"uniqueItems": true
},
"remoteOutboundProfiles": {
Expand Down Expand Up @@ -1922,7 +1922,7 @@
"items": {
"type": "string"
},
"description": "Local Inbound profile names to which Inbound is allowed. Use ['*'] to allow inbound to all profiles. It's default value is ['*'].",
"description": "Local Inbound profile names to which Inbound is allowed. Use ['*'] to allow inbound to all profiles.",
"uniqueItems": true
},
"localOutboundProfiles": {
Expand All @@ -1931,7 +1931,7 @@
"type": "string"
},
"readOnly": true,
"description": "Local Outbound profile names from which Outbound is allowed. Use ['*'] to allow outbound from all profiles. It's default value is ['*'].",
"description": "Local Outbound profile names from which Outbound is allowed. In current version, it is readonly property and it's value is set to ['*'] to allow outbound from all profiles. In later version, user will be able to modify it.",
"uniqueItems": true
},
"remoteInboundProfiles": {
Expand All @@ -1940,15 +1940,15 @@
"type": "string"
},
"readOnly": true,
"description": "Remote Inbound profile names to which Inbound is allowed. ['*'] value implies inbound is allowed to all profiles at remote perimeter. This property can only be updated from remote perimeter."
"description": "Remote Inbound profile names to which Inbound is allowed. ['*'] value implies inbound is allowed to all profiles at remote perimeter. This property can only be updated from corresponding link resource present in remote perimeter."
},
"remoteOutboundProfiles": {
"type": "array",
"items": {
"type": "string"
},
"readOnly": true,
"description": "Remote Outbound profile names from which Outbound is allowed. ['*'] value implies outbound is allowed from all profiles at remote perimeter. This property can only be updated from remote perimeter."
"description": "Remote Outbound profile names from which Outbound is allowed. ['*'] value implies outbound is allowed from all profiles at remote perimeter. This property can only be updated from corresponding link resource present in remote perimeter."
},
"description": {
"type": "string",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,13 @@
"linkName": "link1",
"parameters": {
"properties": {
"autoApprovedRemotePerimeterResourceId": "/subscriptions/subId/resourceGroups/rg1/providers/Microsoft.Network/networkSecurityPerimeters/nsp2"
"autoApprovedRemotePerimeterResourceId": "/subscriptions/subId/resourceGroups/rg1/providers/Microsoft.Network/networkSecurityPerimeters/nsp2",
"localInboundProfiles": [
"*"
],
"remoteInboundProfiles": [
"*"
]
}
}
},
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1817,7 +1817,7 @@
"items": {
"type": "string"
},
"description": "Local Inbound profile names to which Inbound is allowed. Use ['*'] to allow inbound to all profiles. It's default value is ['*'].",
"description": "Local Inbound profile names to which Inbound is allowed. Use ['*'] to allow inbound to all profiles.",
"uniqueItems": true
},
"localOutboundProfiles": {
Expand All @@ -1834,7 +1834,7 @@
"items": {
"type": "string"
},
"description": "Remote Inbound profile names to which Inbound is allowed. Use ['*'] to allow inbound to all profiles. This property can only be updated in auto-approval mode. It's default value is ['*'].",
"description": "Remote Inbound profile names to which Inbound is allowed. Use ['*'] to allow inbound to all profiles. This property can only be updated in auto-approval mode.",
"uniqueItems": true
},
"remoteOutboundProfiles": {
Expand Down Expand Up @@ -1929,7 +1929,7 @@
"items": {
"type": "string"
},
"description": "Local Inbound profile names to which Inbound is allowed. Use ['*'] to allow inbound to all profiles. It's default value is ['*'].",
"description": "Local Inbound profile names to which Inbound is allowed. Use ['*'] to allow inbound to all profiles.",
"uniqueItems": true
},
"localOutboundProfiles": {
Expand All @@ -1938,7 +1938,7 @@
"type": "string"
},
"readOnly": true,
"description": "Local Outbound profile names from which Outbound is allowed. Use ['*'] to allow outbound from all profiles. It's default value is ['*'].",
"description": "Local Outbound profile names from which Outbound is allowed. In current version, it is readonly property and it's value is set to ['*'] to allow outbound from all profiles. In later version, user will be able to modify it.",
"uniqueItems": true
},
"remoteInboundProfiles": {
Expand All @@ -1947,15 +1947,15 @@
"type": "string"
},
"readOnly": true,
"description": "Remote Inbound profile names to which Inbound is allowed. ['*'] value implies inbound is allowed to all profiles at remote perimeter. This property can only be updated from remote perimeter."
"description": "Remote Inbound profile names to which Inbound is allowed. ['*'] value implies inbound is allowed to all profiles at remote perimeter. This property can only be updated from corresponding link resource present in remote perimeter."
},
"remoteOutboundProfiles": {
"type": "array",
"items": {
"type": "string"
},
"readOnly": true,
"description": "Remote Outbound profile names from which Outbound is allowed. ['*'] value implies outbound is allowed from all profiles at remote perimeter. This property can only be updated from remote perimeter."
"description": "Remote Outbound profile names from which Outbound is allowed. ['*'] value implies outbound is allowed from all profiles at remote perimeter. This property can only be updated from corresponding link resource present in remote perimeter."
},
"description": {
"type": "string",
Expand Down

0 comments on commit b72d96e

Please sign in to comment.