Skip to content

Commit

Permalink
[Hub Generated] Review request for Microsoft.Migrate/AssessmentProjec…
Browse files Browse the repository at this point in the history 
…ts to add version preview/2023-04-01-preview (#26489)

* Adds base for updating Microsoft.Migrate/AssessmentProjects from version stable/2023-03-15 to version 2023-04-01-preview

* Updates readme

* Updates API version in new specs and examples

* 1. Microsoft.Migrate 2023-04-01-preview swagger - Initial commit

* 1. Added Business case examples

* 1. Prettier check on examples

* 1. Swagger json Prettier fix

* 1. Added WebAppV2 examples

* 1. Renaming Web App file names

* 1. Adding examples for WebAppV2 and AKS

* 1. Fixed swagger and examples for Business case

* 1. Updated bcs swagger and examples

* 1. Added resourceId in Business case list

* 1. Fixed custom words

* 1. Resolve spellcheck

* 1. Fix model validation check for Business case

* 1. Added custom words

* Fix Model Validation Errors for AKS

* updated few examples

* Update WebAppAssessmentOptionsOperations_ListByAssessmentProject_MaximumSet_Gen.json

Updated webAppAssessmentOptions

* Add and Update AKS Swagger Examples

* Update Swagger File with Latest Changes

* Fix Prettier Check

* Updating examples

* update

* 1. Updated swagger

* 1. Moved to types version v5

* 1. Fixed Business case validation for Get and Create

* 1. Updated Business case Delete to sync operation

* 1. Updated Business case delete response code in examples

* Fix Prettier Check

* 1. Added AKS changes in swagger

* 1. Fixed prettier check in swagger

* Fix Model Validation Errors for AKS

* 1. Updated AVSOnly

* 1. Reverted custome-words.txt. This change needs to be taken right before activating the PR

* 1. Model validation fixes for previous version

* 1. Updated PrivateEndpointConnections examples

* 1. Updated PE fix

* 1. Updated PE examples

* 1. Fixed Hotfix changes from previous version

* 1. Fixed version typo

* 1. Fixed Duplicate Key issue

* Update Swagger with POS Core and AKS Changes

* Add visibility read to Immutable Models in AKS and POS Core Swagger

* Fix Model Validation Errors for AKS

* 1. Updated custom-words list for spellcheck

* 1. Added custom word

* 1. Linux Ahub changes

* 1. Fixed prettier check

* 1. Updated businesscases to camelCase

* 1. Updated swagger to use the same enum for Ahub

* 1. Updated links from v4 to v5

* 1. Resolved custom-words conflict

* update comments

* update

* Update description for readonly properties for AKS

* 1. Resolve ProvisioningState readonly issues

* 1. Resolve ProxyResource readonly issue

* Update Swagger with Latest Changes from AKS

* Update PUT AKS Example

* 1. Custom-words update

* 1. Added lint suppressions

* 1. Fixed indentation issue in readme

* 1. Edited Readme

* 1. Updated Readme

* 1. Fixed Lintdiff

* 1. Manually adding provisioningState at the resource property level

* 1. Reverting the manual addition for readOnly in provisioningState

* 1. Typespec generated provisioningState resolution

* 1. Updated provisioningState and example

* 1. Updated WebAppAssessmentV2 Create example to remove provisioningState in PUT call

* 1. Updated WebAppCollector to use provisioningState readonly

* 1. Updated WebAppCollectorOperations_Create_MaximumSet_Gen

* 1. Removed unused model from Swagger

* 1. Remove suppression check

* 1. Applied suppression for AvoidAdditionalProperties
2. Fixed camelCasing in examples

* 1. Removed custom words

* 1. Updated description for POS

* 1. Changed location modelling from Enum to string.

* 1. Updated camelCasing
2. Updated cSpell.json
3. Updated custom-words.txt

* 1. Fixed descriptions

---------

Co-authored-by: Kushal Mehrotra <[email protected]>
Co-authored-by: Umesh Yadav <[email protected]>
Co-authored-by: Tanvi Dhope <[email protected]>
Co-authored-by: tanvidhope-microsoft <[email protected]>
  • Loading branch information
@kushalmehrotra713 @kumehrot
@umeshyadav-msft @tanvidhope-microsoft
5 people authored Feb 5, 2024
1 parent a1d3891 commit a9b45c2
Show file tree
Hide file tree
Showing 134 changed files with 45,847 additions and 2 deletions.
3 changes: 2 additions & 1 deletion cSpell.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -424,7 +424,8 @@
"idms",
"Idms",
"Cluter",
"Mfamily"
"Mfamily",
"Datacentre"
]
},
{
Expand Down
12 changes: 11 additions & 1 deletion custom-words.txt
View file
Original file line number Diff line number Diff line change
Expand Up @@ -3981,4 +3981,14 @@ SOQL
retroperitoneal
codeable
telehealth
loinc
loinc
wacc
hyperthread
Hyperthread
Capex
capex
Opex
opex
decomission
Decommisioned
Decommision
146 changes: 146 additions & 0 deletions ...ts/preview/2023-04-01-preview/examples/AksAssessmentOperations_Create_MaximumSet_Gen.json
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1,146 @@
{
"title": "AksAssessmentOperations_Create",
"operationId": "AksAssessmentOperations_Create",
"parameters": {
"api-version": "2023-04-01-preview",
"subscriptionId": "D6F60DF4-CE70-4E39-8217-B8FBE7CA85AA",
"resourceGroupName": "rgaksswagger",
"projectName": "testproject",
"assessmentName": "testaksassessment",
"resource": {
"properties": {
"settings": {
"category": "All",
"savingsOptions": "None",
"consolidation": "Full",
"pricingTier": "Standard",
"azureLocation": "Unknown",
"environmentType": "Unknown",
"licensingProgram": "Default",
"currency": "Unknown",
"discountPercentage": 15,
"sizingCriteria": "PerformanceBased",
"performanceData": {
"timeRange": "Day",
"perfDataStartTime": "2023-11-07T06:51:24.320Z",
"perfDataEndTime": "2023-11-07T06:51:24.320Z",
"percentile": "Percentile50"
},
"scalingFactor": 3
},
"scope": {
"serverGroupId": "/subscriptions/D6F60DF4-CE70-4E39-8217-B8FBE7CA85AA/resourceGroups/rgaksswagger/providers/Microsoft.Migrate/assessmentProjects/testproject/groups/testgrp"
}
}
}
},
"responses": {
"200": {
"body": {
"properties": {
"settings": {
"category": "All",
"savingsOptions": "None",
"consolidation": "Full",
"pricingTier": "Standard",
"azureLocation": "Unknown",
"environmentType": "Unknown",
"licensingProgram": "Default",
"currency": "Unknown",
"discountPercentage": 15,
"sizingCriteria": "PerformanceBased",
"performanceData": {
"timeRange": "Day",
"perfDataStartTime": "2023-11-07T06:51:24.320Z",
"perfDataEndTime": "2023-11-07T06:51:24.320Z",
"percentile": "Percentile50"
},
"scalingFactor": 3
},
"details": {
"webAppCount": 25,
"webServerCount": 29,
"machineCount": 15,
"totalMonthlyCost": 1,
"pricesTimestamp": "2023-11-07T06:51:24.320Z",
"confidenceRatingInPercentage": 1,
"createdTimestamp": "2023-11-07T06:51:24.320Z",
"updatedTimestamp": "2023-11-07T06:51:24.320Z",
"status": "Created"
},
"scope": {
"serverGroupId": "/subscriptions/D6F60DF4-CE70-4E39-8217-B8FBE7CA85AA/resourceGroups/rgaksswagger/providers/Microsoft.Migrate/assessmentProjects/testproject/groups/testgrp"
},
"provisioningState": "Unknown"
},
"eTag": "00000000-0000-0000-a616-12d4724c01d9",
"id": "/subscriptions/D6F60DF4-CE70-4E39-8217-B8FBE7CA85AA/resourceGroups/rgaksswagger/providers/Microsoft.Migrate/assessmentProjects/testproject/aksAssessments/testaksassessment",
"name": "testaksassessment",
"type": "AKSAssessment",
"systemData": {
"createdBy": "User",
"createdByType": "User",
"createdAt": "2023-11-07T06:51:24.108Z",
"lastModifiedBy": "User",
"lastModifiedByType": "User",
"lastModifiedAt": "2023-11-07T06:51:24.108Z"
}
}
},
"201": {
"headers": {
"Azure-AsyncOperation": "https://contoso.com/operationstatus"
},
"body": {
"properties": {
"settings": {
"category": "All",
"savingsOptions": "None",
"consolidation": "Full",
"pricingTier": "Standard",
"azureLocation": "Unknown",
"environmentType": "Unknown",
"licensingProgram": "Default",
"currency": "Unknown",
"discountPercentage": 15,
"sizingCriteria": "PerformanceBased",
"performanceData": {
"timeRange": "Day",
"perfDataStartTime": "2023-11-07T06:51:24.320Z",
"perfDataEndTime": "2023-11-07T06:51:24.320Z",
"percentile": "Percentile50"
},
"scalingFactor": 3
},
"details": {
"webAppCount": 25,
"webServerCount": 29,
"machineCount": 15,
"totalMonthlyCost": 1,
"pricesTimestamp": "2023-11-07T06:51:24.320Z",
"confidenceRatingInPercentage": 1,
"createdTimestamp": "2023-11-07T06:51:24.320Z",
"updatedTimestamp": "2023-11-07T06:51:24.320Z",
"status": "Created"
},
"scope": {
"serverGroupId": "/subscriptions/D6F60DF4-CE70-4E39-8217-B8FBE7CA85AA/resourceGroups/rgaksswagger/providers/Microsoft.Migrate/assessmentProjects/testproject/groups/testgrp"
},
"provisioningState": "Unknown"
},
"eTag": "00000000-0000-0000-a616-12d4724c01d9",
"id": "/subscriptions/D6F60DF4-CE70-4E39-8217-B8FBE7CA85AA/resourceGroups/rgaksswagger/providers/Microsoft.Migrate/assessmentProjects/testproject/aksAssessments/testaksassessment",
"name": "testaksassessment",
"type": "AKSAssessment",
"systemData": {
"createdBy": "User",
"createdByType": "User",
"createdAt": "2023-11-07T06:51:24.108Z",
"lastModifiedBy": "User",
"lastModifiedByType": "User",
"lastModifiedAt": "2023-11-07T06:51:24.108Z"
}
}
}
}
}
15 changes: 15 additions & 0 deletions ...ts/preview/2023-04-01-preview/examples/AksAssessmentOperations_Delete_MaximumSet_Gen.json
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
{
"title": "AksAssessmentOperations_Delete",
"operationId": "AksAssessmentOperations_Delete",
"parameters": {
"api-version": "2023-04-01-preview",
"subscriptionId": "D6F60DF4-CE70-4E39-8217-B8FBE7CA85AA",
"resourceGroupName": "rgaksswagger",
"projectName": "testproject",
"assessmentName": "testaksassessment"
},
"responses": {
"200": {},
"204": {}
}
}
25 changes: 25 additions & 0 deletions ...eview/2023-04-01-preview/examples/AksAssessmentOperations_DownloadUrl_MaximumSet_Gen.json
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
{
"title": "AksAssessmentOperations_DownloadUrl",
"operationId": "AksAssessmentOperations_DownloadUrl",
"parameters": {
"api-version": "2023-04-01-preview",
"subscriptionId": "D6F60DF4-CE70-4E39-8217-B8FBE7CA85AA",
"resourceGroupName": "rgaksswagger",
"projectName": "testproject",
"assessmentName": "testaksassessment",
"body": {}
},
"responses": {
"200": {
"body": {
"assessmentReportUrl": "vthjjfdenyh",
"expirationTime": "2023-11-07T06:51:25.205Z"
}
},
"202": {
"headers": {
"location": "https://contoso.com/operationstatus"
}
}
}
}
65 changes: 65 additions & 0 deletions ...jects/preview/2023-04-01-preview/examples/AksAssessmentOperations_Get_MaximumSet_Gen.json
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1,65 @@
{
"title": "AksAssessmentOperations_Get",
"operationId": "AksAssessmentOperations_Get",
"parameters": {
"api-version": "2023-04-01-preview",
"subscriptionId": "D6F60DF4-CE70-4E39-8217-B8FBE7CA85AA",
"resourceGroupName": "rgaksswagger",
"projectName": "testproject",
"assessmentName": "testaksassessment"
},
"responses": {
"200": {
"body": {
"properties": {
"settings": {
"category": "All",
"savingsOptions": "None",
"consolidation": "Full",
"pricingTier": "Standard",
"azureLocation": "Unknown",
"environmentType": "Unknown",
"licensingProgram": "Default",
"currency": "Unknown",
"discountPercentage": 15,
"sizingCriteria": "PerformanceBased",
"performanceData": {
"timeRange": "Day",
"perfDataStartTime": "2023-11-07T06:51:24.320Z",
"perfDataEndTime": "2023-11-07T06:51:24.320Z",
"percentile": "Percentile50"
},
"scalingFactor": 3
},
"details": {
"webAppCount": 25,
"webServerCount": 29,
"machineCount": 15,
"totalMonthlyCost": 1,
"pricesTimestamp": "2023-11-07T06:51:24.320Z",
"confidenceRatingInPercentage": 1,
"createdTimestamp": "2023-11-07T06:51:24.320Z",
"updatedTimestamp": "2023-11-07T06:51:24.320Z",
"status": "Created"
},
"scope": {
"serverGroupId": "/subscriptions/D6F60DF4-CE70-4E39-8217-B8FBE7CA85AA/resourceGroups/rgaksswagger/providers/Microsoft.Migrate/assessmentProjects/testproject/groups/testgrp"
},
"provisioningState": "Unknown"
},
"eTag": "00000000-0000-0000-a616-12d4724c01d9",
"id": "/subscriptions/D6F60DF4-CE70-4E39-8217-B8FBE7CA85AA/resourceGroups/rgaksswagger/providers/Microsoft.Migrate/assessmentProjects/testproject/aksAssessments/testaksassessment",
"name": "testaksassessment",
"type": "AKSAssessment",
"systemData": {
"createdBy": "User",
"createdByType": "User",
"createdAt": "2023-11-07T06:51:24.108Z",
"lastModifiedBy": "User",
"lastModifiedByType": "User",
"lastModifiedAt": "2023-11-07T06:51:24.108Z"
}
}
}
}
}
73 changes: 73 additions & 0 deletions ...4-01-preview/examples/AksAssessmentOperations_ListByAssessmentProject_MaximumSet_Gen.json
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1,73 @@
{
"title": "AksAssessmentOperations_ListByAssessmentProject",
"operationId": "AksAssessmentOperations_ListByAssessmentProject",
"parameters": {
"api-version": "2023-04-01-preview",
"subscriptionId": "D6F60DF4-CE70-4E39-8217-B8FBE7CA85AA",
"resourceGroupName": "rgaksswagger",
"continuationToken": "polt",
"$top": 5,
"$filter": "azekdtdhupdngbqxzdppicwf",
"totalRecordCount": 18,
"projectName": "testproject"
},
"responses": {
"200": {
"body": {
"value": [
{
"properties": {
"settings": {
"category": "All",
"savingsOptions": "None",
"consolidation": "Full",
"pricingTier": "Standard",
"azureLocation": "Unknown",
"environmentType": "Unknown",
"licensingProgram": "Default",
"currency": "Unknown",
"discountPercentage": 15,
"sizingCriteria": "PerformanceBased",
"performanceData": {
"timeRange": "Day",
"perfDataStartTime": "2023-11-07T06:51:24.320Z",
"perfDataEndTime": "2023-11-07T06:51:24.320Z",
"percentile": "Percentile50"
},
"scalingFactor": 3
},
"details": {
"webAppCount": 25,
"webServerCount": 29,
"machineCount": 15,
"totalMonthlyCost": 1,
"pricesTimestamp": "2023-11-07T06:51:24.320Z",
"confidenceRatingInPercentage": 1,
"createdTimestamp": "2023-11-07T06:51:24.320Z",
"updatedTimestamp": "2023-11-07T06:51:24.320Z",
"status": "Created"
},
"scope": {
"serverGroupId": "/subscriptions/D6F60DF4-CE70-4E39-8217-B8FBE7CA85AA/resourceGroups/rgaksswagger/providers/Microsoft.Migrate/assessmentProjects/testproject/groups/testgrp"
},
"provisioningState": "Unknown"
},
"eTag": "00000000-0000-0000-a616-12d4724c01d9",
"id": "/subscriptions/D6F60DF4-CE70-4E39-8217-B8FBE7CA85AA/resourceGroups/rgaksswagger/providers/Microsoft.Migrate/assessmentProjects/testproject/aksAssessments/testaksassessment",
"name": "testaksassessment",
"type": "AKSAssessment",
"systemData": {
"createdBy": "User",
"createdByType": "User",
"createdAt": "2023-11-07T06:51:24.108Z",
"lastModifiedBy": "User",
"lastModifiedByType": "User",
"lastModifiedAt": "2023-11-07T06:51:24.108Z"
}
}
],
"nextLink": "https://microsoft.com/a"
}
}
}
}
Loading

0 comments on commit a9b45c2

Please sign in to comment.