Use only PublicIpAddress in Azure Firewall, not both Public and Inter…

…nalPublic (#3743) * Do not confuse users with both InternalPublicIp and PublicIp for the same thing * Update AzureFirewall PUT example * This closes #3474 * Use the correct name for publicIPAddress in AzureFirewall PUT example
Azure · Aug 30, 2018 · 7100b4f · 7100b4f
1 parent 6fdd0b9
commit 7100b4f
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 13 deletions.
diff --git a/...ification/network/resource-manager/Microsoft.Network/stable/2018-08-01/azureFirewall.json b/...ification/network/resource-manager/Microsoft.Network/stable/2018-08-01/azureFirewall.json
@@ -259,22 +259,18 @@
    "definitions":{  
       "AzureFirewallIPConfigurationPropertiesFormat":{  
          "properties":{  
-			"privateIPAddress": {
-			  "type": "string",
-			  "description": "The Firewall Internal Load Balancer IP to be used as the next hop in User Defined Routes."
-			},
-            "subnet":{  
+            "privateIPAddress": {
+              "type": "string",
+              "description": "The Firewall Internal Load Balancer IP to be used as the next hop in User Defined Routes."
+            },
+            "subnet":{
                "$ref":"./network.json#/definitions/SubResource",
                "description":"Reference of the subnet resource. This resource must be named 'AzureFirewallSubnet'."
             },
-			"internalPublicIpAddress":{  
-               "$ref":"./network.json#/definitions/SubResource",
-               "description":"Reference of the PublicIP resource. This field is a mandatory input."
+            "publicIPAddress": {
+               "$ref": "./network.json#/definitions/SubResource",
+               "description": "Reference of the PublicIP resource. This field is a mandatory input if subnet is not null."
             },
-			"publicIPAddress": {
-			  "$ref": "./network.json#/definitions/SubResource",
-			  "description": "Reference of the PublicIP resource. This field is populated in the output."
-			},
             "provisioningState":{  
                "description":"The provisioning state of the resource.",
                "$ref":"#/definitions/ProvisioningState"

diff --git a/...twork/resource-manager/Microsoft.Network/stable/2018-08-01/examples/AzureFirewallPut.json b/...twork/resource-manager/Microsoft.Network/stable/2018-08-01/examples/AzureFirewallPut.json
@@ -16,7 +16,7 @@
                      "subnet":{  
                         "id":"/subscriptions/subid/resourceGroups/rg1/providers/Microsoft.Network/virtualNetworks/vnet2/subnets/AzureFirewallSubnet"
                      },
-                     "internalPublicIpAddress":{  
+                     "publicIPAddress":{  
                         "id":"/subscriptions/subid/resourceGroups/rg1/providers/Microsoft.Network/publicIPAddresses/pipName"
                      }
                   }