Fix SDK breaking change in 2017-10-01 DNS Swagger (#2612)

* Fix SDK breaking change in 2017-10-01 DNS Swagger and add linter error suppressions * Add scoping to error suppressions in 2017-10-01 DNS Swagger
Azure · Mar 8, 2018 · 570e887 · 570e887
1 parent 2a4ffd0
commit 570e887
Show file tree

Hide file tree

Showing 3 changed files with 35 additions and 2 deletions.
diff --git a/specification/dns/resource-manager/Microsoft.Network/stable/2017-10-01/dns.json b/specification/dns/resource-manager/Microsoft.Network/stable/2017-10-01/dns.json
@@ -975,7 +975,7 @@
             "in": "body",
             "required": true,
             "schema": {
-              "$ref": "#/definitions/Zone"
+              "$ref": "#/definitions/ZoneUpdate"
             },
             "description": "Parameters supplied to the Update operation."
           },
@@ -1465,6 +1465,18 @@
       ],
       "description": "Describes a DNS zone."
     },
+    "ZoneUpdate": {
+      "properties": {
+        "tags": {
+          "type": "object",
+          "additionalProperties": {
+            "type": "string"
+          },
+          "description": "Resource tags."
+        }
+      },
+      "description": "Describes a request to update a DNS zone."
+    },
     "ZoneListResult": {
       "properties": {
         "value": {
@@ -1516,6 +1528,9 @@
           "description": "Resource tags."
         }
       },
+      "required": [
+        "location"
+      ],
       "description": "Common properties of an Azure Resource Manager resource"
     },
     "SubResource": {

diff --git a/...fication/dns/resource-manager/Microsoft.Network/stable/2017-10-01/examples/PatchZone.json b/...fication/dns/resource-manager/Microsoft.Network/stable/2017-10-01/examples/PatchZone.json
@@ -5,7 +5,6 @@
     "api-version": "2017-10-01",
     "subscriptionId": "subid",
     "parameters": {
-      "location": "Global",
       "tags": {
         "key2": "value2"
       }

diff --git a/specification/dns/resource-manager/readme.md b/specification/dns/resource-manager/readme.md
@@ -36,6 +36,25 @@ These settings apply only when `--tag=package-2017-10` is specified on the comma
 ``` yaml $(tag) == 'package-2017-10'
 input-file:
 - Microsoft.Network/stable/2017-10-01/dns.json
+directive:
+  - where:
+      - $.paths
+    suppress:
+      - OperationsAPIImplementation
+  - where:
+      - $.definitions.RecordSetProperties.properties.TTL
+      - $.definitions.RecordSetProperties.properties.ARecords
+      - $.definitions.RecordSetProperties.properties.AAAARecords
+      - $.definitions.RecordSetProperties.properties.MXRecords
+      - $.definitions.RecordSetProperties.properties.NSRecords
+      - $.definitions.RecordSetProperties.properties.PTRRecords
+      - $.definitions.RecordSetProperties.properties.SRVRecords
+      - $.definitions.RecordSetProperties.properties.TXTRecords
+      - $.definitions.RecordSetProperties.properties.CNAMERecord
+      - $.definitions.RecordSetProperties.properties.SOARecord
+      - $.definitions.RecordSetUpdateParameters.properties.RecordSet
+    suppress:
+      - DefinitionsPropertiesNamesCamelCase
 ```
 
 ### Tag: package-2017-09