Skip to content

Commit

Permalink
Merge branch 'main' into tsv-suppressions
Browse files Browse the repository at this point in the history
  • Loading branch information
mikeharder authored May 17, 2024
2 parents 1d7a3b8 + 60161e2 commit 2afc0d4
Show file tree
Hide file tree
Showing 12 changed files with 42 additions and 27 deletions.
19 changes: 0 additions & 19 deletions .github/comment.yml
Original file line number Diff line number Diff line change
Expand Up @@ -22,22 +22,3 @@
type: label
label: new-rp-namespace
onLabeledComments: "Hi, @${PRAuthor}, our workflow has detected that there is no management SDK ever released for your RP, to further process SDK onboard for your RP, you should have the SDK client library name of your RP reviewed and approved. </br> <b>Action Required</b>: <li> Follow this guidance [Naming for new initial management or client libraries (new SDKs) - Overview (azure.com)](https://dev.azure.com/azure-sdk/internal/_wiki/wikis/internal.wiki/821/Naming-for-new-initial-management-or-client-libraries-(new-SDKs)) to create an issue for management client library name arch board review. </li> <li>Paste the issue link that you created in step 1 in this PR</li> </br> <b> Impact</b>: SDK release owner will take the approved management client library name to release SDK. No client library name approval will leads to SDK release delayed."

- rule:
type: label
label: ARMChangesRequested
onLabeledRemoveLabels:
- WaitForARMFeedback

- rule:
type: unlabeled
label: ARMChangesRequested
onUnlabeledAddLabels:
- WaitForARMFeedback

- rule:
type: label
label: ARMSignedOff
onLabeledRemoveLabels:
- WaitForARMFeedback
- ARMChangesRequested
7 changes: 5 additions & 2 deletions specification/ai/Face/models.session.tsp
Original file line number Diff line number Diff line change
Expand Up @@ -8,12 +8,15 @@ using TypeSpec.Rest;

namespace Face;

@doc("The operation mode for the liveness modal.")
@doc("The liveness operation mode to drive the client’s end-user experience.")
union LivenessOperationMode {
string,

@doc("The operation mode for the liveness modal.")
@doc("Utilizes a passive liveness technique that requires no additional actions from the user. Requires normal indoor lighting and high screen brightness for optimal performance. And thus, this mode has a narrow operational envelope and will not be suitable for scenarios that requires the end-user’s to be in bright lighting conditions. Note: this is the only supported mode for the Mobile (iOS and Android) solution.")
"Passive",

@doc("This mode utilizes a hybrid passive or active liveness technique that necessitates user cooperation. It is optimized to require active motion only under suboptimal lighting conditions. Unlike the passive mode, this mode has no lighting restrictions, and thus offering a broader operational envelope. This mode is preferable on Web based solutions due to the lack of automatic screen brightness control available on browsers which hinders the Passive mode’s operational envelope on Web based solutions.")
"PassiveActive",
}

#suppress "@azure-tools/typespec-autorest/unsupported-multipart-type" "Provide convenient interface for multipart/form-data in SDK"
Expand Down
3 changes: 3 additions & 0 deletions specification/ai/Face/routes.common.tsp
Original file line number Diff line number Diff line change
@@ -1,11 +1,13 @@
import "@typespec/http";
import "@typespec/rest";
import "@azure-tools/typespec-azure-core";
import "@azure-tools/typespec-client-generator-core";
import "./models.common.tsp";
import "./models.detect.tsp";

using TypeSpec.Http;
using TypeSpec.Rest;
using Azure.ClientGenerator.Core;
using Azure.Core;
using Azure.Core.Traits;
using Foundations;
Expand Down Expand Up @@ -66,6 +68,7 @@ op AddFace<TFace extends BaseFace> is Foundations.ResourceCollectionOperation<
op AddFaceFromUrl<TFace extends BaseFace> is Foundations.ResourceCollectionOperation<
TFace,
AddFaceOptions & {
@clientName("uri", "csharp")
@doc("URL of input image.")
url: url;
},
Expand Down
2 changes: 2 additions & 0 deletions specification/ai/Face/routes.detection.tsp
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ import "./models.detect.tsp";

using TypeSpec.Http;
using TypeSpec.Rest;
using Azure.ClientGenerator.Core;
using Azure.Core;
using Azure.Core.Traits;
using Foundations;
Expand Down Expand Up @@ -46,6 +47,7 @@ interface FaceDetectionOperations {
@header
contentType: "application/json";

@clientName("uri", "csharp")
@doc("URL of input image.")
url: url;
}>;
Expand Down
2 changes: 2 additions & 0 deletions specification/ai/Face/routes.persondirectory.tsp
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ import "./models.persondirectory.tsp";

using TypeSpec.Http;
using TypeSpec.Rest;
using Azure.ClientGenerator.Core;
using Azure.Core;
using Azure.Core.Traits;
using Foundations;
Expand Down Expand Up @@ -182,6 +183,7 @@ interface PersonDirectoryOperations {
#suppress "@azure-tools/typespec-azure-core/byos" "It's an RPC call to detect face from an image, it doesn't store anything. There's a BYOS version of this call, but it's not this one."
#suppress "@azure-tools/typespec-azure-core/long-running-polling-operation-required" "Doesn't fit in generated long-running operation"
addPersonFaceFromUrl is AddPersonFaceOperation<{
@clientName("uri", "csharp")
@doc("URL of input image.")
url: url;
}>;
Expand Down
2 changes: 1 addition & 1 deletion specification/ai/Face/tspconfig.yaml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
parameters:
"service-dir":
default: "sdk/vision"
default: "sdk/face"
"dependencies":
"additionalDirectories": []
default: ""
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8627,9 +8627,10 @@
},
"LivenessOperationMode": {
"type": "string",
"description": "The operation mode for the liveness modal.",
"description": "The liveness operation mode to drive the client’s end-user experience.",
"enum": [
"Passive"
"Passive",
"PassiveActive"
],
"x-ms-enum": {
"name": "LivenessOperationMode",
Expand All @@ -8638,7 +8639,12 @@
{
"name": "Passive",
"value": "Passive",
"description": "The operation mode for the liveness modal."
"description": "Utilizes a passive liveness technique that requires no additional actions from the user. Requires normal indoor lighting and high screen brightness for optimal performance. And thus, this mode has a narrow operational envelope and will not be suitable for scenarios that requires the end-user’s to be in bright lighting conditions. Note: this is the only supported mode for the Mobile (iOS and Android) solution."
},
{
"name": "PassiveActive",
"value": "PassiveActive",
"description": "This mode utilizes a hybrid passive or active liveness technique that necessitates user cooperation. It is optimized to require active motion only under suboptimal lighting conditions. Unlike the passive mode, this mode has no lighting restrictions, and thus offering a broader operational envelope. This mode is preferable on Web based solutions due to the lack of automatic screen brightness control available on browsers which hinders the Passive mode’s operational envelope on Web based solutions."
}
]
}
Expand Down
4 changes: 4 additions & 0 deletions specification/devopsinfrastructure/resource-manager/readme.md
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,10 @@ openapi-subtype: providerHub
tag: package-preview-2024-04
```
``` yaml
modelerfour:
flatten-models: false
```
### Tag: package-preview-2024-04
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ These settings apply only when `--python` is specified on the command line.
Please also specify `--python-sdks-folder=<path to the root directory of your azure-sdk-for-python clone>`.

``` yaml $(python)
title: DevOpsInfrastructureMgmtClient
azure-arm: true
license-header: MICROSOFT_MIT_NO_VERSION
package-name: azure-mgmt-devopsinfrastructure
Expand Down
7 changes: 7 additions & 0 deletions specification/oracle/resource-manager/readme.java.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
## Java

These settings apply only when `--java` is specified on the command line.

``` yaml $(java)
client-flattened-annotation-target: disabled
```
5 changes: 5 additions & 0 deletions specification/oracle/resource-manager/readme.md
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,11 @@ openapi-subtype: rpaas
tag: package-2023-09-01-preview
```
``` yaml
modelerfour:
flatten-models: false
```
### Tag: package-2023-09-01-preview
These settings apply only when `--tag=package-2023-09-01-preview` is specified on the command line.
Expand Down
5 changes: 3 additions & 2 deletions specification/oracle/resource-manager/readme.typescript.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,11 @@ These settings apply only when `--typescript` is specified on the command line.
Please also specify `--typescript-sdks-folder=<path to root folder of your azure-sdk-for-js clone>`.

``` yaml $(typescript)
title: OracleDatabaseManagementClient
typescript:
azure-arm: true
package-name: "@azure/arm-Oracle.Database"
output-folder: "$(typescript-sdks-folder)/sdk/Oracle.Database/arm-Oracle.Database"
package-name: "@azure/arm-oracledatabase"
output-folder: "$(typescript-sdks-folder)/sdk/oracledatabase/arm-oracledatabase"
payload-flattening-threshold: 1
clear-output-folder: true
generate-metadata: true
Expand Down

0 comments on commit 2afc0d4

Please sign in to comment.