update arc review comments and mail (#21867)

* update arc review comments and mail * Update .github/comment.yml Co-authored-by: Ray Chen <[email protected]>
Azure · Dec 13, 2022 · 25bea13 · 25bea13
1 parent 7245d0f
commit 25bea13
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 0 deletions.
diff --git a/.github/comment.yml b/.github/comment.yml
@@ -51,6 +51,11 @@
     label: CI-RpaaSRPNotInPrivateRepo
     onLabeledComments: "Hi @${PRAuthor} This PR was flagged for attempting to introduce a new RP namespace to the main branch without first merging the new RP to the RPSaaSMaster branch. Please add the new RP in a merge to RPSaaSMaster before continuing the merge to main."
 
+- rule:
+    type: label
+    label: ArcReview
+    onLabeledComments: "Hi @${PRAuthor} and @arcboard, one or more change(s) have been detected in your Arc enabled VM's or Arc enabled Server's RPs. Please review the changes and ensure that no gaps have been introduced with respect to the ARM API modeling consistency across Azure Arc and Azure Compute. For further details, see guidelines at [Consistency in ARM Modeling](https://msazure.visualstudio.com/One/_wiki/wikis/One.wiki/377428/Consistency-in-ARM-Modeling?anchor=general-design-guidance). To approve the change(s), set the label to ArcSignedOff. If you have any questions, please mail to [email protected]."
+
 - rule:
     type: label
     label: CI-FixRequiredOnFailure

diff --git a/.github/sla.yml b/.github/sla.yml
@@ -28,6 +28,22 @@
         - ${AUTHOR}
         - ${ASSIGNEE}
 
+
+- scheduleTask:
+    action: sendEmail
+    scope: pull_request
+    name: "send email to Arc review board"
+    trigger:
+      - label
+    args:
+      booleanFilterExpression: "ArcReview"
+      message: "<p>Hi, Arc review board,</p><p>Please review the PR ${URL} . You receive the email because the PR is labeled with ArcReview. One or more change(s) have been detected in your Arc enabled VM or Arc enabled Server RPs. Please review the changes and ensure that no gaps have been introduced with respect to the ARM API modeling consistency across Azure Arc and Azure Compute. For further details, see guidelines at Consistency in ARM Modeling. To approve the change(s), add the label ArcSignedOff.</p>"
+      subject: "Action Required ArcReview: Please review PR ${URL}"
+      to: [email protected]
+      cc:
+        - ${AUTHOR}
+        - ${ASSIGNEE}
+
 - scheduleTask:
     action: sendEmail
     scope: pull_request