Skip to content

Commit

Permalink
Update listVault.json (#22155)
Browse files Browse the repository at this point in the history
* Update listVault.json

* Remove the preview API version for the enum

* Delete Vault_Lists API specification

* Added the Vaults_List swagger specification back.

* Abstracted Vaults_List API into 2015-11-01 directory to Swagger ModelValidation Errors.

* Resolved unresolvable references.

* Reorganized the definitions.

* Reorganized the 2015-11-01 directory under 2022-02-01-preview

* Moved the 2015-11-10 directory to stable.

* Undo the abstraction changes.

* Readd the listVault.json.

* Added suppression directives for INVALID_REQUEST_PARAMETER and OBJECT_MISSING_REQUIRED_PROPERTY.

* Modify suppress rule.

* Update the suppression directive.

* Update suppression directive.

* Update suppression directive.

* Update suppression directives.

* Updated suppression directive.

* Added suppression directives for INVALID_REQUEST_PARAMETER, OBJECT_MISSING_REQUIRED_PROPERTY

* Updated suppression directives.

* Updated suppression directives.

* Updated suppression directives.

* Updated suppression directives.

* Updated suppression directives.

* Added x-ms-validation rules to the api-version parameter.

* Updated suppression directives.

* Added individual suppression directives.

* Removed where clause from the OBJECT_MISSING_REQUIRED_PROPERTY suppression directive.

* Corrected yaml title for suppression directives.

Co-authored-by: Rahul Alapati <[email protected]>
  • Loading branch information
rahulalapati43 and Rahul Alapati authored Jan 16, 2023
1 parent 4503120 commit 101d6bb
Show file tree
Hide file tree
Showing 3 changed files with 10 additions and 5 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"$filter": "resourceType eq 'Microsoft.KeyVault/vaults'",
"$top": 1,
"subscriptionId": "00000000-0000-0000-0000-000000000000",
"api-version": "2022-02-01-preview"
"api-version": "2015-11-01"
},
"responses": {
"200": {
Expand All @@ -17,7 +17,7 @@
"tags": {}
}
],
"nextLink": "https://management.azure.com/subscriptions/00000000-0000-0000-0000-000000000000/resources?%24filter=resourceType+eq+%27Microsoft.KeyVault%2fvaults%27&%24top=4&api-version=2022-02-01-preview&%24skiptoken=eyJuZXh0UGFydGl0aW9uS2V5IjoiMSE4IVEwTTJNVGMtIiwibmV4dFJvd0tleSI6IjEhMTMyIU5rUTRSVEU1UXpJelFUWXdORGd4UmpoRlFrSXhNVGhFUXpNd01EZEROVVJmVkVkT1RDMU5TVU5TVDFOUFJsUTZNa1ZMUlZsV1FWVk1WRG95UmxaQlZVeFVVeTFUVTFKSExVcEpUVG95UkZSRlUxUTZNa1JXUVZWTVZDMVhSVk5VVlZNLSJ9"
"nextLink": "https://management.azure.com/subscriptions/00000000-0000-0000-0000-000000000000/resources?%24filter=resourceType+eq+%27Microsoft.KeyVault%2fvaults%27&%24top=4&api-version=2015-11-01&%24skiptoken=eyJuZXh0UGFydGl0aW9uS2V5IjoiMSE4IVEwTTJNVGMtIiwibmV4dFJvd0tleSI6IjEhMTMyIU5rUTRSVEU1UXpJelFUWXdORGd4UmpoRlFrSXhNVGhFUXpNd01EZEROVVJmVkVkT1RDMU5TVU5TVDFOUFJsUTZNa1ZMUlZsV1FWVk1WRG95UmxaQlZVeFVVeTFUVTFKSExVcEpUVG95UkZSRlUxUTZNa1JXUVZWTVZDMVhSVk5VVlZNLSJ9"
}
}
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -657,8 +657,7 @@
"x-ms-api-version": false,
"type": "string",
"enum": [
"2015-11-01",
"2022-02-01-preview"
"2015-11-01"
],
"x-ms-enum": {
"name": "ResourceManagerApiVersions",
Expand Down
8 changes: 7 additions & 1 deletion specification/keyvault/resource-manager/readme.md
Original file line number Diff line number Diff line change
Expand Up @@ -212,7 +212,7 @@ input-file:
- Microsoft.KeyVault/stable/2019-09-01/secrets.json
```

### Supressions
### Suppression

``` yaml
directive:
Expand All @@ -223,6 +223,12 @@ directive:
- R4015 # The 'MHSMPrivateEndpointConnection' sub-resource doesn't define List as per Network Team's specification.
- R2005 # The 'ManagedHsms_PurgeDeleted' operation should not return a mix of 202 and syncronous return types (200, 201, 204) as directed by SDK team.
- R4009 # Vault object is the only one that need to be tracked with SystemData
- suppress: INVALID_REQUEST_PARAMETER
from: keyvault.json
reason: The Vaults_List API endpoint only supports version 2015-11-01.
- suppress: OBJECT_MISSING_REQUIRED_PROPERTY
from: keyvault.json
reason: The Vaults_List API endpoint only supports version 2015-11-01.
```

---
Expand Down

0 comments on commit 101d6bb

Please sign in to comment.