[ReleasePR hardwaresecuritymodules] [Hub Generated] Publish private branch 'feature/CloudHsm_updates' #2912
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[Hub Generated] Publish private branch 'feature/CloudHsm_updates' (#24115) * adding new resource type 'CloudHsm' with new API version * added systemData in responses and fixed few warnings * renamings * added stateMessage * removed PrivateEndpointConnectionProxy APIs and examples * API version folder renamed * updated ReadMe.md * renamings, fixing validation errors * fixed avocado errors * fixed prettier errors * fixed prettier errors * fixed validation errors * fixed prettier errors * fixed prettier errors * fixed linfdiff errors * fixed LintDiff errors * fixed linfdiff errors * fixed staging LintDiff errors * fixed LintDiff errors * fixed lintdiff errors * removed pageable extention from CloudHsmPrivateLinkResource_ListByCloudHsm * renamings * used referecing for private endpoint connection and private link resource under common types * fixed review comments * fixed resourceType in exmaple * renamed CloudHsm to CloudHsmCluster * renamed hsmId to fqdn * fixed description * modified default tag in Readme.md * changed tag value to package-2022-08-preview * Update specification/hardwaresecuritymodules/resource-manager/readme.md Co-authored-by: Chenjie Shi <[email protected]> * Update readme.md * Update readme.md * fixing lintdiff errors, also fixing old DHSM errors * fixing syntax errors * removed operations examples from cloudhsm * added ResourceNameRestriction for peConnectionName * added ResourceNameRestriction for peConnectionName * added pattern for peConnectionName * fixing prettier check * Using Common-types definitions for TrackedResource * created separate folders for different sub services * reverting to common folder structure * To resolve duplicate definition errors * fixing Swagger Staging lintDiff error * Update Cloud Hsm swagger specifications * update api-versions to resolve Model Validation issues * update api version in example file * added chsmOperation to custom-words.txt * Removed chsmOperation, replaced CHsmTrackedResource with TrackedResource and AzureResource with ProxyResource. Removed unused definitions/ * Set final-state-via to CreateOperationAsyncResponseValidation and added x-ms-pageable to resolve LintDiff validation issue * fix lintdiff issue * update final-state-via for put operation to Original-Uri * Replaced ProxyResource with TrackedResource in PrivateEndPointConnection because location and tags are also needed. * Reverted previouse commit to resolve LintDiff issue and included location and etags to PrivateEndpointConnetion. * removed white space to resolve Prettier check issue * updated etag description * Updated skiptoken type from integer to string based on code update. * Fix required value for skiptoken * make update for LintDiff issue - PutResponseSchemaDescription * make update for LintDiff issue - PutResponseSchemaDescription * Removed location and added groupIds from PrivateEndpointConnection definition in line with NRP Documentation * update swagger to reflect ARM feedback * Added Canceled state to PrivateEndpointConnectionProvisioningState enum as per ARM review request * Renamed "Resource" Definition in Dedicated hsm swagger file to resolve azure-sdk-for-go error caused by duplicate schema. "CloudHsmClusterResource" indirectly references the common-type"Resource" and this conflicts with "Resource" definition in dedicatedhsm swagger. * Remove duplicate type tag from DedicatedHsmResource * updated readme file to fix ~[Staging] Service API Readiness Test failed error * updated readme file to fix ~[Staging] Service API Readiness Test fail * update readme file to resolve ~[Staging] Service API Readiness Test failure --------- Co-authored-by: GoradeAarti <[email protected]> Co-authored-by: GoradeAarti <[email protected]> Co-authored-by: Chenjie Shi <[email protected]>
ghost
added
the
Merged
11 tasks
ghost
approved these changes
Jun 21, 2023
There was a problem hiding this comment.
This PR has been auto-approved by the @msftbot for the azure-resource-manager-schemas repo.
|
Hello @msftbot[bot]! Because this pull request has the Do note that I've been instructed to only help merge pull requests of this repository that have been opened for at least 1 minute. No worries though, I will be back when the time is right! 😉 p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create to sync Azure/azure-rest-api-specs#24115
ReCreate this PR