Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Azure SQL Database Managed Instance Azure Environment #4847

Merged
merged 23 commits into from
Jul 3, 2018
Merged

Azure SQL Database Managed Instance Azure Environment #4847

merged 23 commits into from
Jul 3, 2018

Conversation

jovanpop-msft
Copy link

This is a quick start template that enables customers to create properly configured Azure environment for Azure SQL Database Managed Instance.

It is based on the existing vnet-with-two-subnets template with changes specific for the Managed Instance.

Note: I have followed guidelines and successfully created several valid environments while testing the template.

@jovanpop-msft
Copy link
Author

"variables": {},
"resources": [
{
"apiVersion": "2015-06-15",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

update apiVersion

}
]
},
"dependsOn": ["[resourceId('Microsoft.Network/routeTables', parameters('routeTableToAzureService'))]"]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

move dependsOn above properties

{
"$schema": "http://schema.management.azure.com/schemas/2015-01-01/deploymentParameters.json#",
"contentVersion": "1.0.0.0",
"parameters": {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove these since you have defaultValues in the template

<img src="http://armviz.io/visualizebutton.png"/>
</a>

This template allows you to create an Azure networking environment required to deploy [Azure SQL Database Managed Instances](https://docs.microsoft.com/en-us/azure/sql-database/sql-database-managed-instance) - fully managed SQL Server Database Engine hosted in Azure cloud.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo - ... hosted in the Azure cloud.

## Solution overview and deployed resources

This deployment will create configured Azure Virtual Network with two subnets - one that will be dedicated to your SQL Managed Instances,
and the another one where you can place other resources (for example VMs, App Service environments, etc.) This is a properly
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need a period after )


## Solution overview and deployed resources

This deployment will create configured Azure Virtual Network with two subnets - one that will be dedicated to your SQL Managed Instances,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

create a configured

@jovanpop-msft
Copy link
Author

Added requested changes and successfully tested new version.

@bmoore-msft bmoore-msft merged commit 940c1f8 into Azure:master Jul 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants