Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RecoveryServices.Backup] VM restore fix for #7823 #7925

Merged

Conversation

siddharth7
Copy link
Contributor

Description

#7823

Checklist

@siddharth7 siddharth7 changed the title VM restore fix for #7823 [RecoveryServices.Backup] VM restore fix for #7823 Nov 27, 2018
@siddharth7 siddharth7 force-pushed the users/sisi/vm-restore-fix branch from aec722a to a7c2805 Compare November 28, 2018 07:28
@siddharth7 siddharth7 force-pushed the users/sisi/vm-restore-fix branch from a7c2805 to 83ddf52 Compare November 28, 2018 12:15
@siddharth7 siddharth7 force-pushed the users/sisi/vm-restore-fix branch from 29bb794 to 91cdfaf Compare November 28, 2018 19:29
@@ -16,7 +16,8 @@ public abstract class RSBackupVaultCmdletBase : RecoveryServicesBackupCmdletBase
/// ARM ID of the Recovery Services Vault.
/// </summary>
[Parameter(Mandatory = false, HelpMessage = "ARM ID of the Recovery Services Vault.",
ValueFromPipeline = true)]
ValueFromPipelineByPropertyName = true)]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@siddharth7 does this scenario currently break users? i.e., are users able to write scripts that use this parameter via piping without any exceptions?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@siddharth7 resolved offline -- users currently using this piping scenario are broken, so this is not a breaking change. The exception in the build can be suppressed.

@cormacpayne cormacpayne changed the base branch from preview to release-2018-12-04 November 29, 2018 01:34
@siddharth7 siddharth7 force-pushed the users/sisi/vm-restore-fix branch from acb75ec to c0aeab6 Compare November 29, 2018 17:18
@cormacpayne cormacpayne merged commit 960df5e into Azure:release-2018-12-04 Nov 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants