-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Setting TimeZone when creating weekly and monthly schedules #4165
Conversation
Can one of the admins verify this patch? |
@azuresdkci add to whitelist |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Bpoe Hey Brandon, one question about if the tests are being run on CI or not
@@ -320,5 +320,125 @@ public void NewAzureAutomationScheduleByHourlyWithExpiryTimeSuccessfull() | |||
"Hour Frequency is unexpectedly {0}", | |||
schedule.Frequency); | |||
} | |||
|
|||
[TestMethod] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Bpoe I'm not sure if the tests in this file are being run on CI. We may need to add the [Fact]
and [Trait(Category.AcceptanceType, Category.CheckIn)]
to these tests so that they are run.
using Microsoft.WindowsAzure.Commands.Test.Utilities.Common; | ||
using Microsoft.WindowsAzure.Commands.Utilities.Common; | ||
using Moq; | ||
using System; | ||
using System.Linq; | ||
using Xunit; | ||
using Assert = Microsoft.VisualStudio.TestTools.UnitTesting.Assert; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Bpoe are you converting msTests to xunit tests? Is this why you need to mix two Asserts?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, these were previously MSTests. I just converted them so that they could run during CI
Description
Fix for #3043
Properly setting TimeZone value for Weekly and Monthly schedules
This checklist is used to make sure that common guidelines for a pull request are followed. You can find a more complete discussion of PowerShell cmdlet best practices here.
General Guidelines
Testing Guidelines
Cmdlet Signature Guidelines
ShouldProcess
and haveSupportShouldProcess=true
specified in the cmdlet attribute. You can find more information onShouldProcess
here.OutputType
attribute if any output is produced - if the cmdlet produces no output, it should implement aPassThru
parameter.Cmdlet Parameter Guidelines