-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Unit test to cover New storage Context in different RMprofile and SMProfile combination #3986
Conversation
|
||
namespace Microsoft.WindowsAzure.Commands.Storage.Test.Common.Cmdlet | ||
{ | ||
class TestProfileProvider : AzureRmProfileProvider |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@blueww Please add any additional scenarios to the tests I added, as xunit tests. We are not accepting any new MSTest tests in the repo, and these need to be check-in tests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the comments!
Will try to find some time to fix it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The cases are added to the new test you added.
The PR is updated, please check.
New Demand test pass: http://azuresdkci.cloudapp.net/view/1-AzurePowerShell/job/powershell-demand/1609/ |
} | ||
} | ||
|
||
[Fact(Skip = "The case will fail since Environment is ignored when both SMProfile and RMProfile are null. Need confirm if this is a valid scenario.")] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please either remove this test, or file an issue for fixing the underlying issue and reference the issue id here. The issue must be resolved by the end of the next sprint.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The case is removed, and new on demand test: http://azuresdkci.cloudapp.net/view/1-AzurePowerShell/job/powershell-demand/1617/
We will continue to following this in mail to see if this is a valid scenario. If so, we need fix it.
@blueww one correction, otherwise LGTM |
… SMProfile combination
Description
Add Unit test to cover New storage Context Test in different RMprofile and SMProfile combination.
We have a severe regression issue in the latest stage of release 4.0.0, which is not caught by Unit test.
#3939
Mark has add test coverage for this issue in #3938 .
But #3938 only cover the RMprofile!=null and SMProfile=null scenario, So this PR add all combination to avoid regression .
This checklist is used to make sure that common guidelines for a pull request are followed. You can find a more complete discussion of PowerShell cmdlet best practices here.
General Guidelines
Testing Guidelines
Cmdlet Signature Guidelines
ShouldProcess
and haveSupportShouldProcess=true
specified in the cmdlet attribute. You can find more information onShouldProcess
here.OutputType
attribute if any output is produced - if the cmdlet produces no output, it should implement aPassThru
parameter.Cmdlet Parameter Guidelines