Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Unit test to cover New storage Context in different RMprofile and SMProfile combination #3986

Merged
merged 1 commit into from
May 30, 2017

Conversation

blueww
Copy link
Member

@blueww blueww commented May 17, 2017

Description

Add Unit test to cover New storage Context Test in different RMprofile and SMProfile combination.

We have a severe regression issue in the latest stage of release 4.0.0, which is not caught by Unit test.
#3939

Mark has add test coverage for this issue in #3938 .
But #3938 only cover the RMprofile!=null and SMProfile=null scenario, So this PR add all combination to avoid regression .

This checklist is used to make sure that common guidelines for a pull request are followed. You can find a more complete discussion of PowerShell cmdlet best practices here.

General Guidelines

  • [ Y] Title of the pull request is clear and informative.
  • [ Y] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.
  • The pull request does not introduce breaking changes (unless a major version change occurs in the assembly and module).

Testing Guidelines

  • [ Y] Pull request includes test coverage for the included changes.
  • [ Y] PowerShell scripts used in tests should do any necessary setup as part of the test or suite setup, and should not use hard-coded values for locations or existing resources.

Cmdlet Signature Guidelines

  • [ Y] New cmdlets that make changes or have side effects should implement ShouldProcess and have SupportShouldProcess=true specified in the cmdlet attribute. You can find more information on ShouldProcess here.
  • [ Y] Cmdlet specifies OutputType attribute if any output is produced - if the cmdlet produces no output, it should implement a PassThru parameter.

Cmdlet Parameter Guidelines

  • [ Y] Parameter types should not expose types from the management library - complex parameter types should be defined in the module.
  • [ Y] Complex parameter types are discouraged - a parameter type should be simple types as often as possible. If complex types are used, they should be shallow and easily creatable from a constructor or another cmdlet.
  • [ Y] Cmdlet parameter sets should be mutually exclusive - each parameter set must have at least one mandatory parameter not in other parameter sets.

@blueww
Copy link
Member Author

blueww commented May 17, 2017


namespace Microsoft.WindowsAzure.Commands.Storage.Test.Common.Cmdlet
{
class TestProfileProvider : AzureRmProfileProvider
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@blueww Please add any additional scenarios to the tests I added, as xunit tests. We are not accepting any new MSTest tests in the repo, and these need to be check-in tests

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the comments!
Will try to find some time to fix it.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The cases are added to the new test you added.
The PR is updated, please check.

@blueww
Copy link
Member Author

blueww commented May 24, 2017

}
}

[Fact(Skip = "The case will fail since Environment is ignored when both SMProfile and RMProfile are null. Need confirm if this is a valid scenario.")]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please either remove this test, or file an issue for fixing the underlying issue and reference the issue id here. The issue must be resolved by the end of the next sprint.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The case is removed, and new on demand test: http://azuresdkci.cloudapp.net/view/1-AzurePowerShell/job/powershell-demand/1617/

We will continue to following this in mail to see if this is a valid scenario. If so, we need fix it.

@markcowl
Copy link
Member

@blueww one correction, otherwise LGTM

@markcowl
Copy link
Member

@markcowl markcowl merged commit 480b8c9 into Azure:preview May 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants