Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ServiceBus: Upcoming Breaking change - Removed 'ResourceGroupName' from NamespaceAttributes. #3894

Merged
merged 2 commits into from
May 3, 2017
Merged

ServiceBus: Upcoming Breaking change - Removed 'ResourceGroupName' from NamespaceAttributes. #3894

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7b8e242
updated Breakingchanges.csv and suppression
May 3, 2017
415eb68
Merge branch 'preview' into SBFixes
markcowl May 3, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions src/ResourceManager/ServiceBus/Commands.ServiceBus/Models/NamespaceAttributes.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,10 +108,6 @@ public NamespaceAttributes(NamespaceResource evResource)
/// </summary>
public bool? Enabled { get; set; }

/// <summary>
/// Gets or sets the name of the resource group the Namespace is in
/// </summary>
[ObsoleteAttribute("ResourceGroupName property is obsolete.", false)]
public string ResourceGroupName { get; set; }

}
}
5 changes: 4 additions & 1 deletion tools/StaticAnalysis/Exceptions/BreakingChangeIssues.csv
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,6 +117,9 @@
"Microsoft.Azure.Commands.MachineLearning.dll","Microsoft.Azure.Commands.MachineLearning.UpdateAzureMLWebService","Update-AzureRmMlWebService","0","3040","The generic type argument for 'property Parameters' has been changed from 'System.String' to 'Microsoft.Azure.Management.MachineLearning.WebServices.Models.WebServiceParameter'.","Change the generic type argument for 'property Parameters' back to 'System.String'."
"Microsoft.Azure.Commands.KeyVault.dll","Microsoft.Azure.Commands.KeyVault.BackupAzureKeyVaultKey","Backup-AzureKeyVaultKey","0","2100","The parameter 'VaultName' in cmdlet 'Backup-AzureKeyVaultKey' is no longer in the parameter set '__AllParameterSets'.","Add parameter 'VaultName' back to the parameter set '__AllParameterSets'."
"Microsoft.Azure.Commands.KeyVault.dll","Microsoft.Azure.Commands.KeyVault.BackupAzureKeyVaultKey","Backup-AzureKeyVaultKey","0","2100","The parameter 'Name' in cmdlet 'Backup-AzureKeyVaultKey' is no longer in the parameter set '__AllParameterSets'.","Add parameter 'Name' back to the parameter set '__AllParameterSets'."
"D:\AzurePwr\azure-powershell\src\Package\Debug\ResourceManager\AzureResourceManager\AzureRM.ServiceBus\Microsoft.Azure.Commands.ServiceBus.dll","Microsoft.Azure.Commands.ServiceBus.Commands.Namespace.GetAzureRmServiceBusNamespace","Get-AzureRmServiceBusNamespace","0","3010","The property 'ResourceGroupName' of type 'NamespaceAttributes' has been removed.","Add the property 'ResourceGroupName' back to type 'NamespaceAttributes'."
"D:\AzurePwr\azure-powershell\src\Package\Debug\ResourceManager\AzureResourceManager\AzureRM.ServiceBus\Microsoft.Azure.Commands.ServiceBus.dll","Microsoft.Azure.Commands.ServiceBus.Commands.Namespace.NewAzureRmServiceBusNamespace","New-AzureRmServiceBusNamespace","0","3010","The property 'ResourceGroupName' of type 'NamespaceAttributes' has been removed.","Add the property 'ResourceGroupName' back to type 'NamespaceAttributes'."
"D:\AzurePwr\azure-powershell\src\Package\Debug\ResourceManager\AzureResourceManager\AzureRM.ServiceBus\Microsoft.Azure.Commands.ServiceBus.dll","Microsoft.Azure.Commands.ServiceBus.Commands.Namespace.SetAzureRmServiceBusNamespace","Set-AzureRmServiceBusNamespace","0","3010","The property 'ResourceGroupName' of type 'NamespaceAttributes' has been removed.","Add the property 'ResourceGroupName' back to type 'NamespaceAttributes'."
"Microsoft.Azure.Commands.Compute.dll","Microsoft.Azure.Commands.Compute.NewAzureAdditionalUnattendContentCommand","Add-AzureRmVMAdditionalUnattendContent","0","3010","The property 'DataDiskNames' of type 'PSVirtualMachine' has been removed.","Add the property 'DataDiskNames' back to type 'PSVirtualMachine'."
"Microsoft.Azure.Commands.Compute.dll","Microsoft.Azure.Commands.Compute.NewAzureAdditionalUnattendContentCommand","Add-AzureRmVMAdditionalUnattendContent","0","3010","The property 'NetworkInterfaceIDs' of type 'PSVirtualMachine' has been removed.","Add the property 'NetworkInterfaceIDs' back to type 'PSVirtualMachine'."
"Microsoft.Azure.Commands.Compute.dll","Microsoft.Azure.Commands.Compute.NewAzureAdditionalUnattendContentCommand","Add-AzureRmVMAdditionalUnattendContent","0","3010","The property 'DataDiskNames' of type 'PSVirtualMachine' has been removed.","Add the property 'DataDiskNames' back to type 'PSVirtualMachine'."
Expand Down Expand Up @@ -184,4 +187,4 @@
"Microsoft.Azure.Commands.Compute.dll","Microsoft.Azure.Commands.Compute.AddAzureVMNetworkInterfaceCommand","Add-AzureRmVMNetworkInterface","0","3010","The property 'DataDiskNames' of type 'PSVirtualMachine' has been removed.","Add the property 'DataDiskNames' back to type 'PSVirtualMachine'."
"Microsoft.Azure.Commands.Compute.dll","Microsoft.Azure.Commands.Compute.AddAzureVMNetworkInterfaceCommand","Add-AzureRmVMNetworkInterface","0","3010","The property 'NetworkInterfaceIDs' of type 'PSVirtualMachine' has been removed.","Add the property 'NetworkInterfaceIDs' back to type 'PSVirtualMachine'."
"Microsoft.Azure.Commands.Compute.dll","Microsoft.Azure.Commands.Compute.AddAzureVMNetworkInterfaceCommand","Add-AzureRmVMNetworkInterface","0","3010","The property 'DataDiskNames' of type 'PSVirtualMachine' has been removed.","Add the property 'DataDiskNames' back to type 'PSVirtualMachine'."
"Microsoft.Azure.Commands.Compute.dll","Microsoft.Azure.Commands.Compute.AddAzureVMNetworkInterfaceCommand","Add-AzureRmVMNetworkInterface","0","3010","The property 'NetworkInterfaceIDs' of type 'PSVirtualMachine' has been removed.","Add the property 'NetworkInterfaceIDs' back to type 'PSVirtualMachine'."
"Microsoft.Azure.Commands.Compute.dll","Microsoft.Azure.Commands.Compute.AddAzureVMNetworkInterfaceCommand","Add-AzureRmVMNetworkInterface","0","3010","The property 'NetworkInterfaceIDs' of type 'PSVirtualMachine' has been removed.","Add the property 'NetworkInterfaceIDs' back to type 'PSVirtualMachine'."