Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EventHub: bug fix and New SDK Nuget version #3864

Merged
merged 5 commits into from
May 2, 2017
Merged

EventHub: bug fix and New SDK Nuget version #3864

merged 5 commits into from
May 2, 2017

Conversation

v-Ajnava
Copy link
Member

@v-Ajnava v-Ajnava commented Apr 28, 2017 •
edited by azuresdkci
Loading

Description

  • Bug fix : for Set-AzureRmEventHubNamespace and Set-AzureRmEventHub
  • New SDK Nuget Version

This checklist is used to make sure that common guidelines for a pull request are followed. You can find a more complete discussion of PowerShell cmdlet best practices here.

General Guidelines

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.
  • The pull request does not introduce breaking changes (unless a major version change occurs in the assembly and module).

Testing Guidelines

  • Pull request includes test coverage for the included changes.
  • PowerShell scripts used in tests should do any necessary setup as part of the test or suite setup, and should not use hard-coded values for locations or existing resources.

Cmdlet Signature Guidelines

  • New cmdlets that make changes or have side effects should implement ShouldProcess and have SupportShouldProcess=true specified in the cmdlet attribute. You can find more information on ShouldProcess here.
  • Cmdlet specifies OutputType attribute if any output is produced - if the cmdlet produces no output, it should implement a PassThru parameter.

Cmdlet Parameter Guidelines

  • Parameter types should not expose types from the management library - complex parameter types should be defined in the module.
  • Complex parameter types are discouraged - a parameter type should be simple types as often as possible. If complex types are used, they should be shallow and easily creatable from a constructor or another cmdlet.
  • Cmdlet parameter sets should be mutually exclusive - each parameter set must have at least one mandatory parameter not in other parameter sets.

@v-Ajnava v-Ajnava requested a review from cormacpayne April 28, 2017 17:40
@v-Ajnava v-Ajnava changed the title ServiceBus : bug fix and New SDK Nuget version EventHub: bug fix and New SDK Nuget version Apr 28, 2017
cormacpayne
cormacpayne previously requested changes Apr 28, 2017
View reviewed changes
Copy link
Member

@cormacpayne cormacpayne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@v-Ajnava a couple of comments

Also, you are updating the wxi file with all of the markdown help files. If you pull the latest from preview, you should not see this anymore from a full local build and regeneration of the installer. The markdown files should be successfully removed.

src/ResourceManager/EventHub/ChangeLog.md Outdated
@@ -19,6 +19,8 @@
-->
## Current Release

* Bug fix : for Set-AzureRmEventHubNamespace and Set-AzureRmEventHub
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@v-Ajnava can you give more information on the bug fixes?

src/ResourceManager/EventHub/Commands.EventHub.Test/Commands.EventHubs.Test.csproj Outdated
@@ -172,21 +172,6 @@
<None Include="ScenarioTests\EventHubsTests.ps1">
<CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>
</None>
<None Include="SessionRecords\Microsoft.Azure.Commands.EventHub.Test.ScenarioTests.ConsumerGroupsTests\ConsumerGroupsCRUD.json">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@v-Ajnava why were these files removed?

@cormacpayne cormacpayne assigned v-Ajnava and unassigned cormacpayne Apr 28, 2017
@markcowl
Copy link
Member

on demand run here: http://azuresdkci.cloudapp.net/view/1-AzurePowerShell/job/powershell-demand/1501/

LGTM once this passes

@markcowl
Copy link
Member

markcowl commented May 1, 2017

@azuresdkci retest this please

@markcowl
Copy link
Member

markcowl commented May 1, 2017

@v-Ajnava Can you pull the latest? It looks like there is an issue in your PR that may be fixed upstream.

markcowl
markcowl previously approved these changes May 2, 2017
View reviewed changes
@markcowl markcowl dismissed cormacpayne’s stale review May 2, 2017 05:52

These changes are OK

@markcowl
Copy link
Member

markcowl commented May 2, 2017 •
edited
Loading

on demand run here: http://azuresdkci.cloudapp.net/view/1-AzurePowerShell/job/powershell-demand/1514/

Merge branch 'preview' of https://github.com/Azure/azure-powershell i…
93977b2 
…nto EHFixes

# Conflicts:
#	tools/StaticAnalysis/Exceptions/BreakingChangeIssues.csv
@markcowl
Copy link
Member

markcowl commented May 2, 2017

on demand run here: http://azuresdkci.cloudapp.net/view/1-AzurePowerShell/job/powershell-demand/1518/

@markcowl
Copy link
Member

markcowl commented May 2, 2017

@azuresdkci retest this please

@markcowl markcowl merged commit a9996d4 into Azure:preview May 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markcowl markcowl markcowl approved these changes

@cormacpayne cormacpayne cormacpayne left review comments

Assignees
No one assigned
Labels
Waiting for On Demand
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@v-Ajnava @markcowl @cormacpayne @azuresdkci @msftclas