adding support for backing up and restoring KeyVault secrets #3855
Conversation
|
Can one of the admins verify this patch? |
|
@dragav, |
|
Old PR: #3787 |
|
@azuresdkci add to whitelist |
| @@ -253,6 +255,10 @@ | |||
| <Project>{3819d8a7-c62c-4c47-8ddd-0332d9ce1252}</Project> | |||
| <Name>Commands.ResourceManager.Common</Name> | |||
| </ProjectReference> | |||
| <ProjectReference Include="..\..\Profile\Commands.Profile\Commands.Profile.csproj"> | |||
There was a problem hiding this comment.
Why do you need this reference?
There was a problem hiding this comment.
Please remove the reference to Commands.Profile, this is discouraged in cmdlet projects
There was a problem hiding this comment.
I think I added this reference so as not to duplicate the FileOverwrite messages. That couldn't be avoided, though. Reverted.
| @@ -10,8 +10,8 @@ | |||
|
|
|||
| namespace Microsoft.Azure.Commands.KeyVault.Properties { | |||
| using System; | |||
|
|
|||
|
|
|||
|
|
|||
There was a problem hiding this comment.
for resource.designer.cs and resource.resx there are additional space added that are unnecessary. Can you please revert them?
| public string BackupSecret( string vaultName, string secretName, string outputBlobPath ) | ||
| { | ||
| if ( string.IsNullOrEmpty( vaultName ) ) | ||
| throw new ArgumentNullException( "vaultName" ); |
There was a problem hiding this comment.
nit. use nameof(vaultName) instead.
| ParameterSetName = BySecretObjectParameterSet, | ||
| HelpMessage = "Output file. The output file to store the backed up secret blob in. If not present, a default filename is chosen." )] | ||
| [ValidateNotNullOrEmpty] | ||
| public string OutputFile { get; set; } |
There was a problem hiding this comment.
You don't need to parameters for the parameter sets as they have the same properties. Just remove ParameterSetName.
There was a problem hiding this comment.
Thanks; addressed in a subsequent commit, should show up shortly.
| @@ -253,6 +255,10 @@ | |||
| <Project>{3819d8a7-c62c-4c47-8ddd-0332d9ce1252}</Project> | |||
| <Name>Commands.ResourceManager.Common</Name> | |||
| </ProjectReference> | |||
| <ProjectReference Include="..\..\Profile\Commands.Profile\Commands.Profile.csproj"> | |||
There was a problem hiding this comment.
Please remove the reference to Commands.Profile, this is discouraged in cmdlet projects
|
@dragav There are merge conflicts, please update |
1 similar comment
|
@dragav There are merge conflicts, please update |
|
I picked up a bunch of commits following a faulty merge. Resubmitting a clean PR. |
adding support for backing up and restoring of KeyVault secrets
revising KeyVault backup/restore cmdlets:
adding support for pipelining
allowing overwriting of dest file
using session data store for file operations