Renamed chef-service-interval to chef-daemon-interval #3799
Conversation
piyushawasthi
commented
Apr 19, 2017
•
piyushawasthi
commented
- Renamed chef-service-interval to chef-daemon-interval.
- Fixed failing tests.
|
@piyushawasthi, It will cover your contributions to all Microsoft-managed open source projects. |
|
Can one of the admins verify this patch? |
|
@piyushawasthi you will need to sign the CLA, or, if you are internal, follow the process here: http://aka.ms/azuregithub before we can look at this PR |
|
@piyushawasthi, thanks for signing the contribution license agreement. We will now validate the agreement and then the pull request. |
|
@markcowl - I have signed the CLA, Thanks a lot for your help. |
|
@azuresdkci add to whitelist @twitchax @singhkays We ened a reviewer for this VM extention |
|
This cmdlet is written by the Chef team. Adding @NimishaS for review. |
|
Testing the PR. |
|
@piyushawasthi would you mind pulling the latest changes from the |
piyushawasthi
force-pushed
the
piyush/chef_daemon_interval
branch
from
2cad248 to
e499056
Compare
|
@cormacpayne - Re-base branch from updated "preview" branch and resolved the conflict. Also verified using ARM and ASM command -ChefDaemonInterval getting set properly. |
| @@ -78,7 +78,7 @@ public class SetAzureVMChefExtensionCommand : VirtualMachineChefExtensionCmdletB | |||
| ValueFromPipelineByPropertyName = true, | |||
| HelpMessage = "Specifies the frequency (in minutes) at which the chef-service runs. If in case you don't want the chef-service to be installed on the Azure VM then set value as 0 in this field.")] | |||
| [ValidateNotNullOrEmpty] | |||
| public string ChefServiceInterval { get; set; } | |||
| public string ChefDaemonInterval { get; set; } | |||
There was a problem hiding this comment.
Can you add an alias here so that old scripts will not break?
| @@ -30873,7 +30873,7 @@ | |||
| "ValidateNotNullOrEmpty": true | |||
There was a problem hiding this comment.
If you add the alias, there would be no breaking change here. If it turns out you do need a breaking change, please add a suppression here: https://github.com/Azure/azure-powershell/blob/preview/tools/StaticAnalysis/Exceptions/BreakingChangeIssues.csv
Rather than updating this json file.
There was a problem hiding this comment.
Please remove this change, and please add a description of the change (the new parameter) to the Changelog.md for your module, here: https://github.com/Azure/azure-powershell/blob/preview/src/ResourceManager/Compute/ChangeLog.md
|
@piyushawasthi A couple of changes, otherwise LGTM |
There was a problem hiding this comment.
Looks good. Please remove the change to the json file, as specified, and please add a comment on the change to the chngelog here: https://github.com/Azure/azure-powershell/blob/preview/src/ResourceManager/Compute/ChangeLog.md as specified.
| @@ -30873,7 +30873,7 @@ | |||
| "ValidateNotNullOrEmpty": true | |||
There was a problem hiding this comment.
Please remove this change, and please add a description of the change (the new parameter) to the Changelog.md for your module, here: https://github.com/Azure/azure-powershell/blob/preview/src/ResourceManager/Compute/ChangeLog.md
|
@piyushawasthi Please remove the json changes and add changelog summary for changes and this will be ready to merge |
piyushawasthi
force-pushed
the
piyush/chef_daemon_interval
branch
2 times, most recently
from
09d3449 to
7b89303
Compare
Signed-off-by: piyushawasthi <[email protected]>
Signed-off-by: piyushawasthi <[email protected]>
piyushawasthi
force-pushed
the
piyush/chef_daemon_interval
branch
from
7b89303 to
910a2b7
Compare
Signed-off-by: piyushawasthi <[email protected]>
|
@markcowl : Update changes as per your comment. |
piyushawasthi
force-pushed
the
piyush/chef_daemon_interval
branch
from
7e6aec0 to
75a9cda
Compare
