-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Assembly loading improvements #20196
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isra-fel
force-pushed
the
yeming/assembly-loading
branch
from
November 23, 2022 07:51
baee16a
to
77d88d2
Compare
isra-fel
force-pushed
the
yeming/assembly-loading
branch
2 times, most recently
from
December 5, 2022 06:39
7cdda32
to
26f3e9a
Compare
/azp run |
Azure Pipelines successfully started running 3 pipeline(s). |
isra-fel
force-pushed
the
yeming/assembly-loading
branch
from
December 8, 2022 03:12
3d2a6db
to
bdd5297
Compare
isra-fel
force-pushed
the
yeming/assembly-loading
branch
from
December 9, 2022 06:14
79352ab
to
552920a
Compare
isra-fel
commented
Dec 15, 2022
Comment on lines
-26
to
-29
<Target Name="CopyFiles" AfterTargets="Build"> | ||
<Copy SourceFiles="@(PreLoadAssemblies)" DestinationFolder="$(TargetDir)\PreloadAssemblies" /> | ||
<Copy SourceFiles="@(NetCoreAssemblies)" DestinationFolder="$(TargetDir)\NetCoreAssemblies" /> | ||
</Target> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wyunchi-ms
reviewed
Dec 27, 2022
src/Accounts/AuthenticationAssemblyLoadContext/AzAssemblyLoadContextBase.cs
Show resolved
Hide resolved
src/Accounts/AuthenticationAssemblyLoadContext/AzSharedAssemblyLoadContext.cs
Show resolved
Hide resolved
wyunchi-ms
approved these changes
Dec 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Azure.Identity.dll
is removed.Design
The core implementation is a new project named
AssemblyLoading
(and a new assemblyMicrosoft.Azure.PowerShell.AssemblyLoading
) in Az.Accounts module. The two assembly loadersCustomeAssemblyLoader
andAzAssemblyLoadContext
will depend on this project to provide the list of assemblies to load according to the environment.Checklist
CONTRIBUTING.md
and reviewed the following information:generation
branch.ChangeLog.md
file(s) appropriatelyChangeLog.md
file can be found atsrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
## Upcoming Release
header in the past tense. Add changelog in description section if PR goes intogeneration
branch.ChangeLog.md
if no new release is required, such as fixing test case only.