Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in ASRVaultSettings class #18645

Closed
wants to merge 2 commits into from
Closed

Conversation

anwather
Copy link
Contributor

@anwather anwather commented Jun 21, 2022

Fixed type in ASRVaultSettings class

Description

Fix typo in ASRVaultSettings class

Checklist

  • I have read the Submitting Changes section of CONTRIBUTING.md
  • The title of the PR is clear and informative
  • The appropriate ChangeLog.md file(s) has been updated:
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
  • The PR does not introduce breaking changes
  • If applicable, the changes made in the PR have proper test coverage
  • For public API changes to cmdlets:
    • a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
      • {Please put the link here}
    • the markdown help files have been regenerated using the commands listed here

Fixed type in ASRVaultSettings class
@ghost ghost added the customer-reported label Jun 21, 2022
@ghost
Copy link

ghost commented Jun 21, 2022

Thank you for your contribution anwather! We will review the pull request and get back to you soon.

@anwather anwather changed the title Update PSObjects.cs Fix typo in ASRVaultSettings class Jun 21, 2022
@VeryEarly VeryEarly self-assigned this Jun 27, 2022
@VeryEarly
Copy link
Contributor

Hi @anwather ,
Thanks for you contribution, however this change is considered breaking change and can be released only at major releases (twice a year).
I have created issue: #18742 to track this, please feel free to add comments

@BethanyZhou BethanyZhou added the needs-author-feedback More information is needed from author to address the issue. label Jul 20, 2022
@isra-fel isra-fel assigned isra-fel and unassigned VeryEarly Aug 2, 2022
@isra-fel isra-fel added needs-revision Breaking Change Release This PR contains breaking change and removed needs-author-feedback More information is needed from author to address the issue. labels Aug 2, 2022
@msJinLei msJinLei added Recovery Services Site-Recovery Service Attention This issue is responsible by Azure service team. labels Apr 26, 2023
@msJinLei
Copy link
Contributor

@service team,, do you want to release the breaking change fix in this PR.

@msJinLei msJinLei removed the Service Attention This issue is responsible by Azure service team. label May 12, 2023
@msJinLei
Copy link
Contributor

/azp run

@msJinLei
Copy link
Contributor

/azp run azure-powershell - powershell-core

@msJinLei msJinLei assigned anwather and unassigned isra-fel May 12, 2023
@wyunchi-ms
Copy link
Contributor

/azp run

@wyunchi-ms
Copy link
Contributor

Will included in #23873

@YanaXu YanaXu closed this Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants