Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Storage TestController #18470

Merged
merged 4 commits into from
Jun 17, 2022
Merged

Remove Storage TestController #18470

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d45b0c1
Remove TestController
ziyuezh576 Jun 7, 2022
1ca5ded
Update StorageBlobTests.cs
ziyuezh576 Jun 8, 2022
4379d22
Update StorageTestRunner.cs
ziyuezh576 Jun 13, 2022
500747e
Update StorageTestRunner.cs
ziyuezh576 Jun 14, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/Storage/Storage.Management.Test/ScenarioTests/StorageTestRunner.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@
// ----------------------------------------------------------------------------------

using Microsoft.Azure.Commands.TestFx;
using Microsoft.WindowsAzure.Commands.ScenarioTest;
using Xunit.Abstractions;

namespace Microsoft.Azure.Commands.Management.Storage.Test
Expand All @@ -31,6 +32,9 @@ protected StorageTestRunner(ITestOutputHelper output)
@"Common.ps1",
@"../AzureRM.Resources.ps1"
})
.WithRecordMatcher((ignoreResourcesClient, resourceProviders, userAgentsToIgnore) =>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What I mean is the record matcher arguments instead of the matcher itself. In the test controller, there are arguments for the matcher, also need to pass in these arguments in the test runner. The WithRecordMatcher invocation here can be removed as it only instantiated the default matcher.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I didn't notice "arguments".

new PermissiveRecordMatcherWithApiExclusion(ignoreResourcesClient, resourceProviders, userAgentsToIgnore)
)
.WithNewRmModules(helper => new[]
{
helper.RMProfileModule,
Expand Down