Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADDomainService]Changed the input method of certificate from base64 string to file path #18282

Merged
merged 2 commits into from
May 25, 2022

Conversation

BethanyZhou
Copy link
Contributor

Description

Changelog: Changed the input method of certificate from base64 string to file path

Checklist

  • I have read the Submitting Changes section of CONTRIBUTING.md
  • The title of the PR is clear and informative
  • The appropriate ChangeLog.md file(s) has been updated:
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
  • The PR does not introduce breaking changes
  • If applicable, the changes made in the PR have proper test coverage
  • For public API changes to cmdlets:
    • a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
      • {Please put the link here}
    • the markdown help files have been regenerated using the commands listed here

@BethanyZhou BethanyZhou changed the title Changed the input method of certificate from base64 string to file path [ADDomainService]Changed the input method of certificate from base64 string to file path May 24, 2022
@@ -58,6 +59,9 @@ directive:
- from: swagger-document
where: $.definitions..trustPassword
transform: $.format = "password"
- from: swagger-document
where: $.definitions..pfxCertificate
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should it be
$.definitions.LdapsSettings.pfxCertificate ?

Copy link
Contributor Author

@BethanyZhou BethanyZhou May 25, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. $.definitions..pfxCertificate means $.definitions.*.pfxCertificate. It works as well.

@VeryEarly
Copy link
Contributor

seems like two cmdlet are renamed without alias, can you please confirm

@VeryEarly VeryEarly self-assigned this May 25, 2022
@BethanyZhou
Copy link
Contributor Author

Yes. Renaming these two cmdlets without alias is expected. Renamed 'New-AzADDomainServiceForestTrust'->'New-AzADDomainServiceForestTrustObject and 'New-AzADDomainServiceReplicaSet' -> 'New-AzADDomainServiceReplicaSetObject' to align with our naming convention. And Az.ADDomainService is under preview. I guess these changes should be fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]: Support New/Update-AzADDomainService -LdapSettingPfxCertificate accepting certificate path
2 participants