Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing GetViaIdentity1 in Get-AzVmRuncommand For Fixing generation branch #16328

Merged
merged 14 commits into from
Nov 3, 2021

Conversation

haagha
Copy link
Member

@haagha haagha commented Nov 2, 2021

Fixing this CI check failure:
Parameter set 'GetViaIdentity1', 'GetViaIdentity' of cmdlet 'Get-AzVMRunCommand' have the same mandatory parameters, and both of them are not default parameter set which may cause confusion

Removing GetViaIdentity1 for Get-AzVMRunCommand

Checklist

  • I have read the Submitting Changes section of CONTRIBUTING.md
  • The title of the PR is clear and informative
  • The appropriate ChangeLog.md file(s) has been updated:
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
  • The PR does not introduce breaking changes
  • If applicable, the changes made in the PR have proper test coverage
  • For public API changes to cmdlets:
    • a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
      • {Please put the link here}
    • the markdown help files have been regenerated using the commands listed here

@haagha haagha changed the title Removing GetViaIdentity1 in Get-AzVmRuncommand Removing GetViaIdentity1 in Get-AzVmRuncommand For Fixing generation branch Nov 2, 2021
@haagha haagha requested a review from isra-fel November 2, 2021 23:20
Copy link
Member

@isra-fel isra-fel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@isra-fel isra-fel merged commit f9b6dea into generation Nov 3, 2021
isra-fel added a commit to isra-fel/azure-powershell that referenced this pull request Nov 3, 2021
isra-fel added a commit that referenced this pull request Nov 3, 2021
* generated  files

* manual updates

* pick #16328
@wyunchi-ms wyunchi-ms deleted the computegen-ignite branch January 10, 2024 01:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants