Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix parameter name in examples #15493

Merged
merged 1 commit into from
Jul 20, 2021
Merged

Fix parameter name in examples #15493

merged 1 commit into from
Jul 20, 2021

Conversation

pascalberger
Copy link
Contributor

Description

VirtualNetwork parameter is ambiguous between VirtualNetworkName and VirtualNetworkPeering. This PR changes examples to use VirtualNetworkName parameter.

Checklist

  • I have read the Submitting Changes section of CONTRIBUTING.md
  • The title of the PR is clear and informative
  • The appropriate ChangeLog.md file(s) has been updated:
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
  • The PR does not introduce breaking changes
  • If applicable, the changes made in the PR have proper test coverage
  • For public API changes to cmdlets:
    • a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
      • {Please put the link here}
    • the markdown help files have been regenerated using the commands listed here

@ghost
Copy link

ghost commented Jul 19, 2021

Thank you for your contribution pascalberger! We will review the pull request and get back to you soon.

Copy link
Member

@isra-fel isra-fel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! Looks good to me.
cc @harics24

@isra-fel isra-fel merged commit 733bfa8 into Azure:main Jul 20, 2021
@pascalberger pascalberger deleted the patch-1 branch July 27, 2021 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants