Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Peering] Add API version 2020-10-01 #14714

Merged
merged 16 commits into from
Apr 20, 2021
Merged

[Peering] Add API version 2020-10-01 #14714

Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
89f56bb
2020-10-01 api changes
Mar 18, 2021
41a951b
Resolved conflicts
Mar 18, 2021
b540be6
Fixing UT
Mar 29, 2021
b33eba2
Merge branch 'master' of https://github.com/Azure/azure-powershell
Mar 29, 2021
8ea6c21
Revert incorrect changes
Mar 30, 2021
d229c48
Cmdlet name change
Mar 30, 2021
b584a3e
fix UTs
Apr 5, 2021
54ba7d5
Fix UTs
Apr 8, 2021
80d93c4
Help file online version url
Apr 8, 2021
0688de5
Help file online version url
Apr 8, 2021
1c19a03
Updating recorded test files
Apr 9, 2021
47aa201
Recorded tests
Apr 9, 2021
e1746e2
Using AzPsException
Apr 12, 2021
6136484
Addressed review comment
Apr 15, 2021
c9336f1
Addressed comment
Apr 16, 2021
457fd50
Update ChangeLog.md
VeryEarly Apr 19, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions src/Peering/Peering/Common/PeeringBaseCmdlet.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ namespace Microsoft.Azure.PowerShell.Cmdlets.Peering.Common

using Microsoft.Azure.Commands.Common.Authentication;
using Microsoft.Azure.Commands.Common.Authentication.Abstractions;
using Microsoft.Azure.Commands.Common.Exceptions;
using Microsoft.Azure.Commands.Peering.Properties;
using Microsoft.Azure.Commands.ResourceManager.Common;
using Microsoft.Azure.Management.Peering;
Expand Down Expand Up @@ -318,9 +319,9 @@ public PSCdnPeeringPrefix ToPSCdnPeeringPrefix(object cdnPrefix)
{
return PeeringResourceManagerProfile.Mapper.Map<PSCdnPeeringPrefix>(cdnPrefix);
}
catch (InvalidOperationException mapException)
catch (AzPSInvalidOperationException mapException)
Copy link
Contributor

@VeryEarly VeryEarly Apr 15, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should still be InvalidOperationException

{
throw new InvalidOperationException(String.Format(Resources.Error_Mapping, mapException));
throw new AzPSInvalidOperationException(String.Format(Resources.Error_Mapping, mapException));
}
}

Expand All @@ -339,10 +340,10 @@ public bool ValidBandwidth(int? bandwidthInMbps)
{
this.WriteVerbose($"validating bandwidth: {bandwidthInMbps}");
if (bandwidthInMbps <= 0)
throw new PSArgumentException(string.Format(Resources.Error_BandwidthTooLow, bandwidthInMbps));
throw new AzPSArgumentException(string.Format(Resources.Error_BandwidthTooLow, bandwidthInMbps), "bandwidthInMbps");
if (bandwidthInMbps % Constants.MinRange != 0)
throw new PSArgumentException(
string.Format(Resources.Error_BandwidthIncorrectFormat, bandwidthInMbps, Constants.MinRange));
throw new AzPSArgumentOutOfRangeException(
string.Format(Resources.Error_BandwidthIncorrectFormat, bandwidthInMbps, Constants.MinRange), "bandwidthInMbps");
return true;
}

Expand Down