Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Error in Get-AzAutomationDscNode Example 1 #13307

Merged
merged 1 commit into from
Oct 26, 2020
Merged

Conversation

DominicJ2
Copy link
Contributor

@DominicJ2 DominicJ2 commented Oct 22, 2020

In Example 1, there is a different string passed for the ResourceGroupName in the first function call and the second function call. This string should be the same value for both function calls. All of the other examples use the ResourceGroupName ResourceGroup03, so I swapped to use that as the correct value.

Description

Checklist

  • I have read the Submitting Changes section of CONTRIBUTING.md
  • The title of the PR is clear and informative
  • The appropriate ChangeLog.md file(s) has been updated:
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
  • The PR does not introduce breaking changes
  • If applicable, the changes made in the PR have proper test coverage
  • For public API changes to cmdlets:
    • a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
    • the markdown help files have been regenerated using the commands listed here

In Example 1, there is a different string passed for the ResourceGroupName in the first function call and the second function call. This string should be the same value for both function calls. All of the other examples use the ResourceGroupName `ResourceGroup03`, so I swapped to use that as the correct value.
@DominicJ2
Copy link
Contributor Author

In Example 1, there is a different string passed for the ResourceGroupName in the first function call and the second function call. This string should be the same value for both function calls. All of the other examples use the ResourceGroupName ResourceGroup03, so I swapped to use that as the correct value.

Copy link
Member

@isra-fel isra-fel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense. Thanks for your contribution 👍

@isra-fel isra-fel self-assigned this Oct 23, 2020
@isra-fel
Copy link
Member

/azp run

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

@isra-fel isra-fel merged commit 9631cb1 into master Oct 26, 2020
@isra-fel isra-fel deleted the DominicJ2-patch-1 branch October 26, 2020 03:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants