Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Audit policy] Set-AzSqlDatabaseAudit - support Hyperscale database #13290

Merged
merged 6 commits into from
Oct 22, 2020
Merged

[Audit policy] Set-AzSqlDatabaseAudit - support Hyperscale database #13290

merged 6 commits into from
Oct 22, 2020

Conversation

OlegSternbergIBM
Copy link
Contributor

@OlegSternbergIBM OlegSternbergIBM commented Oct 21, 2020 •
edited by bashahee
Loading

Fix in Set-AzSqlDatabaseAudit - support Hyperscale database
Show descriptive error when database edition cannot be determined

Description

Checklist

  • I have read the Submitting Changes section of CONTRIBUTING.md
  • The title of the PR is clear and informative
  • The appropriate ChangeLog.md file(s) has been updated:
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
  • The PR does not introduce breaking changes
  • If applicable, the changes made in the PR have proper test coverage
  • For public API changes to cmdlets:
    • a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
    • the markdown help files have been regenerated using the commands listed here

Oleg Sternberg added 2 commits October 21, 2020 14:20
Fix in Set-AzSqlDatabaseAudit - support Hyperscale database
ca0b8d7 
Show descriptive error when database edition cannot be determined
Update ChangeLog.md
10d9853
@ghost ghost added the customer-reported label Oct 21, 2020
@ghost
Copy link

ghost commented Oct 21, 2020

Thank you for your contribution Oleza1972! We will review the pull request and get back to you soon.

@bashahee bashahee self-requested a review October 22, 2020 06:21
@isra-fel
Copy link
Member

Hi @Oleza1972 if you are a Microsoft employee please join Azure orgnization on https://aka.ms/AzureGithub so that CI can be automatically triggered.

@isra-fel
Update changelog...
a439a91 
...move the changelog to the to of "upcoming release" to prevent merging issue in next sprint
@isra-fel isra-fel self-assigned this Oct 22, 2020
@OlegSternbergIBM
Copy link
Contributor Author

Hi @Oleza1972 if you are a Microsoft employee please join Azure orgnization on https://aka.ms/AzureGithub so that CI can be automatically triggered.

Done

@isra-fel
Copy link
Member

/azp run

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

isra-fel
isra-fel approved these changes Oct 22, 2020
View reviewed changes
Copy link
Member

@isra-fel isra-fel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Pending @bashahee 's approval

@bashahee bashahee requested review from bashahee and removed request for bashahee October 22, 2020 09:45
@bashahee
Copy link
Contributor

@isra-fel Please merge :)

@isra-fel isra-fel merged commit 07592f4 into Azure:master Oct 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bashahee bashahee bashahee approved these changes

@isra-fel isra-fel isra-fel approved these changes

Assignees

@isra-fel isra-fel

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@OlegSternbergIBM @isra-fel @bashahee @azuresdkci