Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generate flexible server cmdlets #13269

Merged
merged 1 commit into from
Oct 26, 2020
Merged

Generate flexible server cmdlets #13269

merged 1 commit into from
Oct 26, 2020

Conversation

msJinLei
Copy link
Contributor

Description

Checklist

  • I have read the Submitting Changes section of CONTRIBUTING.md
  • The title of the PR is clear and informative
  • The appropriate ChangeLog.md file(s) has been updated:
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
  • The PR does not introduce breaking changes
  • If applicable, the changes made in the PR have proper test coverage
  • For public API changes to cmdlets:
    • a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
    • the markdown help files have been regenerated using the commands listed here

@msJinLei msJinLei changed the base branch from generation to share/mysql October 22, 2020 05:17
@msJinLei msJinLei requested a review from DaeunYim October 22, 2020 05:39
@msJinLei msJinLei marked this pull request as ready for review October 22, 2020 05:39
DaeunYim
DaeunYim reviewed Oct 23, 2020
View reviewed changes
src/MySql/readme.md
require:
- $(this-folder)/../readme.azure.noprofile.md
input-file:
- $(repo)/specification/mysql/resource-manager/Microsoft.DBforMySQL/stable/2017-12-01/mysql.json
- $(repo)/specification/mysql/resource-manager/Microsoft.DBforMySQL/stable/2017-12-01/ServerSecurityAlertPolicies.json
- $(repo)/specification/mysql/resource-manager/Microsoft.DBforMySQL/preview/2020-07-01-preview/mysql.json
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we also include these as well?

  • Microsoft.DBforPostgreSQL/stable/2018-06-01/PrivateEndpointConnections.json
  • Microsoft.DBforPostgreSQL/stable/2018-06-01/PrivateLinkResources.json
  • Microsoft.DBforPostgreSQL/stable/2020-01-01/DataEncryptionKeys.json
    These are single server APIs

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you mean to add PrivateEndpointConnections.json, PrivateLinkResources.json, DataEncryptionKeys.json in Microsoft.DBforMySQL?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh I meant, including those json files to the input file section to enable the missing single server commands. I can work on it later after adding flexible-server functionality

src/MySql/readme.md
set:
verb: Update
- where:
subject: Database$|SecurityAlertPolicy$|Administrator$|LocationBasedPerformanceTier$|LogFile$|ExecuteCheckNameAvailability$
subject: ^Database$|^LocationBasedPerformanceTier$|^LogFile$|SecurityAlertPolicy$|Administrator$
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mentioned this in the follow-up email as well but could you kindly explain to me why we are hiding these cmdlets? We have equivalent commands to these in CLI.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These cmdlets are not in high priority. Our team has limited resources and so we first implement the most important cmdlets and then gradually add more thing according to the user feedback.

src/MySql/readme.md
module-version: 0.1.0
title: MySQL
subject-prefix: 'MySQL'

directive:
- from: mysql.json
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need PG flexible server as well..! Could you do the same generation for postgresql as well?

Single server"input-file:

  • Microsoft.DBforPostgreSQL/stable/2017-12-01/postgresql.json
  • Microsoft.DBforPostgreSQL/stable/2017-12-01/ServerSecurityAlertPolicies.json
  • Microsoft.DBforPostgreSQL/stable/2018-06-01/PrivateEndpointConnections.json
  • Microsoft.DBforPostgreSQL/stable/2018-06-01/PrivateLinkResources.json
  • Microsoft.DBforPostgreSQL/stable/2020-01-01/DataEncryptionKeys.json

flexible server
input-file:

  • Microsoft.DBforPostgreSQL/preview/2020-02-14-preview/postgresql.json

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, we will do the same thing for postgresql. But let's firstly try everything in mysql and ensure them to work and then we are migrate them to postgresql quickly.

@msJinLei msJinLei merged commit d9d5efc into Azure:share/mysql Oct 26, 2020
msJinLei added a commit that referenced this pull request Nov 30, 2020
@DaeunYim @msJinLei
Add flexible commands to MySql modules (#13551)
4fd9e51 
* Generate flexible server cmdlets (#13269)

* test commit with server mgmt md files

* cmdlet design draft

* fixed errors for mysql md files

* fixed errors for mysql md files

* fixing mistakes

* resolved comments

* mysql cmdlets customization verified

* mysql modified

* postgres customized cmdlets and readme

* mysql postgres customized cmdlets and docs

* initial commit for mysql pg module

* mysql test success

* pg module

* postgresql cmdlet update test fixed

* example document fixed

* Revert "example document fixed"

This reverts commit 6c60dbf.

* align single server test with flexible server

* docs fixed

* docs files moved from exports to upper folder

* typo fixed

* revert postgresql

* configuration fixed

* cred scan added

* cred scan issue resolved

* Regenerate doc of the MySql

* comments resolved

Co-authored-by: Jin Lei <[email protected]>
Co-authored-by: msJinLei <[email protected]>
msJinLei added a commit that referenced this pull request Dec 1, 2020
@DaeunYim @msJinLei
Added description and synopsis for mysql cmdlets (#13626)
976d44f 
* Generate flexible server cmdlets (#13269)

* test commit with server mgmt md files

* cmdlet design draft

* fixed errors for mysql md files

* fixed errors for mysql md files

* fixing mistakes

* resolved comments

* mysql cmdlets customization verified

* mysql modified

* postgres customized cmdlets and readme

* mysql postgres customized cmdlets and docs

* initial commit for mysql pg module

* mysql test success

* pg module

* postgresql cmdlet update test fixed

* example document fixed

* Revert "example document fixed"

This reverts commit 6c60dbf.

* align single server test with flexible server

* docs fixed

* docs files moved from exports to upper folder

* typo fixed

* revert postgresql

* configuration fixed

* cred scan added

* cred scan issue resolved

* Regenerate doc of the MySql

* comments resolved

* synopsis and description added

* Fix MySql doc issues

* Revert examples/New-AzMySqlVirtualNetworkRule.md incorrect change
* Update doc/*.md

Co-authored-by: Jin Lei <[email protected]>
Co-authored-by: msJinLei <[email protected]>
msJinLei added a commit that referenced this pull request Jan 6, 2021
@DaeunYim @msJinLei
Changed MySql New-AzMySqlFlexibleServer cmdlet and Added Get-AzMySqlF…
3fd53f6 
…lexibleServerLocationBasedCapability (#13717)

* Generate flexible server cmdlets (#13269)

* test commit with server mgmt md files

* cmdlet design draft

* fixed errors for mysql md files

* fixed errors for mysql md files

* fixing mistakes

* resolved comments

* mysql cmdlets customization verified

* mysql modified

* postgres customized cmdlets and readme

* mysql postgres customized cmdlets and docs

* initial commit for mysql pg module

* mysql test success

* pg module

* postgresql cmdlet update test fixed

* example document fixed

* Revert "example document fixed"

This reverts commit 6c60dbf.

* align single server test with flexible server

* docs fixed

* docs files moved from exports to upper folder

* typo fixed

* revert postgresql

* configuration fixed

* cred scan added

* cred scan issue resolved

* Regenerate doc of the MySql

* comments resolved

* initial network commit

* create customization

* test record

* utils issue fixed

* test ci fix

* CI failure fix

* testing CI fix

* CI test faliure fixing

* CI test fix final

* new server doc fix

* mysql comments resolved

* comments resolved

* CI test fixed

* Remove skip in test cases

* testing env config fixed

* testing env config fixed

* test fixed with flexible arguments

* location changed from westus2 to eastus2euap

* resource group name changed

* customized server object for creation cmdlet

* Update FlexibleServer.cs

Fixed typo

* dynamically assign a server name for live testing

* dynamically assign live test variables

* if else case consistent

Co-authored-by: Jin Lei <[email protected]>
Co-authored-by: msJinLei <[email protected]>
msJinLei added a commit that referenced this pull request Jan 8, 2021
@DaeunYim @msJinLei
Changed PostgreSql New-AzPostgreSqlFlexibleServer cmdlet and Added Ge…
b08bf81 
…t-AzPostgreSqlFlexibleServerLocationBasedCapability (#13716)

* Generate flexible server cmdlets (#13269)

* test commit with server mgmt md files

* cmdlet design draft

* fixed errors for mysql md files

* fixed errors for mysql md files

* fixing mistakes

* resolved comments

* mysql cmdlets customization verified

* mysql modified

* postgres customized cmdlets and readme

* mysql postgres customized cmdlets and docs

* initial commit for mysql pg module

* mysql test success

* pg module

* postgresql cmdlet update test fixed

* example document fixed

* Revert "example document fixed"

This reverts commit 6c60dbf.

* align single server test with flexible server

* docs fixed

* docs files moved from exports to upper folder

* typo fixed

* reverted mysql flexible server

* configuration update doc resolved

* cred scan fixed

* copied from generation branch

* Fix the format of cmdlet help files

* Fixed bugs

* comments resolved

* initial commit for customization

* test recorded

* test pass fix

* utils CI fix

* CI test fix

* postgresql comments resolved

* minor fix for location capabilities

* CI fixed

* utils included

* test fixed for live testing

* customized server object

* dynamically assign server name for live testing

* dynamically assign live test variables

* if else case consistent

* comments resolved

* change autorest version

Co-authored-by: Jin Lei <[email protected]>
Co-authored-by: msJinLei <[email protected]>
@msJinLei msJinLei deleted the share_mysql branch January 14, 2021 05:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DaeunYim DaeunYim DaeunYim left review comments

Assignees

@msJinLei msJinLei

@DaeunYim DaeunYim

Labels
needs-revision
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@msJinLei @DaeunYim @azuresdkci @isra-fel