Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Aks]Promised breaking changes #13252

Merged
merged 2 commits into from
Oct 20, 2020
Merged

[Aks]Promised breaking changes #13252

merged 2 commits into from
Oct 20, 2020

Conversation

wyunchi-ms
Copy link
Contributor

Description

Checklist

  • I have read the Submitting Changes section of CONTRIBUTING.md
  • The title of the PR is clear and informative
  • The appropriate ChangeLog.md file(s) has been updated:
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
  • The PR does not introduce breaking changes
  • If applicable, the changes made in the PR have proper test coverage
  • For public API changes to cmdlets:
    • a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
    • the markdown help files have been regenerated using the commands listed here

@wyunchi-ms wyunchi-ms requested a review from erich-wang October 18, 2020 03:31
dingmeng-xue
dingmeng-xue reviewed Oct 19, 2020
View reviewed changes
src/Aks/Aks/ChangeLog.md Outdated
@@ -18,6 +18,12 @@
- Additional information about change #1
-->
## Upcoming Release
* Removed cmdlet alias `Get-AzAks`, `New-AzAks`, `Remove-AzAks` and `Set-AzAks`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add [Breaking Change] prefix

@wyunchi-ms wyunchi-ms force-pushed the wyunchi/Aks/breaking-changes branch from 65d79b9 to 1fb8417 Compare October 19, 2020 07:23
@wyunchi-ms
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

@wyunchi-ms
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

@wyunchi-ms
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

@dingmeng-xue dingmeng-xue merged commit c3780dc into master Oct 20, 2020
@wyunchi-ms wyunchi-ms deleted the wyunchi/Aks/breaking-changes branch October 21, 2020 02:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dingmeng-xue dingmeng-xue dingmeng-xue approved these changes

@erich-wang erich-wang Awaiting requested review from erich-wang

Assignees
No one assigned
Labels
needs-review
Projects
None yet
Milestone
S177 (2020-10-27) Major Release
Development

Successfully merging this pull request may close these issues.
3 participants
@wyunchi-ms @dingmeng-xue @azuresdkci