Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make "Connectionlink" argument mandatory in start-azVpnConnectionPacketCapture and Stop-AzVpnConnectionPacketCapture #13208

Merged
merged 11 commits into from
Oct 21, 2020
Merged

Make "Connectionlink" argument mandatory in start-azVpnConnectionPacketCapture and Stop-AzVpnConnectionPacketCapture #13208

Show file tree
Hide file tree
Changes from 10 commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
e8f5a98
finish
jiaczh Oct 13, 2020
c92b940
Merge branch 'release-2020-10-27' into master
VeryEarly Oct 21, 2020
3ac2148
Merge branch 'release-2020-10-27' into master
VeryEarly Oct 21, 2020
f8e78d5
Merge branch 'release-2020-10-27' into master
VeryEarly Oct 21, 2020
8080c05
add file
jiaczh Oct 21, 2020
c2decbf
Merge branch 'master' of https://github.com/jiaczh/azure-powershell i…
jiaczh Oct 21, 2020
63e5526
add files
jiaczh Oct 21, 2020
e09e60f
Merge branch 'master' of https://github.com/jiaczh/azure-powershell i…
jiaczh Oct 21, 2020
d37c971
Revert "add file"
jiaczh Oct 21, 2020
5d780bc
add files
jiaczh Oct 21, 2020
0c920d7
Update ChangeLog.md
dingmeng-xue Oct 21, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/Network/Network/ChangeLog.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@
- Added parameter `-SkuTier`
- Added parameter `-SkuName` and made Sku as Alias for this
- Removed parameter `-Sku`
* [Breaking Change] Make "Connectionlink" argument mandatory in start-azVpnConnectionPacketCapture and Stop-AzVpnConnectionPacketCapture

## Version 3.5.0
* Added Office365 Policy to VPNSite Resource
Expand Down
2 changes: 1 addition & 1 deletion src/Network/Network/Cortex/VpnConnection/StartAzVpnConnectionPacketCaptureCommand.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ public class StartAzVpnConnectionPacketCaptureCommand : VpnConnectionBaseCmdlet
public string FilterData { get; set; }

[Parameter(
Mandatory = false,
Mandatory = true,
HelpMessage = "VpnSiteLink Name of Vpn Connection to start packet capture on Vpn connection.")]
public string LinkConnectionName { get; set; }

Expand Down
2 changes: 1 addition & 1 deletion src/Network/Network/Cortex/VpnConnection/StopAzVpnConnectionPacketCaptureCommand.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ public class StopAzVpnConnectionPacketCaptureCommand : VpnConnectionBaseCmdlet
public string ResourceId { get; set; }

[Parameter(
Mandatory = false,
Mandatory = true,
HelpMessage = "VpnSiteLink of Vpn Connection to start packet capture on Vpn connection.")]
public string LinkConnectionName { get; set; }

Expand Down
8 changes: 4 additions & 4 deletions src/Network/Network/help/Start-AzVpnConnectionPacketCapture.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,20 +15,20 @@ Starts Packet Capture Operation on a Vpn Connection.
### ByVpnConnectionName (Default)
```
Start-AzVpnConnectionPacketCapture -ResourceGroupName <String> -ParentResourceName <String> -Name <String>
[-FilterData <String>] [-LinkConnectionName <String>] [-AsJob] [-DefaultProfile <IAzureContextContainer>]
[-FilterData <String>] -LinkConnectionName <String> [-AsJob] [-DefaultProfile <IAzureContextContainer>]
[-WhatIf] [-Confirm] [<CommonParameters>]
```

### ByVpnConnectionObject
```
Start-AzVpnConnectionPacketCapture -InputObject <PSVpnConnection> [-FilterData <String>]
[-LinkConnectionName <String>] [-AsJob] [-DefaultProfile <IAzureContextContainer>] [-WhatIf] [-Confirm]
-LinkConnectionName <String> [-AsJob] [-DefaultProfile <IAzureContextContainer>] [-WhatIf] [-Confirm]
[<CommonParameters>]
```

### ByVpnConnectionResourceId
```
Start-AzVpnConnectionPacketCapture -ResourceId <String> [-FilterData <String>] [-LinkConnectionName <String>]
Start-AzVpnConnectionPacketCapture -ResourceId <String> [-FilterData <String>] -LinkConnectionName <String>
[-AsJob] [-DefaultProfile <IAzureContextContainer>] [-WhatIf] [-Confirm] [<CommonParameters>]
```

Expand Down Expand Up @@ -146,7 +146,7 @@ Type: System.String
Parameter Sets: (All)
Aliases:

Required: False
Required: True
Position: Named
Default value: None
Accept pipeline input: False
Expand Down
10 changes: 5 additions & 5 deletions src/Network/Network/help/Stop-AzVpnConnectionPacketCapture.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,19 +15,19 @@ Stops Packet Capture Operation on a Vpn connection
### ByVpnConnectionName (Default)
```
Stop-AzVpnConnectionPacketCapture -ResourceGroupName <String> -ParentResourceName <String> -Name <String>
[-LinkConnectionName <String>] -SasUrl <String> [-AsJob] [-DefaultProfile <IAzureContextContainer>] [-WhatIf]
-LinkConnectionName <String> -SasUrl <String> [-AsJob] [-DefaultProfile <IAzureContextContainer>] [-WhatIf]
[-Confirm] [<CommonParameters>]
```

### ByVpnConnectionObject
```
Stop-AzVpnConnectionPacketCapture -InputObject <PSVpnConnection> [-LinkConnectionName <String>]
-SasUrl <String> [-AsJob] [-DefaultProfile <IAzureContextContainer>] [-WhatIf] [-Confirm] [<CommonParameters>]
Stop-AzVpnConnectionPacketCapture -InputObject <PSVpnConnection> -LinkConnectionName <String> -SasUrl <String>
[-AsJob] [-DefaultProfile <IAzureContextContainer>] [-WhatIf] [-Confirm] [<CommonParameters>]
```

### ByVpnConnectionResourceId
```
Stop-AzVpnConnectionPacketCapture -ResourceId <String> [-LinkConnectionName <String>] -SasUrl <String> [-AsJob]
Stop-AzVpnConnectionPacketCapture -ResourceId <String> -LinkConnectionName <String> -SasUrl <String> [-AsJob]
[-DefaultProfile <IAzureContextContainer>] [-WhatIf] [-Confirm] [<CommonParameters>]
```

Expand Down Expand Up @@ -147,7 +147,7 @@ Type: System.String
Parameter Sets: (All)
Aliases:

Required: False
Required: True
Position: Named
Default value: None
Accept pipeline input: False
Expand Down
8 changes: 8 additions & 0 deletions tools/StaticAnalysis/Exceptions/Az.Network/BreakingChangeIssues.csv
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -601,3 +601,11 @@
"Microsoft.Azure.PowerShell.Cmdlets.Network.dll","Microsoft.Azure.Commands.Network.NewAzureFirewallCommand","New-AzFirewall","0","1050","The parameter set 'IpConfigurationParameterValues' for cmdlet 'New-AzFirewall' has been removed.","Add parameter set 'IpConfigurationParameterValues' back to cmdlet 'New-AzFirewall'."
"Microsoft.Azure.PowerShell.Cmdlets.Network.dll","Microsoft.Azure.Commands.Network.SetAzureFirewallCommand","Set-AzFirewall","0","3010","The property 'DNSRequireProxyForNetworkRules' of type 'Microsoft.Azure.Commands.Network.Models.PSAzureFirewall' has been removed.","Add the property 'DNSRequireProxyForNetworkRules' back to type 'Microsoft.Azure.Commands.Network.Models.PSAzureFirewall'."
"Microsoft.Azure.PowerShell.Cmdlets.Network.dll","Microsoft.Azure.Commands.Network.SetAzureFirewallCommand","Set-AzFirewall","0","3010","The property 'DNSRequireProxyForNetworkRules' of type 'Microsoft.Azure.Commands.Network.Models.PSAzureFirewall' has been removed.","Add the property 'DNSRequireProxyForNetworkRules' back to type 'Microsoft.Azure.Commands.Network.Models.PSAzureFirewall'."
"Microsoft.Azure.PowerShell.Cmdlets.Network.dll","Microsoft.Azure.Commands.Network.StopAzVpnConnectionPacketCaptureCommand","Stop-AzVpnConnectionPacketCapture","0","1050","The parameter set 'ByVpnConnectionName' for cmdlet 'Stop-AzVpnConnectionPacketCapture' has been removed.","Add parameter set 'ByVpnConnectionName' back to cmdlet 'Stop-AzVpnConnectionPacketCapture'."
"Microsoft.Azure.PowerShell.Cmdlets.Network.dll","Microsoft.Azure.Commands.Network.StopAzVpnConnectionPacketCaptureCommand","Stop-AzVpnConnectionPacketCapture","0","1050","The parameter set 'ByVpnConnectionObject' for cmdlet 'Stop-AzVpnConnectionPacketCapture' has been removed.","Add parameter set 'ByVpnConnectionObject' back to cmdlet 'Stop-AzVpnConnectionPacketCapture'."
"Microsoft.Azure.PowerShell.Cmdlets.Network.dll","Microsoft.Azure.Commands.Network.StopAzVpnConnectionPacketCaptureCommand","Stop-AzVpnConnectionPacketCapture","0","1050","The parameter set 'ByVpnConnectionResourceId' for cmdlet 'Stop-AzVpnConnectionPacketCapture' has been removed.","Add parameter set 'ByVpnConnectionResourceId' back to cmdlet 'Stop-AzVpnConnectionPacketCapture'."
"Microsoft.Azure.PowerShell.Cmdlets.Network.dll","Microsoft.Azure.Commands.Network.StopAzVpnConnectionPacketCaptureCommand","Stop-AzVpnConnectionPacketCapture","0","1050","The parameter set '__AllParameterSets' for cmdlet 'Stop-AzVpnConnectionPacketCapture' has been removed.","Add parameter set '__AllParameterSets' back to cmdlet 'Stop-AzVpnConnectionPacketCapture'."
"Microsoft.Azure.PowerShell.Cmdlets.Network.dll","Microsoft.Azure.Commands.Network.Cortex.VpnConnection.StartAzVpnConnectionPacketCaptureCommand","Start-AzVpnConnectionPacketCapture","0","1050","The parameter set 'ByVpnConnectionName' for cmdlet 'Start-AzVpnConnectionPacketCapture' has been removed.","Add parameter set 'ByVpnConnectionName' back to cmdlet 'Start-AzVpnConnectionPacketCapture'."
"Microsoft.Azure.PowerShell.Cmdlets.Network.dll","Microsoft.Azure.Commands.Network.Cortex.VpnConnection.StartAzVpnConnectionPacketCaptureCommand","Start-AzVpnConnectionPacketCapture","0","1050","The parameter set 'ByVpnConnectionObject' for cmdlet 'Start-AzVpnConnectionPacketCapture' has been removed.","Add parameter set 'ByVpnConnectionObject' back to cmdlet 'Start-AzVpnConnectionPacketCapture'."
"Microsoft.Azure.PowerShell.Cmdlets.Network.dll","Microsoft.Azure.Commands.Network.Cortex.VpnConnection.StartAzVpnConnectionPacketCaptureCommand","Start-AzVpnConnectionPacketCapture","0","1050","The parameter set 'ByVpnConnectionResourceId' for cmdlet 'Start-AzVpnConnectionPacketCapture' has been removed.","Add parameter set 'ByVpnConnectionResourceId' back to cmdlet 'Start-AzVpnConnectionPacketCapture'."
"Microsoft.Azure.PowerShell.Cmdlets.Network.dll","Microsoft.Azure.Commands.Network.Cortex.VpnConnection.StartAzVpnConnectionPacketCaptureCommand","Start-AzVpnConnectionPacketCapture","0","1050","The parameter set '__AllParameterSets' for cmdlet 'Start-AzVpnConnectionPacketCapture' has been removed.","Add parameter set '__AllParameterSets' back to cmdlet 'Start-AzVpnConnectionPacketCapture'."