-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DataFactory] Add 2 New commands to ADF V2 #13114
[DataFactory] Add 2 New commands to ADF V2 #13114
Conversation
Hi @arsunda as you've probably seen in PR template, before introducing new cmdlets you need to submit a cmdelt design review (and make sure it's accepted) here: https://github.com/Azure/azure-powershell-cmdlet-review-pr |
Hi @isra-fel , Ive added the Design Review here: https://github.com/Azure/azure-powershell-cmdlet-review-pr/issues/749 |
/azp run |
Azure Pipelines successfully started running 3 pipeline(s). |
…into arsunda/AddNewCmdlets
@isra-fel The review has been accepted, can we check in this PR? |
@isra-fel ping on this |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix the online help issues detected by static analysis
src/DataFactory/DataFactoryV2/help/Invoke-AzDataFactoryV2TriggerRun.md
Outdated
Show resolved
Hide resolved
src/DataFactory/DataFactoryV2/help/Stop-AzDataFactoryV2TriggerRun.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Pending #13237 |
/azp run |
Azure Pipelines successfully started running 3 pipeline(s). |
this build didn't get the latest common module 1.3.28 for some reason, it's using 1.3.26 instead. |
Description
Adding 2 new commands:
Stop-AzDataFactoryV2TriggerRun
andInvoke-AzDataFactoryV2TriggerRun
Checklist
CONTRIBUTING.md
ChangeLog.md
file(s) has been updated:ChangeLog.md
file can be found atsrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
## Upcoming Release
header -- no new version header should be added