Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DataFactory] Add 2 New commands to ADF V2 #13114

Merged
merged 7 commits into from
Oct 21, 2020

Conversation

arsunda
Copy link
Contributor

@arsunda arsunda commented Sep 30, 2020

Description

Adding 2 new commands: Stop-AzDataFactoryV2TriggerRun and Invoke-AzDataFactoryV2TriggerRun

Checklist

  • I have read the Submitting Changes section of CONTRIBUTING.md
  • The title of the PR is clear and informative
  • The appropriate ChangeLog.md file(s) has been updated:
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
  • The PR does not introduce breaking changes
  • If applicable, the changes made in the PR have proper test coverage
  • For public API changes to cmdlets:
    • a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
    • the markdown help files have been regenerated using the commands listed here

@isra-fel
Copy link
Member

Hi @arsunda as you've probably seen in PR template, before introducing new cmdlets you need to submit a cmdelt design review (and make sure it's accepted) here: https://github.com/Azure/azure-powershell-cmdlet-review-pr

@arsunda
Copy link
Contributor Author

arsunda commented Oct 1, 2020

Hi @arsunda as you've probably seen in PR template, before introducing new cmdlets you need to submit a cmdelt design review (and make sure it's accepted) here: https://github.com/Azure/azure-powershell-cmdlet-review-pr

Hi @isra-fel , Ive added the Design Review here: https://github.com/Azure/azure-powershell-cmdlet-review-pr/issues/749
Will someone be able to look at it over the next few days?

@isra-fel
Copy link
Member

isra-fel commented Oct 9, 2020

/azp run

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

@arsunda
Copy link
Contributor Author

arsunda commented Oct 14, 2020

@isra-fel The review has been accepted, can we check in this PR?

@arsunda
Copy link
Contributor Author

arsunda commented Oct 16, 2020

@isra-fel ping on this

Copy link
Member

@isra-fel isra-fel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the online help issues detected by static analysis

isra-fel
isra-fel previously approved these changes Oct 20, 2020
Copy link
Member

@isra-fel isra-fel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@isra-fel
Copy link
Member

isra-fel commented Oct 20, 2020

Pending #13237
Needs to re-run CI after it's merged

@VeryEarly
Copy link
Contributor

/azp run

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

@VeryEarly
Copy link
Contributor

Pending #13237
Needs to re-run CI after it's merged

this build didn't get the latest common module 1.3.28 for some reason, it's using 1.3.26 instead.
re-triggered CI.

@dingmeng-xue dingmeng-xue changed the base branch from master to release-2020-10-27 October 21, 2020 02:32
@dingmeng-xue dingmeng-xue dismissed isra-fel’s stale review October 21, 2020 02:32

The base branch was changed.

@VeryEarly VeryEarly self-assigned this Oct 21, 2020
VeryEarly
VeryEarly previously approved these changes Oct 21, 2020
VeryEarly
VeryEarly previously approved these changes Oct 21, 2020
@dingmeng-xue dingmeng-xue merged commit ad622e9 into Azure:release-2020-10-27 Oct 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants