Fix the bug that warning message cannot be suppressed #13005

Youri970410 · 2020-09-18T01:53:49Z

Description

Fixed bug that always displayed warning Message when executing cmdlet based on MonitorCmdletBase.
#12889

Checklist

I have read the Submitting Changes section of CONTRIBUTING.md
The title of the PR is clear and informative
The appropriate ChangeLog.md file(s) has been updated:
- For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
- A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
The PR does not introduce breaking changes
If applicable, the changes made in the PR have proper test coverage
For public API changes to cmdlets:
- a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
- the markdown help files have been regenerated using the commands listed here

Fixed bug that always displayed warning Message when executing cmdlet based on MonitorCmdletBase

ghost · 2020-09-18T01:54:04Z

All CLA requirements met.

dingmeng-xue · 2020-09-18T02:00:24Z

src/Monitor/Monitor/MonitorCmdletBase.cs

@@ -89,8 +89,12 @@ public override void ExecuteCmdlet()

            try
            {
-                WriteWarningWithTimestamp("*** The namespace for all the model classes will change from Microsoft.Azure.Management.Monitor.Management.Models to Microsoft.Azure.Management.Monitor.Models in future releases.");
-                WriteWarningWithTimestamp("*** The namespace for output classes will be uniform for all classes in future releases to make it independent of modifications in the model classes.");
+                var isWarning =  bool.Parse(System.Environment.GetEnvironmentVariable("SuppressAzurePowerShellBreakingChangeWarnings"));


shouldSuppress is more accurate.

What will happen if Environment is not set?

Test case is failed due to above reason.

Got it,thanks

dingmeng-xue · 2020-09-18T02:00:53Z

src/Monitor/Monitor/ChangeLog.md

@@ -20,6 +20,9 @@

 ## Upcoming Release

+## Version 2.1.1
+* Fixed bug that always displayed warning Message when executing cmdlet based on MonitorCmdletBase [#12889]


My suggestion is

Fixed the bug that warning message cannot be suppressed. [#12889]

dingmeng-xue · 2020-09-18T02:31:12Z

src/Monitor/Monitor/MonitorCmdletBase.cs

@@ -89,8 +89,12 @@ public override void ExecuteCmdlet()

            try
            {
-                WriteWarningWithTimestamp("*** The namespace for all the model classes will change from Microsoft.Azure.Management.Monitor.Management.Models to Microsoft.Azure.Management.Monitor.Models in future releases.");
-                WriteWarningWithTimestamp("*** The namespace for output classes will be uniform for all classes in future releases to make it independent of modifications in the model classes.");
+                var isWarning =  bool.Parse(System.Environment.GetEnvironmentVariable("SuppressAzurePowerShellBreakingChangeWarnings"));


Test case is failed due to above reason.

dingmeng-xue · 2020-09-18T09:44:59Z

src/Monitor/Monitor/MonitorCmdletBase.cs

@@ -86,14 +86,22 @@ public override void ExecuteCmdlet()
            string reasonPhrase = null;
            string message = null;
            string exName = null;
-
+            string warningEnvironmentParam = "SuppressAzurePowerShellBreakingChangeWarnings";


https://github.com/Azure/azure-powershell-common/blob/b58ba4053f9cbd2861813e6dc3bf4800713d1a7f/src/Common/CustomAttributes/BreakingChangeAttributeHelper.cs#L31

Should use this one.

Got it,thanks.

cannehag · 2020-12-03T07:38:28Z

When will this be released ?

wyunchi-ms · 2020-12-04T03:28:54Z

Hi @cannehag , this fix is already included in the latest release of Monitor. Please install the latest Az.Monitor to use it. Here is the way to install the latest release

Install-Module Az.Monitor -Repository PSGallery -Force

cannehag · 2020-12-04T04:51:21Z

@wyunchi-ms I did update and still got the warnings. But after a new test it did work just fine. Thank you!

wyunchi-ms · 2020-12-04T05:27:34Z

Please try to set SuppressAzurePowerShellBreakingChangeWarnings to True in your environment.

cannehag · 2020-12-04T05:30:00Z

It is working! I had to restart the PS session :)

Fix issue [Azure#12889]

7970dfe

Fixed bug that always displayed warning Message when executing cmdlet based on MonitorCmdletBase

Youri970410 requested a review from dingmeng-xue September 18, 2020 01:53

Youri970410 assigned dingmeng-xue Sep 18, 2020

dingmeng-xue requested changes Sep 18, 2020

View reviewed changes

azuresdkci added the needs-review label Sep 18, 2020

dingmeng-xue requested changes Sep 18, 2020

View reviewed changes

dingmeng-xue added needs-revision and removed needs-review labels Sep 18, 2020

Youri970410 changed the title ~~Fix issue [#12889]~~ Fix the bug that warning message cannot be suppressed Sep 18, 2020

Youri970410 linked an issue Sep 18, 2020 that may be closed by this pull request

Unsuppressable warnings when using Get-AzLog / Get-AzActivityLog #12889

Closed

Youri added 2 commits September 18, 2020 13:46

Improvement of ChangeLog and CmdletBase

f5f56a1

Improvement of the cmdletBase

894fd63

dingmeng-xue requested changes Sep 18, 2020

View reviewed changes

dingmeng-xue requested a review from erich-wang September 18, 2020 09:45

Youri added 3 commits September 18, 2020 17:51

Change variable name

6b72845

using Common Parameter

8e7e1a0

The improvements of determine whether need to suggest

7cbb231

dingmeng-xue added this to the S176 (2020-10-13) milestone Sep 28, 2020

Youri and others added 2 commits September 28, 2020 17:23

Simplified code

bf86d52

Update ChangeLog.md

eeb9a70

dingmeng-xue previously approved these changes Sep 28, 2020

View reviewed changes

Merge branch 'master' into youri/monitor-issue

26a70d2

dingmeng-xue dismissed their stale review via 26a70d2 September 28, 2020 10:06

dingmeng-xue added Waiting for CI and removed needs-revision labels Sep 28, 2020

dingmeng-xue approved these changes Sep 29, 2020

View reviewed changes

dingmeng-xue merged commit 41ed6f1 into Azure:master Sep 29, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix the bug that warning message cannot be suppressed #13005

Fix the bug that warning message cannot be suppressed #13005

Youri970410 commented Sep 18, 2020 •

edited by lijinpei2008

Loading

ghost commented Sep 18, 2020 •

edited by ghost

Loading

dingmeng-xue Sep 18, 2020

dingmeng-xue Sep 18, 2020

dingmeng-xue Sep 18, 2020

Youri970410 Sep 18, 2020

dingmeng-xue Sep 18, 2020

Youri970410 Sep 18, 2020

dingmeng-xue Sep 18, 2020

dingmeng-xue Sep 18, 2020

Youri970410 Sep 18, 2020

cannehag commented Dec 3, 2020

wyunchi-ms commented Dec 4, 2020

cannehag commented Dec 4, 2020

wyunchi-ms commented Dec 4, 2020

cannehag commented Dec 4, 2020 •

edited

Loading

Fix the bug that warning message cannot be suppressed #13005

Fix the bug that warning message cannot be suppressed #13005

Conversation

Youri970410 commented Sep 18, 2020 • edited by lijinpei2008 Loading

Description

Checklist

ghost commented Sep 18, 2020 • edited by ghost Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

cannehag commented Dec 3, 2020

wyunchi-ms commented Dec 4, 2020

cannehag commented Dec 4, 2020

wyunchi-ms commented Dec 4, 2020

cannehag commented Dec 4, 2020 • edited Loading

Youri970410 commented Sep 18, 2020 •

edited by lijinpei2008

Loading

ghost commented Sep 18, 2020 •

edited by ghost

Loading

cannehag commented Dec 4, 2020 •

edited

Loading