Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Subscription RP cmdlets #12830

Merged
merged 9 commits into from
Oct 13, 2020

Conversation

navysingla
Copy link
Contributor

@navysingla navysingla commented Sep 1, 2020

Description

Added new Subscription RP cmdlets and deprecating preview cmdlet. Design issue here - https://github.com/Azure/azure-powershell-cmdlet-review-pr/issues/691

Checklist

  • I have read the Submitting Changes section of CONTRIBUTING.md
  • The title of the PR is clear and informative
  • The appropriate ChangeLog.md file(s) has been updated:
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
  • The PR does not introduce breaking changes
  • If applicable, the changes made in the PR have proper test coverage
  • For public API changes to cmdlets:
    • a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
    • the markdown help files have been regenerated using the commands listed here

@navysingla navysingla changed the title New Subscription RP cmdlets New Subscription RP cmdlets Sep 1, 2020
@msJinLei
Copy link
Contributor

msJinLei commented Sep 3, 2020

@navysingla Please fix the compilation error.

@msJinLei
Copy link
Contributor

msJinLei commented Oct 9, 2020

/azp run

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

@navysingla navysingla requested a review from msJinLei October 9, 2020 18:48
@navysingla
Copy link
Contributor Author

@msJinLei Can we merge this PR?

msJinLei
msJinLei previously approved these changes Oct 10, 2020
@msJinLei msJinLei dismissed their stale review October 10, 2020 06:40

request a minor change for changelog

@msJinLei
Copy link
Contributor

msJinLei commented Oct 10, 2020

@msJinLei Can we merge this PR?

@navysingla All others looks good. Could you refer all the new added cmdlet in the ChangeLog.md?

@navysingla
Copy link
Contributor Author

@msJinLei Can we merge this PR?

@navysingla All others looks good. Could you refer all the new added cmdlet in the ChangeLog.md?

@msJinLei Added all the cmdlets in changelog, can we merge now? and what would be the new version of cmdlets?

@msJinLei
Copy link
Contributor

/azp run

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

@msJinLei msJinLei merged commit 59a8eaa into Azure:master Oct 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants