Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Network june #12751

Merged
merged 28 commits into from
Sep 8, 2020
Merged

Network june #12751

merged 28 commits into from
Sep 8, 2020

Conversation

MikhailTryakhov
Copy link
Contributor

Description

Finally azure networking functionality release!!!

Checklist

  • I have read the Submitting Changes section of CONTRIBUTING.md
  • The title of the PR is clear and informative
  • The appropriate ChangeLog.md file(s) has been updated:
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
  • The PR does not introduce breaking changes
  • If applicable, the changes made in the PR have proper test coverage
  • For public API changes to cmdlets:
    • a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
    • the markdown help files have been regenerated using the commands listed here

anton-evseev and others added 14 commits June 22, 2020 10:13
…te resources. (#12227)

* Created Model Classes for NVA powershell object.

* Added *-NetworkVirtualAppliance commands.

* Added *-NVASite commands and export commands.

* Added tests for NVA CRUD operations.

The tests for NVA Site CRUD operations is in skipped state.
Reason for this is a bug in the Nfv-RP which fails the
New-AzVirtualApplianceSite command. The fix is underway and
Nfv-RP team will record the tests and push it in a separate change.

* Added help files for the new 11 Cmdlets.

* Added entry in the Changelog

* Bug fix for null NVA Id.

* Added online version to help files.

* Replace real guids with 0000.. in examples.

* Add default resource paramsets, rename plural cmds

* Supress static analysis errors.

Co-authored-by: Neel Bhavsar <[email protected]>
* Onboard application gateway to PrivateLink Cmdlets

* Update ChangeLog.md

Co-authored-by: Yabo Hu <[email protected]>
…m-master

# Conflicts:
#	src/Network/Network/Az.Network.psd1
#	src/Network/Network/ChangeLog.md
…m-master

# Conflicts:
#	src/Network/Network/Az.Network.psd1
#	src/Network/Network/ChangeLog.md
#	src/Network/Network/PrivateLinkService/PrivateLinkServiceProvider/ProviderConfiguration.cs
…ce (#12370)

* Skip test due to Auxilary '1' authentication error.
* Add HubIpConfiguration and HubBgpConnections

* Fix bug in test record and static analysis

* Modify info in breaking changes

* Change format of csv file

* Change output type of AzVirtualRouterPeer cmdlets

* Add back AllowActivaFTP

* Add back RemoteBgpCommunitiesText

* Update Network.format.ps1xml

* Update Network.format.ps1xml

* Update HubBgpConnectionTests.ps1

* Update VirtualRouterTests.ps1

* Modify output types

* Update BreakingChangeIssues.csv

* Update ChangeLog.md

* Update New-AzVirtualWan.md

* Update New-AzVirtualRouter.md

* Update New-AzVirtualRouter.md

* Update New-AzVirtualRouter.md

Co-authored-by: Yabo Hu <[email protected]>
* Change test name

* Update TestVirtualRouterPeerCRUD.json
@msJinLei
Copy link
Contributor

@MikhailTryakhov Please fix the test failure

@MikhailTryakhov
Copy link
Contributor Author

MikhailTryakhov commented Aug 25, 2020

@msJinLei I'm a bit confused there... Copying from one of required tests...

  Total tests: 22
       Passed: 22
   Total time: 11.7885 Seconds
/home/vsts/work/1/s/artifacts/after.Azure.PowerShell.sln.targets(4,5): error MSB4181: The "MSBuild" task returned false but did not log an error. [/home/vsts/work/1/s/artifacts/Azure.PowerShell.sln] [/home/vsts/work/1/s/build.proj]
/home/vsts/work/1/s/build.proj(269,5): error MSB3073: The command "dotnet test /home/vsts/work/1/s/artifacts/Azure.PowerShell.sln --filter "AcceptanceType=CheckIn&RunType!=DesktopOnly" --configuration Debug --framework netcoreapp2.1 --logger trx --results-directory "/home/vsts/work/1/s/artifacts//TestResults"" exited with code 1.
/home/vsts/work/1/s/build.proj(289,5): error : Test failures occurred, check the files in artifacts/TestResults
##[error]Error: The process '/opt/hostedtoolcache/dotnet/dotnet' failed with exit code 1
Info: Azure Pipelines hosted agents have been updated to contain .Net Core 3.x (3.1) SDK/Runtime along with 2.1. Unless you have locked down a SDK version for your project(s), 3.x SDK might be picked up which might have breaking behavior as compared to previous versions. 
Some commonly encountered changes are: 
If you're using `Publish` command with -o or --Output argument, you will see that the output folder is now being created at root directory rather than Project File's directory. To learn about more such changes and troubleshoot, refer here: https://docs.microsoft.com/en-us/azure/devops/pipelines/tasks/build/dotnet-core-cli?view=azure-devops#troubleshooting
##[error]Dotnet command failed with non-zero exit code on the following projects : 
Finishing: Test 

Where is it from? how is it possible to have all tests ran successfully and have a magic failure after that? Can you please help me to investigate?

@MikhailTryakhov
Copy link
Contributor Author

Fixed version in dependant project, please review?

…connections and expose Reset operations for VirtualWan P2SVpnGateway & VpnGateway resources. (#12449)

* Enable Internet security for Point to site clients feature changes

* Added help files.

* Incorporate code review comments

* Enable test

* Adding latest test recording

* Skip failing unrelated SignalR test.
@MikhailTryakhov
Copy link
Contributor Author

@msJinLei solved

@msJinLei
Copy link
Contributor

msJinLei commented Sep 3, 2020

@msJinLei solved

Please fix the failed test case.

@MikhailTryakhov
Copy link
Contributor Author

Guys, Again completely the same for the 2nd weeks in a row @msJinLei
I don't understand what is an issue AFTER successful running of the tests...
Can you please help to merge it or to finally figure out what's happened?

MikhailTryakhov and others added 2 commits September 3, 2020 20:19
* Fixed az nw sdk version

* Fixed SDK version

* Add null check in ConditionVersion of Set-AzRoleAssignmenr (#12829)

* add missing null check

* update docs

* Remove old TODO

* Added operation parameters and operation steps in MI operations PS cmdlet (#12437)

* Added operation parameters and operation steps in `Get-AzSqlInstanceOperation`

* Starting validation.

* Fixing build

Co-authored-by: Jovana Toroman <[email protected]>

* Adding patchStatus property to VM Instance View (#12777)

* updated .net to 38.1 and added patchstatus property

* Adding tests and upgrading sdk version for dependent projects

* Update PSVirtualMachineInstanceView.cs

Adding comma

* Corrected parameter field name in the example (#12825)

Changed 'Name' to 'StorageSyncServiceName' field in the example. 'Name' is not a valid parameter.

* Update spelling of Proeprty to Property (#12821)

Co-authored-by: Joshua Van Daalen <[email protected]>

* [SQL] Fix\add AzSqlServerActiveDirectoryOnlyAuthentication APIs (#12782)

* * Fix `Disable-AzSqlServerActiveDirectoryOnlyAuthentication`
* Added cmdlet `Get-AzSqlServerActiveDirectoryOnlyAuthentication`
* Added cmdlet `Enable-AzSqlServerActiveDirectoryOnlyAuthentication`

* Revert changes in authentication

* Fix files in Accounts

* Update Resources.Designer.cs

* Add help files

* Adding breaking change to  Exceptions/Az.Sql/BreakingChangeIssues.csv

* Removing empty lines

Co-authored-by: Amol Agarwal <[email protected]>
Co-authored-by: Milan Brkic <[email protected]>

* [RecoveryServices.backup] changing number of VMs from 100 to 1000 (#12816)

* changing number of VMs from 100 to 1000

* adding description inside changelog.md

* [KeyVault] Refactor tests (#12797)

* don't use mgmt clients

* remove unused code

* remove useless comments

* Add parameter EnableRbcAuthorization for 'New-AzKeyVault' and 'Update-AzKeyVault' (#12459)

* Add parameter EnableRbcAuthorization for 'New-AzKeyVault' and 'Update-AzKeyVault'.

* Update src/KeyVault/KeyVault/ChangeLog.md

Co-authored-by: Yeming Liu <[email protected]>

* Update src/KeyVault/KeyVault/KeyVault.format.ps1xml

Co-authored-by: Yeming Liu <[email protected]>

* Simplify codes in VaultManagementClient.cs.

Co-authored-by: Yeming Liu <[email protected]>

* Disk Access changes (#12673)

* baseline work

* New-AzDiskAccess Remove-AzDiskAccess

* New cmdlets

* New disk config (#12665)

* Checking in changes

* checking in changes

* new cmdlets

* help docs

* help docs

* fix errors

* update help

* Checking in SnapshotConfigTests

* remove Online: lines from help doc

* remove online line

* Disk access (#12713)

* comments remain, committing so others can see content.

* New-AzDiskEncryptionSetConfig dev and testing

* New-AzDiskEncryptionSetConfig changelog and help doc

Co-authored-by: Adam Sandor <[email protected]>

* clean up test

* changelog.md

* adding parameters to New-AzDiskUpdateConfig

* Improving default testing of New-AzDiskEncryptionSetConfig EncryptionType param (#12759)

* Improving default testing

* update recorded test file

* correcting incorrect copy and paste to Test-DiskAccessObject test

* Addressing review comments

* Update ChangeLog.md

* Update New-AzDiskEncryptionSetConfig.md

* add argument completer

Co-authored-by: Theodore Chang <[email protected]>
Co-authored-by: Adam Sandor <[email protected]>
Co-authored-by: Jin Lei <[email protected]>

Co-authored-by: Daniel Orozco <[email protected]>
Co-authored-by: toki95 <[email protected]>
Co-authored-by: Jovana Toroman <[email protected]>
Co-authored-by: haagha <[email protected]>
Co-authored-by: Eragon Riddle <[email protected]>
Co-authored-by: Joshua Van Daalen <[email protected]>
Co-authored-by: Joshua Van Daalen <[email protected]>
Co-authored-by: Amol Agarwal <[email protected]>
Co-authored-by: Amol Agarwal <[email protected]>
Co-authored-by: Milan Brkic <[email protected]>
Co-authored-by: Himanshu Agarwal <[email protected]>
Co-authored-by: Yeming Liu <[email protected]>
Co-authored-by: Beisi Zhou <[email protected]>
Co-authored-by: Yeming Liu <[email protected]>
Co-authored-by: Theodore Chang <[email protected]>
Co-authored-by: Adam Sandor <[email protected]>
Co-authored-by: Jin Lei <[email protected]>
* Fixed az nw sdk version

* Fixed SDK version

* Add null check in ConditionVersion of Set-AzRoleAssignmenr (#12829)

* add missing null check

* update docs

* Remove old TODO

* Added operation parameters and operation steps in MI operations PS cmdlet (#12437)

* Added operation parameters and operation steps in `Get-AzSqlInstanceOperation`

* Starting validation.

* Fixing build

Co-authored-by: Jovana Toroman <[email protected]>

* Adding patchStatus property to VM Instance View (#12777)

* updated .net to 38.1 and added patchstatus property

* Adding tests and upgrading sdk version for dependent projects

* Update PSVirtualMachineInstanceView.cs

Adding comma

* Corrected parameter field name in the example (#12825)

Changed 'Name' to 'StorageSyncServiceName' field in the example. 'Name' is not a valid parameter.

* Update spelling of Proeprty to Property (#12821)

Co-authored-by: Joshua Van Daalen <[email protected]>

* [SQL] Fix\add AzSqlServerActiveDirectoryOnlyAuthentication APIs (#12782)

* * Fix `Disable-AzSqlServerActiveDirectoryOnlyAuthentication`
* Added cmdlet `Get-AzSqlServerActiveDirectoryOnlyAuthentication`
* Added cmdlet `Enable-AzSqlServerActiveDirectoryOnlyAuthentication`

* Revert changes in authentication

* Fix files in Accounts

* Update Resources.Designer.cs

* Add help files

* Adding breaking change to  Exceptions/Az.Sql/BreakingChangeIssues.csv

* Removing empty lines

Co-authored-by: Amol Agarwal <[email protected]>
Co-authored-by: Milan Brkic <[email protected]>

* [RecoveryServices.backup] changing number of VMs from 100 to 1000 (#12816)

* changing number of VMs from 100 to 1000

* adding description inside changelog.md

* [KeyVault] Refactor tests (#12797)

* don't use mgmt clients

* remove unused code

* remove useless comments

* Add parameter EnableRbcAuthorization for 'New-AzKeyVault' and 'Update-AzKeyVault' (#12459)

* Add parameter EnableRbcAuthorization for 'New-AzKeyVault' and 'Update-AzKeyVault'.

* Update src/KeyVault/KeyVault/ChangeLog.md

Co-authored-by: Yeming Liu <[email protected]>

* Update src/KeyVault/KeyVault/KeyVault.format.ps1xml

Co-authored-by: Yeming Liu <[email protected]>

* Simplify codes in VaultManagementClient.cs.

Co-authored-by: Yeming Liu <[email protected]>

* Disk Access changes (#12673)

* baseline work

* New-AzDiskAccess Remove-AzDiskAccess

* New cmdlets

* New disk config (#12665)

* Checking in changes

* checking in changes

* new cmdlets

* help docs

* help docs

* fix errors

* update help

* Checking in SnapshotConfigTests

* remove Online: lines from help doc

* remove online line

* Disk access (#12713)

* comments remain, committing so others can see content.

* New-AzDiskEncryptionSetConfig dev and testing

* New-AzDiskEncryptionSetConfig changelog and help doc

Co-authored-by: Adam Sandor <[email protected]>

* clean up test

* changelog.md

* adding parameters to New-AzDiskUpdateConfig

* Improving default testing of New-AzDiskEncryptionSetConfig EncryptionType param (#12759)

* Improving default testing

* update recorded test file

* correcting incorrect copy and paste to Test-DiskAccessObject test

* Addressing review comments

* Update ChangeLog.md

* Update New-AzDiskEncryptionSetConfig.md

* add argument completer

Co-authored-by: Theodore Chang <[email protected]>
Co-authored-by: Adam Sandor <[email protected]>
Co-authored-by: Jin Lei <[email protected]>

* Skip network api version check (#12854)

Co-authored-by: Zhenyu Zhou <[email protected]>

Co-authored-by: Daniel Orozco <[email protected]>
Co-authored-by: toki95 <[email protected]>
Co-authored-by: Jovana Toroman <[email protected]>
Co-authored-by: haagha <[email protected]>
Co-authored-by: Eragon Riddle <[email protected]>
Co-authored-by: Joshua Van Daalen <[email protected]>
Co-authored-by: Joshua Van Daalen <[email protected]>
Co-authored-by: Amol Agarwal <[email protected]>
Co-authored-by: Amol Agarwal <[email protected]>
Co-authored-by: Milan Brkic <[email protected]>
Co-authored-by: Himanshu Agarwal <[email protected]>
Co-authored-by: Yeming Liu <[email protected]>
Co-authored-by: Beisi Zhou <[email protected]>
Co-authored-by: Yeming Liu <[email protected]>
Co-authored-by: Theodore Chang <[email protected]>
Co-authored-by: Adam Sandor <[email protected]>
Co-authored-by: Jin Lei <[email protected]>
Co-authored-by: aim-for-better <[email protected]>
Co-authored-by: Zhenyu Zhou <[email protected]>
@msJinLei
Copy link
Contributor

msJinLei commented Sep 4, 2020

/azp run

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

@VeryEarly
Copy link
Contributor

VeryEarly commented Sep 4, 2020

Guys, Again completely the same for the 2nd weeks in a row @msJinLei
I don't understand what is an issue AFTER successful running of the tests...
Can you please help to merge it or to finally figure out what's happened?

Those test failures are caused by network module referenced by scenario tests in other modules, skip API version check in those modules could be the fix.

@azure-pipelines
Copy link
Contributor

Command 'run

' is not supported by Azure Pipelines.


Supported commands
  • help:
    • Get descriptions, examples and documentation about supported commands
    • Example: help "command_name"
  • list:
    • List all pipelines for this repository using a comment.
    • Example: "list"
  • run:
    • Run all pipelines or specific pipelines for this repository using a comment. Use this command by itself to trigger all related pipelines, or specify specific pipelines to run.
    • Example: "run" or "run pipeline_name, pipeline_name, pipeline_name"
  • where:
    • Report back the Azure DevOps orgs that are related to this repository and org
    • Example: "where"

See additional documentation.

@MikhailTryakhov
Copy link
Contributor Author

As per contact with Yabo Hu, it's definitely time to merge it! Please let's do it!

@msJinLei
Copy link
Contributor

msJinLei commented Sep 4, 2020

Your patch contains the feature code changes of Compute and KeyVault.
Could you rebase/merge the latest master to have them removed from change list?
I try to merge the latest master and unnecessary changes are removed https://github.com/Azure/azure-powershell/pull/12857/files.

@MikhailTryakhov
Copy link
Contributor Author

@msJinLei can you please finallly merge it and that's all?

@msJinLei
Copy link
Contributor

msJinLei commented Sep 4, 2020

@msJinLei can you please finallly merge it and that's all?

Your patch contains the feature code changes of Compute and KeyVault. It is because you don't merge the latest master.
Please rebase/merge the latest master to have them removed from change list.

* updated sdk version

* Add null check in ConditionVersion of Set-AzRoleAssignmenr (#12829)

* add missing null check

* update docs

* Remove old TODO

* Added operation parameters and operation steps in MI operations PS cmdlet (#12437)

* Added operation parameters and operation steps in `Get-AzSqlInstanceOperation`

* Starting validation.

* Fixing build

Co-authored-by: Jovana Toroman <[email protected]>

* Adding patchStatus property to VM Instance View (#12777)

* updated .net to 38.1 and added patchstatus property

* Adding tests and upgrading sdk version for dependent projects

* Update PSVirtualMachineInstanceView.cs

Adding comma

* Corrected parameter field name in the example (#12825)

Changed 'Name' to 'StorageSyncServiceName' field in the example. 'Name' is not a valid parameter.

* Update spelling of Proeprty to Property (#12821)

Co-authored-by: Joshua Van Daalen <[email protected]>

* [SQL] Fix\add AzSqlServerActiveDirectoryOnlyAuthentication APIs (#12782)

* * Fix `Disable-AzSqlServerActiveDirectoryOnlyAuthentication`
* Added cmdlet `Get-AzSqlServerActiveDirectoryOnlyAuthentication`
* Added cmdlet `Enable-AzSqlServerActiveDirectoryOnlyAuthentication`

* Revert changes in authentication

* Fix files in Accounts

* Update Resources.Designer.cs

* Add help files

* Adding breaking change to  Exceptions/Az.Sql/BreakingChangeIssues.csv

* Removing empty lines

Co-authored-by: Amol Agarwal <[email protected]>
Co-authored-by: Milan Brkic <[email protected]>

* [RecoveryServices.backup] changing number of VMs from 100 to 1000 (#12816)

* changing number of VMs from 100 to 1000

* adding description inside changelog.md

* [KeyVault] Refactor tests (#12797)

* don't use mgmt clients

* remove unused code

* remove useless comments

* Add parameter EnableRbcAuthorization for 'New-AzKeyVault' and 'Update-AzKeyVault' (#12459)

* Add parameter EnableRbcAuthorization for 'New-AzKeyVault' and 'Update-AzKeyVault'.

* Update src/KeyVault/KeyVault/ChangeLog.md

Co-authored-by: Yeming Liu <[email protected]>

* Update src/KeyVault/KeyVault/KeyVault.format.ps1xml

Co-authored-by: Yeming Liu <[email protected]>

* Simplify codes in VaultManagementClient.cs.

Co-authored-by: Yeming Liu <[email protected]>

* Disk Access changes (#12673)

* baseline work

* New-AzDiskAccess Remove-AzDiskAccess

* New cmdlets

* New disk config (#12665)

* Checking in changes

* checking in changes

* new cmdlets

* help docs

* help docs

* fix errors

* update help

* Checking in SnapshotConfigTests

* remove Online: lines from help doc

* remove online line

* Disk access (#12713)

* comments remain, committing so others can see content.

* New-AzDiskEncryptionSetConfig dev and testing

* New-AzDiskEncryptionSetConfig changelog and help doc

Co-authored-by: Adam Sandor <[email protected]>

* clean up test

* changelog.md

* adding parameters to New-AzDiskUpdateConfig

* Improving default testing of New-AzDiskEncryptionSetConfig EncryptionType param (#12759)

* Improving default testing

* update recorded test file

* correcting incorrect copy and paste to Test-DiskAccessObject test

* Addressing review comments

* Update ChangeLog.md

* Update New-AzDiskEncryptionSetConfig.md

* add argument completer

Co-authored-by: Theodore Chang <[email protected]>
Co-authored-by: Adam Sandor <[email protected]>
Co-authored-by: Jin Lei <[email protected]>

* Skip network api version check (#12854)

Co-authored-by: Zhenyu Zhou <[email protected]>

* [Synapse] Add dataset and data flow management cmdlets and update some reference package version (#12831)

* add support for dataset

* add support for dataflow

* add help docs

* rebase master

* update help docs

* add dataset subclass

* update help doc

* update help docs

* update SDK version

* remove blank line

Co-authored-by: Wan Yang <[email protected]>

* RecoveryServices oob release (#12845)

Co-authored-by: Daniel Orozco <[email protected]>
Co-authored-by: toki95 <[email protected]>
Co-authored-by: Jovana Toroman <[email protected]>
Co-authored-by: haagha <[email protected]>
Co-authored-by: Eragon Riddle <[email protected]>
Co-authored-by: Joshua Van Daalen <[email protected]>
Co-authored-by: Joshua Van Daalen <[email protected]>
Co-authored-by: Amol Agarwal <[email protected]>
Co-authored-by: Amol Agarwal <[email protected]>
Co-authored-by: Milan Brkic <[email protected]>
Co-authored-by: Himanshu Agarwal <[email protected]>
Co-authored-by: Yeming Liu <[email protected]>
Co-authored-by: Beisi Zhou <[email protected]>
Co-authored-by: Yeming Liu <[email protected]>
Co-authored-by: Theodore Chang <[email protected]>
Co-authored-by: Adam Sandor <[email protected]>
Co-authored-by: Jin Lei <[email protected]>
Co-authored-by: aim-for-better <[email protected]>
Co-authored-by: Zhenyu Zhou <[email protected]>
Co-authored-by: wonner <[email protected]>
Co-authored-by: Wan Yang <[email protected]>
Co-authored-by: Dingmeng Xue <[email protected]>
@dingmeng-xue dingmeng-xue added Do Not Squash 🚫 To prevent conflicts, this PR should not be squash merged. needs-review and removed needs-revision labels Sep 8, 2020
@dingmeng-xue dingmeng-xue merged commit 60f21f3 into master Sep 8, 2020
@wyunchi-ms wyunchi-ms deleted the network-june branch December 3, 2020 04:09
@wyunchi-ms wyunchi-ms restored the network-june branch December 3, 2020 04:09
@dingmeng-xue dingmeng-xue deleted the network-june branch January 28, 2021 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Do Not Squash 🚫 To prevent conflicts, this PR should not be squash merged. needs-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.