-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide Warning Messages For Azure KeyVault Soft Delete #12672
Merged
isra-fel
merged 2 commits into
Azure:master
from
BethanyZhou:provideWarningMsgsForSoftDelete
Aug 17, 2020
Merged
Provide Warning Messages For Azure KeyVault Soft Delete #12672
isra-fel
merged 2 commits into
Azure:master
from
BethanyZhou:provideWarningMsgsForSoftDelete
Aug 17, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Can one of the admins verify this patch? |
/azp run azure-powershell - powershell-core |
Azure Pipelines successfully started running 1 pipeline(s). |
BethanyZhou
force-pushed
the
provideWarningMsgsForSoftDelete
branch
from
August 17, 2020 02:05
8f2e27d
to
6caf052
Compare
isra-fel
requested changes
Aug 17, 2020
BethanyZhou
force-pushed
the
provideWarningMsgsForSoftDelete
branch
from
August 17, 2020 06:48
6caf052
to
f56793a
Compare
Please resolve the conflicts. Thanks |
Conflicts have been solved. Please help to review, thanks. |
isra-fel
approved these changes
Aug 17, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The ability to create new key vaults with soft delete disabled will be deprecated by December 2020. Hence, all key vault will enable soft delete mandatory and some breaking changes will be introduced.
Parameter
DisableSoftDelete
inNew-AzKeyVault
andEnableSoftDelete
inUpdate-AzKeyVault
will be removed. Besides, deleting keys, certificates and secrets will be affected as well. So we are going to provide warning messages for these situations.Checklist
CONTRIBUTING.md
ChangeLog.md
file(s) has been updated:ChangeLog.md
file can be found atsrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
## Upcoming Release
header -- no new version header should be added