Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide Warning Messages For Azure KeyVault Soft Delete #12672

Merged
merged 2 commits into from
Aug 17, 2020

Conversation

BethanyZhou
Copy link
Contributor

@BethanyZhou BethanyZhou commented Aug 14, 2020

Description

The ability to create new key vaults with soft delete disabled will be deprecated by December 2020. Hence, all key vault will enable soft delete mandatory and some breaking changes will be introduced.

Parameter DisableSoftDelete in New-AzKeyVault and EnableSoftDelete in Update-AzKeyVault will be removed. Besides, deleting keys, certificates and secrets will be affected as well. So we are going to provide warning messages for these situations.

MicrosoftTeams-image

Checklist

  • I have read the Submitting Changes section of CONTRIBUTING.md
  • The title of the PR is clear and informative
  • The appropriate ChangeLog.md file(s) has been updated:
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
  • The PR does not introduce breaking changes
  • If applicable, the changes made in the PR have proper test coverage
  • For public API changes to cmdlets:
    • a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
    • the markdown help files have been regenerated using the commands listed here

@adxsdkps
Copy link
Collaborator

Can one of the admins verify this patch?

@isra-fel
Copy link
Member

/azp run azure-powershell - powershell-core

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 1 pipeline(s).

@BethanyZhou BethanyZhou force-pushed the provideWarningMsgsForSoftDelete branch from 8f2e27d to 6caf052 Compare August 17, 2020 02:05
@BethanyZhou BethanyZhou force-pushed the provideWarningMsgsForSoftDelete branch from 6caf052 to f56793a Compare August 17, 2020 06:48
@isra-fel
Copy link
Member

Please resolve the conflicts. Thanks

@BethanyZhou
Copy link
Contributor Author

Conflicts have been solved. Please help to review, thanks.

Copy link
Member

@isra-fel isra-fel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@isra-fel isra-fel merged commit 3e9ac7a into Azure:master Aug 17, 2020
@BethanyZhou BethanyZhou deleted the provideWarningMsgsForSoftDelete branch December 8, 2021 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants