Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Storage] Support ORS - GA #12668

Merged
merged 1 commit into from
Aug 14, 2020
Merged

[Storage] Support ORS - GA #12668

merged 1 commit into from
Aug 14, 2020

Conversation

blueww
Copy link
Member

@blueww blueww commented Aug 14, 2020

The change has been released in preview by PR : #11752
The feature will GA on 8/31, so move to stable release on 8/25.

The design pass review: Azure/azure-powershell-cmdlet-review-pr#464
Add a static analysis exception since: "New-AzStorageObjectReplicationPolicyRule" will create a local object, and won't change server, so don't need ShouldProcess

Description

Checklist

  • I have read the Submitting Changes section of CONTRIBUTING.md
  • The title of the PR is clear and informative
  • The appropriate ChangeLog.md file(s) has been updated:
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
  • The PR does not introduce breaking changes
  • If applicable, the changes made in the PR have proper test coverage
  • For public API changes to cmdlets:
    • a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
    • the markdown help files have been regenerated using the commands listed here

@blueww blueww force-pushed the orsga branch 2 times, most recently from 0547889 to a4cf769 Compare August 14, 2020 04:27
Copy link
Member

@isra-fel isra-fel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@isra-fel isra-fel merged commit 6638449 into Azure:master Aug 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants