Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding CPlat SDK PowerShell team as Code owners #12652

Merged
merged 1 commit into from
Aug 13, 2020

Conversation

madewithsmiles
Copy link
Contributor

We are taking ownership of the compute platform sdk and powershell dev. Please reach out to cplatsdkdev dl for any questions

Description

Checklist

  • I have read the Submitting Changes section of CONTRIBUTING.md
  • The title of the PR is clear and informative
  • The appropriate ChangeLog.md file(s) has been updated:
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
  • The PR does not introduce breaking changes
  • If applicable, the changes made in the PR have proper test coverage
  • For public API changes to cmdlets:
    • a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
    • the markdown help files have been regenerated using the commands listed here

We are taking ownership of the compute platform sdk and powershell dev. Please reach out to cplatsdkdev dl for any questions
@isra-fel isra-fel self-assigned this Aug 12, 2020
@isra-fel isra-fel requested review from dcaro and dingmeng-xue August 12, 2020 09:29
Copy link
Contributor

@dcaro dcaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just had a chat with @madewithsmiles - LGTM

@isra-fel isra-fel merged commit 1bbc20b into master Aug 13, 2020
@isra-fel isra-fel deleted the cplatsdkdev-codeowner-posh branch August 13, 2020 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants