Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support installer on .NET Framework 4.x #12650

Merged
merged 1 commit into from
Aug 13, 2020

Conversation

dingmeng-xue
Copy link
Member

@dingmeng-xue dingmeng-xue commented Aug 12, 2020

Description

Current MSI doesn't support .NET framework 4.x because custom action configured in WIX doesn't support it.

According to online discussion around error message, we need to provide application configuration to support .NET framework 4.x and it needs 2 mandatory items

  1. Application configuration file must be named as CustomAction.config
  2. config file needs to be packaged into CA.DLL file

I submit InstallerChecks.CA.dll release version because compilation and build needs additional WIX toolkit on local machine. DevOps Agent may not install it.

Checklist

  • I have read the Submitting Changes section of CONTRIBUTING.md
  • The title of the PR is clear and informative
  • The appropriate ChangeLog.md file(s) has been updated:
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
  • The PR does not introduce breaking changes
  • If applicable, the changes made in the PR have proper test coverage
  • For public API changes to cmdlets:
    • a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
    • the markdown help files have been regenerated using the commands listed here

@dingmeng-xue dingmeng-xue added this to the S174 (2020-08-25) milestone Aug 12, 2020
@adxsdkps
Copy link
Collaborator

Can one of the admins verify this patch?

@isra-fel isra-fel merged commit 51216ff into Azure:master Aug 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment