Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save-AzureWebsiteLog The maximum message size quota for incoming messages (65536) has been exceeded #26

Closed
andybatescc opened this issue Dec 4, 2014 · 11 comments
Labels
App Services aka WebSites Service Attention This issue is responsible by Azure service team.

Comments

@andybatescc
Copy link

I'm trying to use the Azure powershell Save-AzureWebsiteLog command to get the logs for an azure site. Get the message below

Save-AzureWebsiteLog -Name <*******> -Output .\logs.zip
Save-AzureWebsiteLog : The maximum message size quota for incoming messages (65536) has been exceeded. To increase the quota, use the MaxReceivedMessageSize property on the appropriate binding
element.
At line:1 char:1

  • Save-AzureWebsiteLog -Name <name removed> -Output .\logs.zip
  • - CategoryInfo          : CloseError: (:) [Save-AzureWebsiteLog], CommunicationException
    - FullyQualifiedErrorId : Microsoft.WindowsAzure.Commands.Websites.SaveAzureWebsiteLogCommand
    
    

Is this a known problem, and is there any resolution?

markcowl referenced this issue in markcowl/azure-powershell Jan 9, 2015
Fix signing issue and upgrade storage version for network library
ogail pushed a commit that referenced this issue Feb 25, 2015
@matt-gibbs matt-gibbs added the App Services aka WebSites label Mar 15, 2015
akromm-zz pushed a commit to akromm-zz/azure-powershell that referenced this issue Apr 18, 2015
@rickrain
Copy link

Would like to see this issue corrected since it's referenced in the Azure documentation.

@NaveenGoli
Copy link
Contributor

I have looked into this, seems like this is happening when the log size exceeds 65536. we will look at a solution for this. in the meantime if possible you can delete the old logs after downloading so the command continues to work if the size of the file is below the threshold..

@parth270592
Copy link

I made this script as a workaround:-

$username = "<enter git deployment username>"
$password = "<enter git deployment password>"
$base64AuthInfo = [Convert]::ToBase64String([Text.Encoding]::ASCII.GetBytes(("{0}:{1}" -f $username,$password)))
$apiUrl = "https://<website name>.scm.azurewebsites.net/api/zip/LogFiles/"
$response = Invoke-WebRequest -Uri $apiUrl -Headers @{Authorization=("Basic {0}" -f $base64AuthInfo)} -Method GET 
try
{
$filename = [System.IO.Path]::GetFileName($response.BaseResponse.ResponseUri.OriginalString)
$filepath = [System.IO.Path]::Combine("c:\asdf\", "http1.zip")
$filestream = [System.IO.File]::Create($filepath)
$response.RawContentStream.WriteTo($filestream)
}
finally
{
$filestream.Close()
}

hovsepm pushed a commit that referenced this issue Jun 20, 2015
AzureRT PR S50 - Update Client Library & Tests
huangpf added a commit that referenced this issue Jun 20, 2015
@devigned
Copy link
Member

@NaveenGoli is there an update for this?

@NaveenGoli
Copy link
Contributor

I haven't heard back from the customer on this, I think the limits are there for security reason, I am going to close this issue. Please let me know if the proposed solution doesn't work

@sayedihashimi
Copy link

I ran into this problem last night. I created a script which runs over several sites and makes 50 web request and other operations. During development of the script I was partially running the script on those same sites. After getting the script in good shape it ran for several hours and when I woke up in the morning I received the error message above. I had to harden my script and then re-run it :(.

I wanted to find out what the breaking point of this method was so I created a brand new azure website and executed the following PS snippet to determine when the command would fail.

$maxnum = 1000
$url = 'http://sayedreqtest.azurewebsites.net/'

$tempfile = 'C:\temp\logs.zip'
for($num = 0; $num -le $maxnum; $num++){    
    try{
        Invoke-WebRequest -Uri $url
        if(Test-Path $tempfile){
            Remove-Item $tempfile
        }
        Save-AzureWebsiteLog -Name 'sayedreqtest' -Output $tempfile
    }
    catch{
        throw ('$num: [{0}]. Exception: [{1}]' -f $_.Exception)
    }
}

The script failed after just 81 requests!

IMO this limitation is sending users down a _pit of failure_. What I mean is that you work on developing a script and typically use a test site which doesn't receive any traffic. Then your team signs off on it and you run it in production and then you get this error. Considering the fact that I ran into this error after just 81 requests I don't understand how this can be considered useful for anything besides new sites. To add to this the script will work for new sites but then quickly stop working and the team will be left scrambling to figure out what happened.

If we cannot increase the default message size then it would be good to have a parameter where the max message size is passed in.

Another thing to consider, there are other entries going into the log file than just direct requests to your website. For example, browsers will request favicon.ico and if you use the scm site, you'll notice log entries for most actions there.

If you are not able to increase the message size then minimally there should be a warning when invoking the cmdlet so that users are aware of this severe limitation.

The workaround is not suitable because it requires that my script be able to manage secrets. That's what Add-AzureAccount is for. I don't want to be in the business of managing Azure secrets, that's for the Azure PowerShell team.

If you do close this issue I'd like more details on the "security threat" here. From the error message it sounds like a WCF error where the default message size is used. If the user were able to specify the max message size what's the threat?

@andybatescc
Copy link
Author

I don't agree with the closure of this. While we don't require this at the moment, it remains a fault with this function and requires a fix.

@SherifTalaat
Copy link

"I haven't heard back from the customer on this" is not the response we were expecting. Isn't github the right place to report Azure PowerShell issue? Please Let me know about the channels on which you hear for customer so I can report the problem there.
I am using Azure PowerShell because I've an Azure subscription I want to manage. Isn't it enough to be considered as a customer?!. I am still facing this issue, I've a website and from day zero I cannot use Save-AzureWebsiteLog cmdlet not even after 7-10 days of using the website.

By the way, people use PowerShell because it makes their life easier. And now you are telling them to replace this very simply cmdlet with this script because you THINK that the limit is there for a reason although that you said "we will look at a solution for this".

If there is not plans to fix cmdlet sooner or later, then it's better to remove in the future releases because it's not useful in production use with this message limit.

Regards,
Sherif Talaat
PowerShell MVP

ogail pushed a commit that referenced this issue Jul 7, 2015
Bug fix: allow rename of entities
stankovski pushed a commit that referenced this issue Jul 10, 2015
Set-AzureBackupVaultStorageType cmdlet
jianghaolu pushed a commit that referenced this issue Sep 4, 2015
@djkazoo2002
Copy link

@parth270592 I am having this error. if you knwo the solution please let me know, Thank you so much for sharing the code.

Invoke-WebRequest : Server Error
401 - Unauthorized: Access is denied due to invalid credentials.
You do not have permission to view this directory or page using the credentials that you supplied.
At line:5 char:13

  • $response = Invoke-WebRequest -Uri $apiUrl -Headers @{Authorization=("Basic {0}" ...
  • - CategoryInfo          : InvalidOperation: (System.Net.HttpWebRequest:HttpWebRequest) [Invoke-WebRequest], WebException
    - FullyQualifiedErrorId : WebCmdletWebResponseException,Microsoft.PowerShell.Commands.InvokeWebRequestCommand
      You cannot call a method on a null-valued expression.
      At line:11 char:1
    
  • $response.RawContentStream.WriteTo($filestream)
  • - CategoryInfo          : InvalidOperation: (:) [], RuntimeException
    - FullyQualifiedErrorId : InvokeMethodOnNull
    

@markcowl
Copy link
Member

@akurmi Can you make sure someone on the websites team looks at this - this appears to be the default WCF message size quota - the quota should definitely be increased for log download.

@cormacpayne
Copy link
Member

@twitchax: "Azure PowerShell continues to maintain RDFE support on a legacy basis: new functionality and bug fixes are addressed sparingly. This issue does not meet the current threshold for consideration."

bganapa pushed a commit to bganapa/azure-powershell that referenced this issue Apr 4, 2018
Alias addition to have backward compat
@bsiegel bsiegel added the Service Attention This issue is responsible by Azure service team. label Sep 26, 2018
cormacpayne pushed a commit that referenced this issue Aug 14, 2019
* NFSAAS-2898 update to R4.5 RP standard

* NFSAAS-2898 update to R4.5 RP standard

* NFSAAS-2898 update to R4.5 RP standard
romahamu added a commit to romahamu/azure-powershell that referenced this issue May 4, 2020
…zure#527)

* Add initial structure for AZ HPC Cache PowerShell Cmdlets. (Azure#1)

* Add initial structure for AZ HPC Cache PowerShell Cmdlets.

* Adding empty folder layout.

* Update project reference for Test project of HPC Cache (Azure#2)

* Initial commit of clients / first mock cmdlet (Azure#3)

* Initial commit of clients / first mock cmdlet

* Initial commit of clients / first mock cmdlet

* Rename Client, Remove unnecessary files, return skulist in azure cmdlet

* Remove utilities

* Add classes to wrap .NET SDK type object. (Azure#4)

* Create wrapper for SDK management client (Azure#5)

* Fix GetAzSku wrt client changes.

* Restructure base cmdlet and mangement client class.

* Test Framework, Additional Cmdlets, Sku Object, Formatting Fixes (Azure#6)

* More commands and start of test framework

Move all logic out of hpc cache client to the commandlets

More commands and start of test framework

Updated commands using new client

fix rebase

fix spacing

fix comments

remove vars

* Test Framework working, add comments to code

* Help text files

* Updates to cmdlet New-AzHpcCache

* Update cmdlet Get-AzHpcCache

* Update cmdlet Get-AzHpcCacheUsageModels

* Update cmdlet Get-AzHpcCacheSku

* Update cmdlet Remove-AzHpcCache

* Cmdlet Update-AzHpcCache and help file

* Changes made for code review

* Start-AzHpcCache Cmdlet (Azure#8)

* Add support for Start-AzHpcCache.

* Adds resource designer for the project.

* Adds assembly info for the project.

* Remove unused imports

* Remove .keep files as they are no longer required.

* Use resource designer to handle strings in remove hpc cache cmdlet.

* Fix namespace and add project reference to test project.

* Prefix with this for local references for better code readability.

* Fix argument validation.

* Add synopsis for start hpc cache cmdlet help file.

* Update Sku Test

* Fix formatting based on StyleCop

* Change output type of start cmdlet (Azure#12)

* Flush-AzHpcCache cmdlet (Azure#11)

Add FlushAzHpcCache.cs and Flush-AzHpcCache.md
Update Resources files.
Update AzHpcCache.md to include flush markdown file.
Update psd1 file to include new command.

* Add support for stop HPC cache cmdlet. (Azure#13)

* Add support for stop HPC cache cmdlet.

* Fix typos

* Cmdlet: Remove Storage Target

* Cmdlet: Upgrade-AzHpcCache

* Add AsJob parameter option for action commands (Azure#14)

* UpgradeCache and RemoveStorageTarget edits

* Add support for storage target create. (Azure#17)

* Add PS wrapper classes required for storage targets.

* Add help for create storage target.

* Add new storage target cmdlet.

* Update resource designer for storage target.

* Get-AzHpcCacheStorageTarget cmdlet

* Fix help.md files to have correct messages

* PSHpcCache (Azure#16)

* Update how cache is returned

* Update what is sent into PSHpcCache.cs

* Add enumberate Collection

* Update help text and comments (Azure#19)

* Adds support for Set-AzHpcStorageTarget. (Azure#20)

* Add support for storage target update.

* Add help for Set-AzHpcStorageTarget.

* Add hook for update storage target in PSD file.

* Fix typos in help and comments.

* Change UpdateHpcCache to SetHpcCache. (Azure#21)

* Fix UpdateHpcCache to SetHpcCache

* update help

* Use Patch for Update, not Post - createOrUpdate

* Change getST cmdlet to also get individual ST

* Update test framework to use custom context and fixtures. (Azure#24)

* Modify HpcCacheController to use RMTestBase base class and use HpcCacheTestContext.

* Update test class to use HpcCacheCollection and HpcCacheTestFixture.

* Update PS file to test Get-AzHpcCache by resource group and name.

* Add HpcCacheTestContext.

* Add HpcCacheCollection.

* Add HpcCacheTestFixture.

* Add cache helper.

* Add constants.

* Add support to handle ENV vars from constants.

* Add utilities required for fixture and custom context.

* Adds storage account and storage target fixture. (Azure#25)

* Add CLFS storage target and get storage target support.

* Add StorageTargetName constant.

* Add StorageTargetName ENV var.

* Add Retry method and Aggregate exception handler.

* Add storage account fixture.

* Add storage account helper.

* Add example storage target cmdlet test.

* Update help text in SetAzHpcStorageTarget.cs (Azure#26)

Update help text for cmdlet SetAzHpcCacheStorageTarget.

* Fix help.md files and help messages

* Fix for storage target update cmdlet. (Azure#28)

* Add Cache, StorageTarget, and Operations tests

* If incorrect value is entered, return inner exception body message

* For Get and Remove - return inner exception body message

* Fix formatting / Fix Descriptions / Fix Typos  (Azure#32)

* Fix formatting using stylecon

* Flush cmdlet updates

* Get-AzHpcCache cmdlet updates

* Get-AzHpcCacheSku cmdlet updates

* Get-AzHpcCacheStorageTarget cmdlet updates

* Get-AzHpcCacheUsageModels cmdlet updates

* New-AzHpcCache cmdlet updates

* Remove-AzHpcCache cmdlet updates

* Remove-AzHpcCacheStorageCache cmdlet updates

* Set-AzHpcCache cmdlet updates

* Start-AzHpcCache cmdlet updates

* Stop-AzHpcCache cmdlet updates

* Upgrade-AzHpcCache cmdlet updates

* New-AzHpcCacheStorageTarget and Set-AzHpcCacheStorageTarget cmdlet updates

* Fix mockContext for fixtures. (Azure#34)

* Add required packages to test project.

* Add assembly info for test project.

* Fix references for resource manager.

* Remove constructor overloading & fix mockContext, also fix references for resource manager

* Dispose the context in StorageAccountFixture and fix the mockContext.

* Add storage account name constant (Azure#35)

* Add StorageAccountName constant.

* Fix Context calling

* Add recorded tests (Azure#33)

* Add recorded tests

* Rename folder

* Revert "Add storage account name constant (Azure#35)" (Azure#36)

This reverts commit 2ac58a8.

* Revert "Fix mockContext for fixtures. (Azure#34)" (Azure#37)

This reverts commit 768ba77.

* Fix Context (Azure#38)

* Add assebly for tests project. (Azure#39)

* Remove completed TODO check. (Azure#40)

* Add fake help urls to make CI task pass (Azure#41)

* Remove completed TODO check.

* Add fake online documentation URL to make CI task pass.

* Update help files to fix fake URLS. it does not like fake servie & cmdlet name. (Azure#42)

* Fix CI task related issues (Azure#43)

* Remove unused imports

* Fix package references

* Update session records to use correct API versions.

* Package Changes / Resource Name Completer / Change Log and Solution (Azure#44)

* Update ChangeLog

* move packages to test

* Fix solution file, add ResourceGroupCompleter to cmdlets

* move all packages

* Update changelog to preview

* Add inputobj and resourceId params to Start/Stop/Flush/Upgrade. Update CacheName to name (Azure#45)

* Update Flush cmdlet to have InputObj and ResourceId, Update cacheName to Name, update test

* fix flush comments

* Fix StartAzHpcCache to include input obj and resourceId

* Fix StopAzHpcCache to include input obj and resourceId

* Fix UpgradeAzHpcCache to include input obj and resourceId

* test changes

* fix help message for cmdlets

* Add Alias and resource name completer for get cache & get storage target. (Azure#46)

* Add CacheName as an alias & use ResourceNameCompleter.

* Add StorageTargetName as an alias and use ResourceNameCompleter.

* Alias initialization

* Get storage target support pipeline cache input.

* New and Set cmdlets (Azure#47)

* update tests

* update NewAzHpcCache to have should process

* update Set cmdlet to use obj/resource Id and shouldProcess

* remove resourceId from Set

* update resouce designer

* Update help files (Azure#48)

* Fix reference

* Update help files

* Use CheckIn type for tests. (Azure#49)

* Add CacheName and StorageTargetName alias. (Azure#50)

* Update Alias in help

* Add CacheName alias and help text for parameters.

* Add StorageTargetName alias.

* Formatting changes.

* Add description to psd

* Remove whitespaces.

* rename files for linux (Azure#51)

* Add shouldProcess to required cmdlets and update junction parameter. (Azure#52)

* Add shouldProcess parameter

* Modify tests to honor force parameter

* Update help text

* Update usage model cmdlet name.

* Update help for all cmdlets to include whatIf

Co-authored-by: Rebecca Makar <[email protected]>
Co-authored-by: Rebecca Makar <[email protected]>
romahamu added a commit to romahamu/azure-powershell that referenced this issue May 4, 2020
Update help text for cmdlet SetAzHpcCacheStorageTarget.
romahamu added a commit to romahamu/azure-powershell that referenced this issue May 4, 2020
…zure#527)

* Add initial structure for AZ HPC Cache PowerShell Cmdlets. (Azure#1)

* Add initial structure for AZ HPC Cache PowerShell Cmdlets.

* Adding empty folder layout.

* Update project reference for Test project of HPC Cache (Azure#2)

* Initial commit of clients / first mock cmdlet (Azure#3)

* Initial commit of clients / first mock cmdlet

* Initial commit of clients / first mock cmdlet

* Rename Client, Remove unnecessary files, return skulist in azure cmdlet

* Remove utilities

* Add classes to wrap .NET SDK type object. (Azure#4)

* Create wrapper for SDK management client (Azure#5)

* Fix GetAzSku wrt client changes.

* Restructure base cmdlet and mangement client class.

* Test Framework, Additional Cmdlets, Sku Object, Formatting Fixes (Azure#6)

* More commands and start of test framework

Move all logic out of hpc cache client to the commandlets

More commands and start of test framework

Updated commands using new client

fix rebase

fix spacing

fix comments

remove vars

* Test Framework working, add comments to code

* Help text files

* Updates to cmdlet New-AzHpcCache

* Update cmdlet Get-AzHpcCache

* Update cmdlet Get-AzHpcCacheUsageModels

* Update cmdlet Get-AzHpcCacheSku

* Update cmdlet Remove-AzHpcCache

* Cmdlet Update-AzHpcCache and help file

* Changes made for code review

* Start-AzHpcCache Cmdlet (Azure#8)

* Add support for Start-AzHpcCache.

* Adds resource designer for the project.

* Adds assembly info for the project.

* Remove unused imports

* Remove .keep files as they are no longer required.

* Use resource designer to handle strings in remove hpc cache cmdlet.

* Fix namespace and add project reference to test project.

* Prefix with this for local references for better code readability.

* Fix argument validation.

* Add synopsis for start hpc cache cmdlet help file.

* Update Sku Test

* Fix formatting based on StyleCop

* Change output type of start cmdlet (Azure#12)

* Flush-AzHpcCache cmdlet (Azure#11)

Add FlushAzHpcCache.cs and Flush-AzHpcCache.md
Update Resources files.
Update AzHpcCache.md to include flush markdown file.
Update psd1 file to include new command.

* Add support for stop HPC cache cmdlet. (Azure#13)

* Add support for stop HPC cache cmdlet.

* Fix typos

* Cmdlet: Remove Storage Target

* Cmdlet: Upgrade-AzHpcCache

* Add AsJob parameter option for action commands (Azure#14)

* UpgradeCache and RemoveStorageTarget edits

* Add support for storage target create. (Azure#17)

* Add PS wrapper classes required for storage targets.

* Add help for create storage target.

* Add new storage target cmdlet.

* Update resource designer for storage target.

* Get-AzHpcCacheStorageTarget cmdlet

* Fix help.md files to have correct messages

* PSHpcCache (Azure#16)

* Update how cache is returned

* Update what is sent into PSHpcCache.cs

* Add enumberate Collection

* Update help text and comments (Azure#19)

* Adds support for Set-AzHpcStorageTarget. (Azure#20)

* Add support for storage target update.

* Add help for Set-AzHpcStorageTarget.

* Add hook for update storage target in PSD file.

* Fix typos in help and comments.

* Change UpdateHpcCache to SetHpcCache. (Azure#21)

* Fix UpdateHpcCache to SetHpcCache

* update help

* Use Patch for Update, not Post - createOrUpdate

* Change getST cmdlet to also get individual ST

* Update test framework to use custom context and fixtures. (Azure#24)

* Modify HpcCacheController to use RMTestBase base class and use HpcCacheTestContext.

* Update test class to use HpcCacheCollection and HpcCacheTestFixture.

* Update PS file to test Get-AzHpcCache by resource group and name.

* Add HpcCacheTestContext.

* Add HpcCacheCollection.

* Add HpcCacheTestFixture.

* Add cache helper.

* Add constants.

* Add support to handle ENV vars from constants.

* Add utilities required for fixture and custom context.

* Adds storage account and storage target fixture. (Azure#25)

* Add CLFS storage target and get storage target support.

* Add StorageTargetName constant.

* Add StorageTargetName ENV var.

* Add Retry method and Aggregate exception handler.

* Add storage account fixture.

* Add storage account helper.

* Add example storage target cmdlet test.

* Update help text in SetAzHpcStorageTarget.cs (Azure#26)

Update help text for cmdlet SetAzHpcCacheStorageTarget.

* Fix help.md files and help messages

* Fix for storage target update cmdlet. (Azure#28)

* Add Cache, StorageTarget, and Operations tests

* If incorrect value is entered, return inner exception body message

* For Get and Remove - return inner exception body message

* Fix formatting / Fix Descriptions / Fix Typos  (Azure#32)

* Fix formatting using stylecon

* Flush cmdlet updates

* Get-AzHpcCache cmdlet updates

* Get-AzHpcCacheSku cmdlet updates

* Get-AzHpcCacheStorageTarget cmdlet updates

* Get-AzHpcCacheUsageModels cmdlet updates

* New-AzHpcCache cmdlet updates

* Remove-AzHpcCache cmdlet updates

* Remove-AzHpcCacheStorageCache cmdlet updates

* Set-AzHpcCache cmdlet updates

* Start-AzHpcCache cmdlet updates

* Stop-AzHpcCache cmdlet updates

* Upgrade-AzHpcCache cmdlet updates

* New-AzHpcCacheStorageTarget and Set-AzHpcCacheStorageTarget cmdlet updates

* Fix mockContext for fixtures. (Azure#34)

* Add required packages to test project.

* Add assembly info for test project.

* Fix references for resource manager.

* Remove constructor overloading & fix mockContext, also fix references for resource manager

* Dispose the context in StorageAccountFixture and fix the mockContext.

* Add storage account name constant (Azure#35)

* Add StorageAccountName constant.

* Fix Context calling

* Add recorded tests (Azure#33)

* Add recorded tests

* Rename folder

* Revert "Add storage account name constant (Azure#35)" (Azure#36)

This reverts commit 2ac58a8.

* Revert "Fix mockContext for fixtures. (Azure#34)" (Azure#37)

This reverts commit 768ba77.

* Fix Context (Azure#38)

* Add assebly for tests project. (Azure#39)

* Remove completed TODO check. (Azure#40)

* Add fake help urls to make CI task pass (Azure#41)

* Remove completed TODO check.

* Add fake online documentation URL to make CI task pass.

* Update help files to fix fake URLS. it does not like fake servie & cmdlet name. (Azure#42)

* Fix CI task related issues (Azure#43)

* Remove unused imports

* Fix package references

* Update session records to use correct API versions.

* Package Changes / Resource Name Completer / Change Log and Solution (Azure#44)

* Update ChangeLog

* move packages to test

* Fix solution file, add ResourceGroupCompleter to cmdlets

* move all packages

* Update changelog to preview

* Add inputobj and resourceId params to Start/Stop/Flush/Upgrade. Update CacheName to name (Azure#45)

* Update Flush cmdlet to have InputObj and ResourceId, Update cacheName to Name, update test

* fix flush comments

* Fix StartAzHpcCache to include input obj and resourceId

* Fix StopAzHpcCache to include input obj and resourceId

* Fix UpgradeAzHpcCache to include input obj and resourceId

* test changes

* fix help message for cmdlets

* Add Alias and resource name completer for get cache & get storage target. (Azure#46)

* Add CacheName as an alias & use ResourceNameCompleter.

* Add StorageTargetName as an alias and use ResourceNameCompleter.

* Alias initialization

* Get storage target support pipeline cache input.

* New and Set cmdlets (Azure#47)

* update tests

* update NewAzHpcCache to have should process

* update Set cmdlet to use obj/resource Id and shouldProcess

* remove resourceId from Set

* update resouce designer

* Update help files (Azure#48)

* Fix reference

* Update help files

* Use CheckIn type for tests. (Azure#49)

* Add CacheName and StorageTargetName alias. (Azure#50)

* Update Alias in help

* Add CacheName alias and help text for parameters.

* Add StorageTargetName alias.

* Formatting changes.

* Add description to psd

* Remove whitespaces.

* rename files for linux (Azure#51)

* Add shouldProcess to required cmdlets and update junction parameter. (Azure#52)

* Add shouldProcess parameter

* Modify tests to honor force parameter

* Update help text

* Update usage model cmdlet name.

* Update help for all cmdlets to include whatIf

Co-authored-by: Rebecca Makar <[email protected]>
Co-authored-by: Rebecca Makar <[email protected]>
romahamu added a commit to romahamu/azure-powershell that referenced this issue May 4, 2020
…zure#527)

* Add initial structure for AZ HPC Cache PowerShell Cmdlets. (Azure#1)

* Add initial structure for AZ HPC Cache PowerShell Cmdlets.

* Adding empty folder layout.

* Update project reference for Test project of HPC Cache (Azure#2)

* Initial commit of clients / first mock cmdlet (Azure#3)

* Initial commit of clients / first mock cmdlet

* Initial commit of clients / first mock cmdlet

* Rename Client, Remove unnecessary files, return skulist in azure cmdlet

* Remove utilities

* Add classes to wrap .NET SDK type object. (Azure#4)

* Create wrapper for SDK management client (Azure#5)

* Fix GetAzSku wrt client changes.

* Restructure base cmdlet and mangement client class.

* Test Framework, Additional Cmdlets, Sku Object, Formatting Fixes (Azure#6)

* More commands and start of test framework

Move all logic out of hpc cache client to the commandlets

More commands and start of test framework

Updated commands using new client

fix rebase

fix spacing

fix comments

remove vars

* Test Framework working, add comments to code

* Help text files

* Updates to cmdlet New-AzHpcCache

* Update cmdlet Get-AzHpcCache

* Update cmdlet Get-AzHpcCacheUsageModels

* Update cmdlet Get-AzHpcCacheSku

* Update cmdlet Remove-AzHpcCache

* Cmdlet Update-AzHpcCache and help file

* Changes made for code review

* Start-AzHpcCache Cmdlet (Azure#8)

* Add support for Start-AzHpcCache.

* Adds resource designer for the project.

* Adds assembly info for the project.

* Remove unused imports

* Remove .keep files as they are no longer required.

* Use resource designer to handle strings in remove hpc cache cmdlet.

* Fix namespace and add project reference to test project.

* Prefix with this for local references for better code readability.

* Fix argument validation.

* Add synopsis for start hpc cache cmdlet help file.

* Update Sku Test

* Fix formatting based on StyleCop

* Change output type of start cmdlet (Azure#12)

* Flush-AzHpcCache cmdlet (Azure#11)

Add FlushAzHpcCache.cs and Flush-AzHpcCache.md
Update Resources files.
Update AzHpcCache.md to include flush markdown file.
Update psd1 file to include new command.

* Add support for stop HPC cache cmdlet. (Azure#13)

* Add support for stop HPC cache cmdlet.

* Fix typos

* Cmdlet: Remove Storage Target

* Cmdlet: Upgrade-AzHpcCache

* Add AsJob parameter option for action commands (Azure#14)

* UpgradeCache and RemoveStorageTarget edits

* Add support for storage target create. (Azure#17)

* Add PS wrapper classes required for storage targets.

* Add help for create storage target.

* Add new storage target cmdlet.

* Update resource designer for storage target.

* Get-AzHpcCacheStorageTarget cmdlet

* Fix help.md files to have correct messages

* PSHpcCache (Azure#16)

* Update how cache is returned

* Update what is sent into PSHpcCache.cs

* Add enumberate Collection

* Update help text and comments (Azure#19)

* Adds support for Set-AzHpcStorageTarget. (Azure#20)

* Add support for storage target update.

* Add help for Set-AzHpcStorageTarget.

* Add hook for update storage target in PSD file.

* Fix typos in help and comments.

* Change UpdateHpcCache to SetHpcCache. (Azure#21)

* Fix UpdateHpcCache to SetHpcCache

* update help

* Use Patch for Update, not Post - createOrUpdate

* Change getST cmdlet to also get individual ST

* Update test framework to use custom context and fixtures. (Azure#24)

* Modify HpcCacheController to use RMTestBase base class and use HpcCacheTestContext.

* Update test class to use HpcCacheCollection and HpcCacheTestFixture.

* Update PS file to test Get-AzHpcCache by resource group and name.

* Add HpcCacheTestContext.

* Add HpcCacheCollection.

* Add HpcCacheTestFixture.

* Add cache helper.

* Add constants.

* Add support to handle ENV vars from constants.

* Add utilities required for fixture and custom context.

* Adds storage account and storage target fixture. (Azure#25)

* Add CLFS storage target and get storage target support.

* Add StorageTargetName constant.

* Add StorageTargetName ENV var.

* Add Retry method and Aggregate exception handler.

* Add storage account fixture.

* Add storage account helper.

* Add example storage target cmdlet test.

* Update help text in SetAzHpcStorageTarget.cs (Azure#26)

Update help text for cmdlet SetAzHpcCacheStorageTarget.

* Fix help.md files and help messages

* Fix for storage target update cmdlet. (Azure#28)

* Add Cache, StorageTarget, and Operations tests

* If incorrect value is entered, return inner exception body message

* For Get and Remove - return inner exception body message

* Fix formatting / Fix Descriptions / Fix Typos  (Azure#32)

* Fix formatting using stylecon

* Flush cmdlet updates

* Get-AzHpcCache cmdlet updates

* Get-AzHpcCacheSku cmdlet updates

* Get-AzHpcCacheStorageTarget cmdlet updates

* Get-AzHpcCacheUsageModels cmdlet updates

* New-AzHpcCache cmdlet updates

* Remove-AzHpcCache cmdlet updates

* Remove-AzHpcCacheStorageCache cmdlet updates

* Set-AzHpcCache cmdlet updates

* Start-AzHpcCache cmdlet updates

* Stop-AzHpcCache cmdlet updates

* Upgrade-AzHpcCache cmdlet updates

* New-AzHpcCacheStorageTarget and Set-AzHpcCacheStorageTarget cmdlet updates

* Fix mockContext for fixtures. (Azure#34)

* Add required packages to test project.

* Add assembly info for test project.

* Fix references for resource manager.

* Remove constructor overloading & fix mockContext, also fix references for resource manager

* Dispose the context in StorageAccountFixture and fix the mockContext.

* Add storage account name constant (Azure#35)

* Add StorageAccountName constant.

* Fix Context calling

* Add recorded tests (Azure#33)

* Add recorded tests

* Rename folder

* Revert "Add storage account name constant (Azure#35)" (Azure#36)

This reverts commit 2ac58a8.

* Revert "Fix mockContext for fixtures. (Azure#34)" (Azure#37)

This reverts commit 768ba77.

* Fix Context (Azure#38)

* Add assebly for tests project. (Azure#39)

* Remove completed TODO check. (Azure#40)

* Add fake help urls to make CI task pass (Azure#41)

* Remove completed TODO check.

* Add fake online documentation URL to make CI task pass.

* Update help files to fix fake URLS. it does not like fake servie & cmdlet name. (Azure#42)

* Fix CI task related issues (Azure#43)

* Remove unused imports

* Fix package references

* Update session records to use correct API versions.

* Package Changes / Resource Name Completer / Change Log and Solution (Azure#44)

* Update ChangeLog

* move packages to test

* Fix solution file, add ResourceGroupCompleter to cmdlets

* move all packages

* Update changelog to preview

* Add inputobj and resourceId params to Start/Stop/Flush/Upgrade. Update CacheName to name (Azure#45)

* Update Flush cmdlet to have InputObj and ResourceId, Update cacheName to Name, update test

* fix flush comments

* Fix StartAzHpcCache to include input obj and resourceId

* Fix StopAzHpcCache to include input obj and resourceId

* Fix UpgradeAzHpcCache to include input obj and resourceId

* test changes

* fix help message for cmdlets

* Add Alias and resource name completer for get cache & get storage target. (Azure#46)

* Add CacheName as an alias & use ResourceNameCompleter.

* Add StorageTargetName as an alias and use ResourceNameCompleter.

* Alias initialization

* Get storage target support pipeline cache input.

* New and Set cmdlets (Azure#47)

* update tests

* update NewAzHpcCache to have should process

* update Set cmdlet to use obj/resource Id and shouldProcess

* remove resourceId from Set

* update resouce designer

* Update help files (Azure#48)

* Fix reference

* Update help files

* Use CheckIn type for tests. (Azure#49)

* Add CacheName and StorageTargetName alias. (Azure#50)

* Update Alias in help

* Add CacheName alias and help text for parameters.

* Add StorageTargetName alias.

* Formatting changes.

* Add description to psd

* Remove whitespaces.

* rename files for linux (Azure#51)

* Add shouldProcess to required cmdlets and update junction parameter. (Azure#52)

* Add shouldProcess parameter

* Modify tests to honor force parameter

* Update help text

* Update usage model cmdlet name.

* Update help for all cmdlets to include whatIf

Co-authored-by: Rebecca Makar <[email protected]>
Co-authored-by: Rebecca Makar <[email protected]>
isra-fel pushed a commit that referenced this issue May 7, 2020
…01 (#11790)

* [HPC-Cache] On-boarding of PowerShell Cmdlets for HPC Cache service. (#527)

* Add initial structure for AZ HPC Cache PowerShell Cmdlets. (#1)

* Add initial structure for AZ HPC Cache PowerShell Cmdlets.

* Adding empty folder layout.

* Update project reference for Test project of HPC Cache (#2)

* Initial commit of clients / first mock cmdlet (#3)

* Initial commit of clients / first mock cmdlet

* Initial commit of clients / first mock cmdlet

* Rename Client, Remove unnecessary files, return skulist in azure cmdlet

* Remove utilities

* Add classes to wrap .NET SDK type object. (#4)

* Create wrapper for SDK management client (#5)

* Fix GetAzSku wrt client changes.

* Restructure base cmdlet and mangement client class.

* Test Framework, Additional Cmdlets, Sku Object, Formatting Fixes (#6)

* More commands and start of test framework

Move all logic out of hpc cache client to the commandlets

More commands and start of test framework

Updated commands using new client

fix rebase

fix spacing

fix comments

remove vars

* Test Framework working, add comments to code

* Help text files

* Updates to cmdlet New-AzHpcCache

* Update cmdlet Get-AzHpcCache

* Update cmdlet Get-AzHpcCacheUsageModels

* Update cmdlet Get-AzHpcCacheSku

* Update cmdlet Remove-AzHpcCache

* Cmdlet Update-AzHpcCache and help file

* Changes made for code review

* Start-AzHpcCache Cmdlet (#8)

* Add support for Start-AzHpcCache.

* Adds resource designer for the project.

* Adds assembly info for the project.

* Remove unused imports

* Remove .keep files as they are no longer required.

* Use resource designer to handle strings in remove hpc cache cmdlet.

* Fix namespace and add project reference to test project.

* Prefix with this for local references for better code readability.

* Fix argument validation.

* Add synopsis for start hpc cache cmdlet help file.

* Update Sku Test

* Fix formatting based on StyleCop

* Change output type of start cmdlet (#12)

* Flush-AzHpcCache cmdlet (#11)

Add FlushAzHpcCache.cs and Flush-AzHpcCache.md
Update Resources files.
Update AzHpcCache.md to include flush markdown file.
Update psd1 file to include new command.

* Add support for stop HPC cache cmdlet. (#13)

* Add support for stop HPC cache cmdlet.

* Fix typos

* Cmdlet: Remove Storage Target

* Cmdlet: Upgrade-AzHpcCache

* Add AsJob parameter option for action commands (#14)

* UpgradeCache and RemoveStorageTarget edits

* Add support for storage target create. (#17)

* Add PS wrapper classes required for storage targets.

* Add help for create storage target.

* Add new storage target cmdlet.

* Update resource designer for storage target.

* Get-AzHpcCacheStorageTarget cmdlet

* Fix help.md files to have correct messages

* PSHpcCache (#16)

* Update how cache is returned

* Update what is sent into PSHpcCache.cs

* Add enumberate Collection

* Update help text and comments (#19)

* Adds support for Set-AzHpcStorageTarget. (#20)

* Add support for storage target update.

* Add help for Set-AzHpcStorageTarget.

* Add hook for update storage target in PSD file.

* Fix typos in help and comments.

* Change UpdateHpcCache to SetHpcCache. (#21)

* Fix UpdateHpcCache to SetHpcCache

* update help

* Use Patch for Update, not Post - createOrUpdate

* Change getST cmdlet to also get individual ST

* Update test framework to use custom context and fixtures. (#24)

* Modify HpcCacheController to use RMTestBase base class and use HpcCacheTestContext.

* Update test class to use HpcCacheCollection and HpcCacheTestFixture.

* Update PS file to test Get-AzHpcCache by resource group and name.

* Add HpcCacheTestContext.

* Add HpcCacheCollection.

* Add HpcCacheTestFixture.

* Add cache helper.

* Add constants.

* Add support to handle ENV vars from constants.

* Add utilities required for fixture and custom context.

* Adds storage account and storage target fixture. (#25)

* Add CLFS storage target and get storage target support.

* Add StorageTargetName constant.

* Add StorageTargetName ENV var.

* Add Retry method and Aggregate exception handler.

* Add storage account fixture.

* Add storage account helper.

* Add example storage target cmdlet test.

* Update help text in SetAzHpcStorageTarget.cs (#26)

Update help text for cmdlet SetAzHpcCacheStorageTarget.

* Fix help.md files and help messages

* Fix for storage target update cmdlet. (#28)

* Add Cache, StorageTarget, and Operations tests

* If incorrect value is entered, return inner exception body message

* For Get and Remove - return inner exception body message

* Fix formatting / Fix Descriptions / Fix Typos  (#32)

* Fix formatting using stylecon

* Flush cmdlet updates

* Get-AzHpcCache cmdlet updates

* Get-AzHpcCacheSku cmdlet updates

* Get-AzHpcCacheStorageTarget cmdlet updates

* Get-AzHpcCacheUsageModels cmdlet updates

* New-AzHpcCache cmdlet updates

* Remove-AzHpcCache cmdlet updates

* Remove-AzHpcCacheStorageCache cmdlet updates

* Set-AzHpcCache cmdlet updates

* Start-AzHpcCache cmdlet updates

* Stop-AzHpcCache cmdlet updates

* Upgrade-AzHpcCache cmdlet updates

* New-AzHpcCacheStorageTarget and Set-AzHpcCacheStorageTarget cmdlet updates

* Fix mockContext for fixtures. (#34)

* Add required packages to test project.

* Add assembly info for test project.

* Fix references for resource manager.

* Remove constructor overloading & fix mockContext, also fix references for resource manager

* Dispose the context in StorageAccountFixture and fix the mockContext.

* Add storage account name constant (#35)

* Add StorageAccountName constant.

* Fix Context calling

* Add recorded tests (#33)

* Add recorded tests

* Rename folder

* Revert "Add storage account name constant (#35)" (#36)

This reverts commit 2ac58a8.

* Revert "Fix mockContext for fixtures. (#34)" (#37)

This reverts commit 768ba77.

* Fix Context (#38)

* Add assebly for tests project. (#39)

* Remove completed TODO check. (#40)

* Add fake help urls to make CI task pass (#41)

* Remove completed TODO check.

* Add fake online documentation URL to make CI task pass.

* Update help files to fix fake URLS. it does not like fake servie & cmdlet name. (#42)

* Fix CI task related issues (#43)

* Remove unused imports

* Fix package references

* Update session records to use correct API versions.

* Package Changes / Resource Name Completer / Change Log and Solution (#44)

* Update ChangeLog

* move packages to test

* Fix solution file, add ResourceGroupCompleter to cmdlets

* move all packages

* Update changelog to preview

* Add inputobj and resourceId params to Start/Stop/Flush/Upgrade. Update CacheName to name (#45)

* Update Flush cmdlet to have InputObj and ResourceId, Update cacheName to Name, update test

* fix flush comments

* Fix StartAzHpcCache to include input obj and resourceId

* Fix StopAzHpcCache to include input obj and resourceId

* Fix UpgradeAzHpcCache to include input obj and resourceId

* test changes

* fix help message for cmdlets

* Add Alias and resource name completer for get cache & get storage target. (#46)

* Add CacheName as an alias & use ResourceNameCompleter.

* Add StorageTargetName as an alias and use ResourceNameCompleter.

* Alias initialization

* Get storage target support pipeline cache input.

* New and Set cmdlets (#47)

* update tests

* update NewAzHpcCache to have should process

* update Set cmdlet to use obj/resource Id and shouldProcess

* remove resourceId from Set

* update resouce designer

* Update help files (#48)

* Fix reference

* Update help files

* Use CheckIn type for tests. (#49)

* Add CacheName and StorageTargetName alias. (#50)

* Update Alias in help

* Add CacheName alias and help text for parameters.

* Add StorageTargetName alias.

* Formatting changes.

* Add description to psd

* Remove whitespaces.

* rename files for linux (#51)

* Add shouldProcess to required cmdlets and update junction parameter. (#52)

* Add shouldProcess parameter

* Modify tests to honor force parameter

* Update help text

* Update usage model cmdlet name.

* Update help for all cmdlets to include whatIf

Co-authored-by: Rebecca Makar <[email protected]>
Co-authored-by: Rebecca Makar <[email protected]>

* Change StorageCache folder name to HPCCache and modify Upgrade cache cmdlet … (#539)

* Change StorageCache folder name to HPCCache and modify Upgrade cache cmdlet.

* Update Az.HPCCache.psd1

Co-authored-by: Yunchi Wang <[email protected]>

* Release-2020-04-28-HPCCache

* Add mapping rule for HPCCache

* Remove Flush-AzHpcCache as Flush is not approved PS verb.

* Add default parameter set for storage target cmdlets and output type for get usage model cmdlet.

* Use parameter sets for Update-AzHpcCache

* Remove prerelease string from .psd file.

Co-authored-by: Rebecca Makar <[email protected]>
Co-authored-by: Rebecca Makar <[email protected]>
Co-authored-by: Yunchi Wang <[email protected]>
Co-authored-by: msJinLei <[email protected]>
isra-fel pushed a commit that referenced this issue Apr 25, 2022
yifanz0 added a commit to yifanz0/azure-powershell that referenced this issue Jan 13, 2023
Fix failing tests. Move data files used in dataplane tests to data directory
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
App Services aka WebSites Service Attention This issue is responsible by Azure service team.
Projects
None yet
Development

No branches or pull requests