Skip to content

Commit

Permalink
Address review comments
Browse files Browse the repository at this point in the history
  • Loading branch information
msJinLei committed Jan 7, 2021
1 parent f7400e3 commit defd596
Show file tree
Hide file tree
Showing 12 changed files with 27 additions and 27 deletions.
6 changes: 3 additions & 3 deletions src/MySql/Az.MySql.psd1
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
#
# Generated by: Microsoft Corporation
#
# Generated on: 1/6/2021
# Generated on: 1/7/2021
#

@{
Expand Down Expand Up @@ -54,7 +54,7 @@ DotNetFrameworkVersion = '4.7.2'
RequiredModules = @(@{ModuleName = 'Az.Accounts'; ModuleVersion = '2.2.3'; })

# Assemblies that must be loaded prior to importing this module
RequiredAssemblies = './bin/Az.MySql.private.dll'
RequiredAssemblies = 'bin\Az.MySql.private.dll'

# Script files (.ps1) that are run in the caller's environment prior to importing this module.
# ScriptsToProcess = @()
Expand All @@ -63,7 +63,7 @@ RequiredAssemblies = './bin/Az.MySql.private.dll'
# TypesToProcess = @()

# Format files (.ps1xml) to be loaded when importing this module
FormatsToProcess = './Az.MySql.format.ps1xml'
FormatsToProcess = 'Az.MySql.format.ps1xml'

# Modules to import as nested modules of the module specified in RootModule/ModuleToProcess
# NestedModules = @()
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ function Get-AzMySqlFlexibleServerConnectionString {
[System.String]
${Client},

[Parameter(ParameterSetName='GetViaIdentity', Mandatory, ValueFromPipeline, HelpMessage = 'Name of the server')]
[Parameter(ParameterSetName='GetViaIdentity', Mandatory, ValueFromPipeline, HelpMessage = 'The server for the connection string.')]
[Microsoft.Azure.PowerShell.Cmdlets.MySql.Category('Body')]
[Microsoft.Azure.PowerShell.Cmdlets.MySql.Models.IMySqlIdentity]
${InputObject},
Expand Down
6 changes: 3 additions & 3 deletions src/MySql/custom/New-AzMySqlFlexibleServer.ps1
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ $AZURE_ARMNAME = '^[^<>%&:\\?/]{1,260}$'
function New-AzMySqlFlexibleServer {
[OutputType([Microsoft.Azure.PowerShell.Cmdlets.MySql.Models.Api20200701Preview.IServerAutoGenerated])]
[CmdletBinding(DefaultParameterSetName='CreateExpanded', PositionalBinding=$false, SupportsShouldProcess, ConfirmImpact='Medium')]
[Microsoft.Azure.PowerShell.Cmdlets.MySql.Description('Creates a new server.')]
[Microsoft.Azure.PowerShell.Cmdlets.MySql.Description('Creates a new MySQL flexible server.')]
param(
[Parameter(HelpMessage = 'The name of the server.')]
[Alias('ServerName')]
Expand Down Expand Up @@ -575,8 +575,8 @@ function Get-RandomNumbers($Prefix, $Length) {
}

function Get-RandomName() {
$Noun = Get-Content -Path (Join-Path $PSScriptRoot "..\utils\nouns.txt") | Get-Random
$Adjective = Get-Content -Path (Join-Path $PSScriptRoot "..\utils\adjectives.txt") | Get-Random
$Noun = Get-Content -Path (Join-Path $PSScriptRoot ".\nouns.txt") | Get-Random
$Adjective = Get-Content -Path (Join-Path $PSScriptRoot ".\adjectives.txt") | Get-Random
$Number = Get-Random -Maximum 10
$RandomName = $Adjective + (Get-Culture).TextInfo.ToTitleCase($Noun) + $Number
return $RandomName
Expand Down
File renamed without changes.
File renamed without changes.
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ COMPLEX PARAMETER PROPERTIES
To create the parameters described below, construct a hash table containing the appropriate properties. For information on hash tables, run Get-Help about_Hash_Tables.
INPUTOBJECT <IMySqlIdentity>: Name of the server
INPUTOBJECT <IMySqlIdentity>: The server for the connection string.
[ConfigurationName <String>]: The name of the server configuration.
[DatabaseName <String>]: The name of the database.
[FirewallRuleName <String>]: The name of the server firewall rule.
Expand Down Expand Up @@ -84,7 +84,7 @@ param(
[Parameter(ParameterSetName='GetViaIdentity', Mandatory, ValueFromPipeline)]
[Microsoft.Azure.PowerShell.Cmdlets.MySql.Category('Body')]
[Microsoft.Azure.PowerShell.Cmdlets.MySql.Models.IMySqlIdentity]
# Name of the server
# The server for the connection string.
# To construct, see NOTES section for INPUTOBJECT properties and create a hash table.
${InputObject},

Expand Down
4 changes: 2 additions & 2 deletions src/MySql/exports/New-AzMySqlFlexibleServer.ps1
Original file line number Diff line number Diff line change
Expand Up @@ -15,9 +15,9 @@

<#
.Synopsis
Creates a new server.
Creates a new MySQL flexible server.
.Description
Creates a new server.
Creates a new MySQL flexible server.
.Example
PS C:\> New-AzMySqlFlexibleServer -Name mysql-test -ResourceGroupName PowershellMySqlTest \
-Location eastus -AdministratorUserName mysqltest -AdministratorLoginPassword $password -Sku Standard_B1ms -SkuTier Burstable -Version 12 -StorageInMb 10240 -PublicAccess none
Expand Down
8 changes: 4 additions & 4 deletions src/MySql/exports/ProxyCmdletDefinitions.ps1
Original file line number Diff line number Diff line change
Expand Up @@ -4774,7 +4774,7 @@ COMPLEX PARAMETER PROPERTIES
To create the parameters described below, construct a hash table containing the appropriate properties. For information on hash tables, run Get-Help about_Hash_Tables.
INPUTOBJECT <IMySqlIdentity>: Name of the server
INPUTOBJECT <IMySqlIdentity>: The server for the connection string.
[ConfigurationName <String>]: The name of the server configuration.
[DatabaseName <String>]: The name of the database.
[FirewallRuleName <String>]: The name of the server firewall rule.
Expand Down Expand Up @@ -4822,7 +4822,7 @@ param(
[Parameter(ParameterSetName='GetViaIdentity', Mandatory, ValueFromPipeline)]
[Microsoft.Azure.PowerShell.Cmdlets.MySql.Category('Body')]
[Microsoft.Azure.PowerShell.Cmdlets.MySql.Models.IMySqlIdentity]
# Name of the server
# The server for the connection string.
# To construct, see NOTES section for INPUTOBJECT properties and create a hash table.
${InputObject},

Expand Down Expand Up @@ -5287,9 +5287,9 @@ end {

<#
.Synopsis
Creates a new server.
Creates a new MySQL flexible server.
.Description
Creates a new server.
Creates a new MySQL flexible server.
.Example
PS C:\> New-AzMySqlFlexibleServer -Name mysql-test -ResourceGroupName PowershellMySqlTest \
-Location eastus -AdministratorUserName mysqltest -AdministratorLoginPassword $password -Sku Standard_B1ms -SkuTier Burstable -Version 12 -StorageInMb 10240 -PublicAccess none
Expand Down
14 changes: 7 additions & 7 deletions src/MySql/generate-info.json
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
{
"autorest_remodeler": "2.1.27",
"microsoft.azure_autorest.csharp": "2.3.82",
"autorest": "3.0.6187",
"microsoft.azure_autorest-core": "2.0.4417",
"microsoft.azure_autorest.modeler": "2.3.55",
"swagger_commit": "7f837412eb7b50deb8fb8e97a7d78471d42733ae",
"swagger_commit": "96ba256c1f61d4dc2a7928d7658e024b9b1615a6",
"autorest_core": "3.0.6320",
"microsoft.azure_autorest.csharp": "2.3.82",
"autorest_modelerfour": "4.15.414",
"autorest_powershell": "3.0.403",
"node": "v10.16.0"
"node": "v10.16.0",
"microsoft.azure_autorest.modeler": "2.3.55",
"microsoft.azure_autorest-core": "2.0.4417",
"autorest": "3.0.6187",
"autorest_powershell": "3.0.403"
}
2 changes: 1 addition & 1 deletion src/MySql/help/Az.MySql.md
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ Gets a virtual network rule.
Creates a new firewall rule or updates an existing firewall rule.

### [New-AzMySqlFlexibleServer](New-AzMySqlFlexibleServer.md)
Creates a new server.
Creates a new MySQL flexible server.

### [New-AzMySqlFlexibleServerDatabase](New-AzMySqlFlexibleServerDatabase.md)
Creates a new database or updates an existing database.
Expand Down
4 changes: 2 additions & 2 deletions src/MySql/help/Get-AzMySqlFlexibleServerConnectionString.md
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ Accept wildcard characters: False
```
### -InputObject
Name of the server
The server for the connection string.
To construct, see NOTES section for INPUTOBJECT properties and create a hash table.
```yaml
Expand Down Expand Up @@ -160,7 +160,7 @@ COMPLEX PARAMETER PROPERTIES
To create the parameters described below, construct a hash table containing the appropriate properties. For information on hash tables, run Get-Help about_Hash_Tables.
INPUTOBJECT <IMySqlIdentity>: Name of the server
INPUTOBJECT <IMySqlIdentity>: The server for the connection string.
- `[ConfigurationName <String>]`: The name of the server configuration.
- `[DatabaseName <String>]`: The name of the database.
- `[FirewallRuleName <String>]`: The name of the server firewall rule.
Expand Down
4 changes: 2 additions & 2 deletions src/MySql/help/New-AzMySqlFlexibleServer.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ schema: 2.0.0
# New-AzMySqlFlexibleServer

## SYNOPSIS
Creates a new server.
Creates a new MySQL flexible server.

## SYNTAX

Expand All @@ -22,7 +22,7 @@ New-AzMySqlFlexibleServer [-Name <String>] [-ResourceGroupName <String>] [-Subsc
```

## DESCRIPTION
Creates a new server.
Creates a new MySQL flexible server.

## EXAMPLES

Expand Down

0 comments on commit defd596

Please sign in to comment.